From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.365.1615425008561367509 for ; Wed, 10 Mar 2021 17:10:09 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 11 Mar 2021 09:10:02 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Wu, Hao A'" , Cc: "'Wang, Jian J'" References: <20210309012416.1981-1-gaoliming@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0hdIE1kZU1vZHVsZVBrZzogSW5pdGlhbGl6ZSBsb2NhbCB2YXJpYWJsZSB2YWx1ZSBiZWZvcmUgdGhleSBhcmUgdXNlZA==?= Date: Thu, 11 Mar 2021 09:10:04 +0800 Message-ID: <00c401d71613$45790df0$d06b29d0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFgmBTtIriblaX8ocqfGegJvbkskgCpqTDdq2Wo8/A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Hao: Yes. I agree. I will add this information when I merge it.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Wu, Hao A > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA3=D4=C29=C8=D5 10:10 > =CA=D5=BC=FE=C8=CB: Liming Gao ; = devel@edk2.groups.io > =B3=AD=CB=CD: Wang, Jian J > =D6=F7=CC=E2: RE: [PATCH] MdeModulePkg: Initialize local variable = value before they > are used >=20 > > -----Original Message----- > > From: Liming Gao > > Sent: Tuesday, March 9, 2021 9:24 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J ; Wu, Hao A > > > Subject: [PATCH] MdeModulePkg: Initialize local variable value = before they > are > > used > > > > This change is to fix the compiler error on GCC49 release build. >=20 >=20 > Thanks Liming. The patch looks good to me: > Reviewed-by: Hao A Wu >=20 > I have one question that I think both the reports are false positives. > Do you think it will be better to add this information in the commit message? >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Signed-off-by: Liming Gao > > --- > > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > | 1 + > > .../Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c | = 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > index e99a812a44..0779f94f9e 100644 > > --- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > +++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c > > @@ -1122,6 +1122,7 @@ AhciDmaTransfer ( > > > > Map =3D NULL; > > PciIo =3D Instance->PciIo; > > + Status =3D EFI_SUCCESS; > > > > if (PciIo =3D=3D NULL) { > > return EFI_INVALID_PARAMETER; > > diff --git > > > = a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > > > = b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > > index 0c9299c8b0..7822cbf4bb 100644 > > --- > > > = a/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > > +++ > > > = b/MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.c > > @@ -117,6 +117,7 @@ CreateBasicVariablePolicy ( > > > > // Now we've gotta determine the total size of the buffer = required for > > // the VariablePolicy structure. > > + NameSize =3D 0; > > TotalSize =3D sizeof( VARIABLE_POLICY_ENTRY ); > > if (Name !=3D NULL) { > > NameSize =3D StrnSizeS( Name, MAX_UINT16 ); > > -- > > 2.27.0.windows.1 > >