From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Kun Qin'" <kun.q@outlook.com>, <devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list
Date: Thu, 21 Jan 2021 09:45:45 +0800 [thread overview]
Message-ID: <00c701d6ef97$22874980$6795dc80$@byosoft.com.cn> (raw)
In-Reply-To: <MWHPR06MB31024538880017237E9D5388F3A10@MWHPR06MB3102.namprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2428 bytes --]
Qin:
This change makes sense. Can you let me know which case trigs this ECC
issue? Does your patch include such case?
Thanks
Liming
发件人: Kun Qin <kun.q@outlook.com>
发送时间: 2021年1月21日 9:37
收件人: devel@edk2.groups.io
抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
主题: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added
_ModuleEntryPoint into exception list
Hi Bob/Liming/Yuwei,
Do you mind providing some feedback on this patch? This is to unblock the
second patch (adding driver entry point instance for Standalone X64) of this
patch series. Thanks in advance!
Regards,
Kun
From: Kun Qin <mailto:kun.q@outlook.com>
Sent: Thursday, January 14, 2021 14:34
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
Cc: Bob Feng <mailto:bob.c.feng@intel.com> ; Liming Gao
<mailto:gaoliming@byosoft.com.cn> ; Yuwei Chen <mailto:yuwei.chen@intel.com>
Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added
_ModuleEntryPoint into exception list
Function '_ModuleEntryPoint' is a pre-defined interface for various EFI
module types and should not be caught violating EFI coding style. This
change added '_ModuleEntryPoint' into exception list to fix EFI coding
style error 8006 during CI build.
Cc: Bob Feng <bob.c.feng@intel.com <mailto:bob.c.feng@intel.com> >
Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >
Cc: Yuwei Chen <yuwei.chen@intel.com <mailto:yuwei.chen@intel.com> >
Signed-off-by: Kun Qin <kun.q@outlook.com <mailto:kun.q@outlook.com> >
---
Notes:
v3:
- Newly added to fix CI build on changing '_ModuleEntryPoint'
BaseTools/Source/Python/Ecc/exception.xml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/BaseTools/Source/Python/Ecc/exception.xml
b/BaseTools/Source/Python/Ecc/exception.xml
index 8133904fbc7f..f2334aab8e52 100644
--- a/BaseTools/Source/Python/Ecc/exception.xml
+++ b/BaseTools/Source/Python/Ecc/exception.xml
@@ -296,6 +296,10 @@
<KeyWord>_DriverUnloadHandler</KeyWord>
<ErrorID>8006</ErrorID>
</Exception>
+ <Exception>
+ <KeyWord>_ModuleEntryPoint</KeyWord>
+ <ErrorID>8006</ErrorID>
+ </Exception>
<Exception>
<KeyWord>ASSERT</KeyWord>
<ErrorID>10015</ErrorID>
--
2.30.0.windows.1
[-- Attachment #2: Type: text/html, Size: 6637 bytes --]
next prev parent reply other threads:[~2021-01-21 1:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210114223400.2596-1-kun.q@outlook.com>
2021-01-14 22:33 ` [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Kun Qin
2021-01-14 22:33 ` [PATCH v3 02/18] StandaloneMmPkg: StandaloneMmCoreEntryPoint: Extends support for X64 Kun Qin
2021-01-14 22:33 ` [PATCH v3 03/18] StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core Kun Qin
2021-01-14 22:33 ` [PATCH v3 04/18] StandaloneMmPkg: StandaloneMmCoreMemoryAllocationLib: Fix compiler warning Kun Qin
[not found] ` <165A3A1108D15505.7065@groups.io>
2021-01-21 1:34 ` [edk2-devel] [PATCH v3 03/18] StandaloneMmPkg: StandaloneMmCoreHobLib: Extend support for x64 Mm Core Kun Qin
2021-01-26 12:39 ` Yao, Jiewen
[not found] ` <165A3A10BD6EE08F.30138@groups.io>
2021-01-21 1:36 ` [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Kun Qin
2021-01-21 1:45 ` gaoliming [this message]
2021-01-21 1:54 ` Kun Qin
2021-01-22 0:27 ` 回复: " gaoliming
2021-01-26 5:41 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c701d6ef97$22874980$6795dc80$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox