Qin:
This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case?
Thanks
Liming
发件人: Kun Qin <kun.q@outlook.com>
发送时间: 2021年1月21日 9:37
收件人: devel@edk2.groups.io
抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
主题: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list
Hi Bob/Liming/Yuwei,
Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance!
Regards,
Kun
From: Kun Qin
Sent: Thursday, January 14, 2021 14:34
To: devel@edk2.groups.io
Cc: Bob Feng; Liming Gao; Yuwei Chen
Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list
Function '_ModuleEntryPoint' is a pre-defined interface for various EFI
module types and should not be caught violating EFI coding style. This
change added '_ModuleEntryPoint' into exception list to fix EFI coding
style error 8006 during CI build.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Kun Qin <kun.q@outlook.com>
---
Notes:
v3:
- Newly added to fix CI build on changing '_ModuleEntryPoint'
BaseTools/Source/Python/Ecc/exception.xml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/BaseTools/Source/Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml
index 8133904fbc7f..f2334aab8e52 100644
--- a/BaseTools/Source/Python/Ecc/exception.xml
+++ b/BaseTools/Source/Python/Ecc/exception.xml
@@ -296,6 +296,10 @@
<KeyWord>_DriverUnloadHandler</KeyWord>
<ErrorID>8006</ErrorID>
</Exception>
+ <Exception>
+ <KeyWord>_ModuleEntryPoint</KeyWord>
+ <ErrorID>8006</ErrorID>
+ </Exception>
<Exception>
<KeyWord>ASSERT</KeyWord>
<ErrorID>10015</ErrorID>
--
2.30.0.windows.1