From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.1041.1611193546391277652 for ; Wed, 20 Jan 2021 17:45:47 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 21 Jan 2021 09:45:42 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kun Qin'" , Cc: "'Bob Feng'" , "'Yuwei Chen'" References: <20210114223400.2596-1-kun.q@outlook.com>,<165A3A10BD6EE08F.30138@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYzIDAxLzE4XSBCYXNlVG9vbHM6IEVjYy9leGNlcHRpb246IEFkZGVkIF9Nb2R1bGVFbnRyeVBvaW50IGludG8gZXhjZXB0aW9uIGxpc3Q=?= Date: Thu, 21 Jan 2021 09:45:45 +0800 Message-ID: <00c701d6ef97$22874980$6795dc80$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG2Xa4cDUUqX77fSiNZQxL+hYHiYAKPEjxPAYYoIluqUcfroA== Content-Type: multipart/alternative; boundary="----=_NextPart_000_00C8_01D6EFDA.30AB4CD0" Content-Language: zh-cn ------=_NextPart_000_00C8_01D6EFDA.30AB4CD0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Qin: This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case? =20 Thanks Liming =B7=A2=BC=FE=C8=CB: Kun Qin =20 =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA1=D4=C221=C8=D5 9:37 =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io =B3=AD=CB=CD: Bob Feng ; Liming Gao ; Yuwei Chen =D6=F7=CC=E2: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: = Added _ModuleEntryPoint into exception list =20 Hi Bob/Liming/Yuwei, =20 Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of th= is patch series. Thanks in advance! =20 Regards, Kun =20 From: Kun Qin =20 Sent: Thursday, January 14, 2021 14:34 To: devel@edk2.groups.io =20 Cc: Bob Feng ; Liming Gao ; Yuwei Chen Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list =20 Function '_ModuleEntryPoint' is a pre-defined interface for various EFI module types and should not be caught violating EFI coding style. This change added '_ModuleEntryPoint' into exception list to fix EFI coding style error 8006 during CI build. Cc: Bob Feng > Cc: Liming Gao = > Cc: Yuwei Chen > Signed-off-by: Kun Qin > --- Notes: v3: - Newly added to fix CI build on changing '_ModuleEntryPoint' BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Source/Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml index 8133904fbc7f..f2334aab8e52 100644 --- a/BaseTools/Source/Python/Ecc/exception.xml +++ b/BaseTools/Source/Python/Ecc/exception.xml @@ -296,6 +296,10 @@ _DriverUnloadHandler 8006 + + _ModuleEntryPoint + 8006 + ASSERT 10015 --=20 2.30.0.windows.1 =20 ------=_NextPart_000_00C8_01D6EFDA.30AB4CD0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
Qin:

 This change makes = sense. Can you let me know which case trigs this ECC issue? Does your patch= include such case?

 

Thanks

Liming

=B7=A2=BC=FE=C8=CB: Kun Qin <kun.q@outl= ook.com>
=B7=A2=CB=CD= = =CA=B1=BC=E4: 2021=C4=EA1=D4=C221=C8=D5<= span lang=3DEN-US> 9:37
=CA=D5=BC=FE=C8=CB:= devel@edk2.groups.io
=B3=AD=CB= =CD: Bob Feng <bob.c.f= eng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Yuwei Chen = <yuwei.chen@intel.com>
=D6=F7=CC=E2:<= /span> RE: [edk2-devel] [PATCH v3 01/18] BaseTools: = Ecc/exception: Added _ModuleEntryPoint into exception list

 =

Hi Bob/Liming/Yuwe= i,

 =

Do you mind provid= ing some feedback on this patch? This is to unblock the second patch (addin= g driver entry point instance for Standalone X64) of this patch series. Tha= nks in advance!

 

Regar= ds,

Kun

 

From: Kun Qin
Sent: Thursday, January 14, 2021 14:34
To: devel@edk2.groups.io
Cc: Bob Feng; Liming Gao; Yuwei Che= n
Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/excep= tion: Added _ModuleEntryPoint into exception list

 

Function = '_ModuleEntryPoint' is a pre-defined interface for various EFI
module ty= pes and should not be caught violating EFI coding style. This
change add= ed '_ModuleEntryPoint' into exception list to fix EFI coding
style error= 8006 during CI build.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuw= ei Chen <yuwei.chen@intel.com>

Signed-off-by: Kun Qin <kun.q@outlook.com>
---

Notes:
    v3:<= br>    - Newly added to fix CI build on changing '_ModuleEnt= ryPoint'

 BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+)

diff --git a/BaseTools/Source= /Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml
in= dex 8133904fbc7f..f2334aab8e52 100644
--- a/BaseTools/Source/Python/Ecc/= exception.xml
+++ b/BaseTools/Source/Python/Ecc/exception.xml
@@ -296= ,6 +296,10 @@
     <KeyWord>_DriverUnloadHandl= er</KeyWord>
     <ErrorID>8006</Erro= rID>
   </Exception>
+  <Exception>
= +    <KeyWord>_ModuleEntryPoint</KeyWord>
+&n= bsp;   <ErrorID>8006</ErrorID>
+  </Except= ion>
   <Exception>
     <K= eyWord>ASSERT</KeyWord>
     <ErrorID>= ;10015</ErrorID>
--
2.30.0.windows.1



 

------=_NextPart_000_00C8_01D6EFDA.30AB4CD0--