From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.1591.1620438196483160949 for ; Fri, 07 May 2021 18:43:17 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sat, 08 May 2021 09:43:10 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'James Bottomley'" , "'Min Xu'" , "'Jiewen Yao'" , "'Tom Lendacky'" , "'Jordan Justen'" , "'Ard Biesheuvel'" , "'Laszlo Ersek'" , "'Erdem Aktas'" , "'Michael D Kinney'" , "'Zhiguang Liu'" References: <20210507203838.23706-1-brijesh.singh@amd.com> In-Reply-To: <20210507203838.23706-1-brijesh.singh@amd.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDAwLzEzXSBBZGQgR0hDQnYyIG1hY3JvIGFuZCBoZWxwZXJz?= Date: Sat, 8 May 2021 09:43:09 +0800 Message-ID: <00cb01d743ab$801ecdd0$805c6970$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGmg5SBBXp3U+lFeWHzZ0GP9stlmKs6TvcA Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Brijesh: The changes in MdePkg is good to me. Reviewed-by: Liming Gao One minor comment is in Patch2. Its title should be MdePkg/Register/Amd: xxxx to align other patches.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Brijesh Singh > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C28=C8=D5 4:38 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Brijesh Singh ; James Bottomley > ; Min Xu ; Jiewen Yao > ; Tom Lendacky ; > Jordan Justen ; Ard Biesheuvel > ; Laszlo Ersek ; Erdem > Aktas ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > =D6=F7=CC=E2: [edk2-devel] [PATCH 00/13] Add GHCBv2 macro and helpers >=20 > This series is taken from the SNP RFC. This series defines the GHCBv2 > macros and NAE events. Additionally, it also introduces a helper to > clear the page encryption mask from the Mmio region. >=20 > The series is based on the commit: > f297b7f20010 UnitTestFrameworkPkg: Sample unit test hangs when running > in OVMF/QEMU >=20 > Cc: James Bottomley > Cc: Min Xu > Cc: Jiewen Yao > Cc: Tom Lendacky > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Erdem Aktas > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu >=20 > Brijesh Singh (11): > MdePkg/Register/Amd: expand the SEV MSR to include the SNP definition > MdePkg/Amd: add white spaces to retain alignment for future expansion > MdePkg/Register/Amd: define GHCB macros for hypervisor feature > detection > MdePkg/Register/Amd: define GHCB macro for Register GPA structure > MdePkg/Register/Amd: define GHCB macro for the Page State Change > MdePkg/BaseLib: add support for PVALIDATE instruction > OvmfPkg/BaseMemEncryptSevLib: introduce > MemEncryptSevClearMmioPageEncMask() > OvmfPkg/AmdSevDxe: use MemEncryptSevClearMmioPageEncMask() to > clear > EncMask > OvmfPkg/QemuFlashFvbServicesRuntimeDxe: use Mmio helper to clear > enc > mask > OvmfPkg/TpmMmioSevDecryptPei: use > MemEncryptSevClearMmioPageEncMask() > OvmfPkg/BaseMemEncryptSevLib: remove Flush parameter >=20 > Tom Lendacky (2): > MdePkg/Register/Amd: define GHCB macros for SNP AP creation > MdePkg/BaseLib: add support for RMPADJUST instruction >=20 > MdePkg/Library/BaseLib/BaseLib.inf | 2 + > MdePkg/Include/Library/BaseLib.h | 80 ++++++++++++ > MdePkg/Include/Register/Amd/Fam17Msr.h | 46 ++++++- > MdePkg/Include/Register/Amd/Ghcb.h | 123 > +++++++++++++++++- > OvmfPkg/Include/Library/MemEncryptSevLib.h | 35 +++-- > .../BaseMemEncryptSevLib/X64/VirtualMemory.h | 33 +++-- > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 13 +- > OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 6 +- > .../Ia32/MemEncryptSevLib.c | 41 ++++-- > .../X64/MemEncryptSevLib.c | 49 +++++-- > .../X64/PeiDxeVirtualMemory.c | 63 +++++++-- > .../X64/SecVirtualMemory.c | 8 +- > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 3 +- > OvmfPkg/PlatformPei/AmdSev.c | 3 +- > .../FwBlockServiceDxe.c | 5 +- > .../QemuFlashSmm.c | 5 +- > .../TpmMmioSevDecryptPeim.c | 5 +- > MdePkg/Include/X64/Nasm.inc | 16 +++ > MdePkg/Library/BaseLib/X64/Pvalidate.nasm | 42 ++++++ > MdePkg/Library/BaseLib/X64/RmpAdjust.nasm | 40 ++++++ > 20 files changed, 526 insertions(+), 92 deletions(-) > create mode 100644 MdePkg/Library/BaseLib/X64/Pvalidate.nasm > create mode 100644 MdePkg/Library/BaseLib/X64/RmpAdjust.nasm >=20 > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20