From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3266C74003E for ; Tue, 28 May 2024 09:16:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iBAcQIJow+u5yx8djZ7VMKBsGowT/JWW/PMZItKNO2Q=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1716887800; v=1; b=rgD7ZvNKRaE8+apYmVtuV5UoVCfG+0tY7P3eTQ/ljIyHJyJg3wu49OP3JNEHHdoBiF5AiJ7F Ibu0NN59BPgy5eaheVPYIoI/wyMuVDTgxAomOyU9oCmWsvC3bXLMWkkP8zXoQvuKhNs3BkO1nxO MUB4K53FWj5yfvEUWjWtqnzqq34UEC3oOZYq37dj6HY0d3u6IfFTRPX0JjEA5v1U2t1GLFq4a52 pUnjljrIXF8/I+PW1cYFeoEwxa3g9X1own1d79qMoDkKnM7HJiZPfCNiG9t2XmsobxQQDSi62wF q7eFDFJe0IcyS9oPKpxLzfiRs/1bUhvqSW/EmUyZV8xjA== X-Received: by 127.0.0.2 with SMTP id D6YCYY7687511xcpKATPedHJ; Tue, 28 May 2024 02:16:39 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.17786.1716887798677005991 for ; Tue, 28 May 2024 02:16:39 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 1714BDDA7AB for ; Tue, 28 May 2024 17:16:37 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 134A6DDA7A0 for ; Tue, 28 May 2024 17:16:37 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 69B7CDDA78D for ; Tue, 28 May 2024 17:16:34 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 28 May 2024 17:16:31 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Ni, Ray'" , "'Wang, Jian J'" References: <20240517094610.533-1-dun.tan@intel.com> <17D03DA5161A67E3.17823@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIFYyIDE3LzE4XSBNZGVNb2R1bGVQa2c6UmVtb3ZlIE1wU2VydmljZTJQcGkgZmllbGQgaW4gU01NX1MzX1JFU1VNRV9TVEFURQ==?= Date: Tue, 28 May 2024 17:16:33 +0800 Message-ID: <00cc01dab0df$bc087f40$34197dc0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIg5H60iQpt8qSJAlTHmgqzctF64gISVnDaAUbvIhCxBSvdkA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 28 May 2024 02:16:39 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QVdQItCw8opS2cJXyzbLOtJSx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rgD7ZvNK; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Dun: To be compatible, I suggest to keep the same layout of SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not used an= y more.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED duntan > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA5=D4=C228=C8=D5 14:35 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Tan, Dun ; L= iming Gao > > =B3=AD=CB=CD: Ni, Ray ; Wang, Jian J > =D6=F7=CC=E2: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpSer= vice2Ppi > field in SMM_S3_RESUME_STATE >=20 > Hi Liming, >=20 > Could you please help to review this patch? > This patch set is to simplify the X86 CPU SMM driver by removing most of S3 > related logics and we want to merge it as soon as possible. >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, May 17, 2024 5:46 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Liming > Gao > Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove MpService2Ppi > field in SMM_S3_RESUME_STATE >=20 > This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP to d= o > the CPU initialization during smm s3 boot when the execution mode of PEI and > DXE are the same. > Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup AP > anymore. The initialization for AP will be done in S3Resume.c before transfer to > CpuS3.c of smm cpu driver. > So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE. >=20 > Signed-off-by: Dun Tan > Reviewed-by: Ray Ni > Cc: Jian J Wang > Cc: Liming Gao > --- > MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h > b/MdeModulePkg/Include/Guid/AcpiS3Context.h > index 72d173c4fd..6c7237727e 100644 > --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h > +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h > @@ -1,7 +1,7 @@ > /** @file > Definitions for data structures used in S3 resume. >=20 > -Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.
> +Copyright (c) 2011 - 2024, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -30,7 +30,6 @@ typedef struct { > EFI_PHYSICAL_ADDRESS ReturnContext1; > EFI_PHYSICAL_ADDRESS ReturnContext2; > EFI_PHYSICAL_ADDRESS ReturnStackPointer; > - EFI_PHYSICAL_ADDRESS MpService2Ppi; > EFI_PHYSICAL_ADDRESS Smst; > } SMM_S3_RESUME_STATE; >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119295): https://edk2.groups.io/g/devel/message/119295 Mute This Topic: https://groups.io/mt/106345448/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-