回复: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first include guard

["gaoliming" <gaoliming@byosoft.com.cn>]

Is this checker for .h file only?

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> PierreGondois
> 发送时间: 2021年3月10日 0:17
> 收件人: devel@edk2.groups.io; bob.c.feng@intel.com;
> gaoliming@byosoft.com.cn; yuwei.chen@intel.com
> 主题: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc only check first
> include guard
> 
> From: Pierre Gondois <Pierre.Gondois@arm.com>
> 
> The Ecc tool checks the format of the include guard. This check is
> currently done on all the names following the '#ifndef' statement.
> It should only be done on the first include guard.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3252
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> The changes can be seen at:
> https://github.com/PierreARM/edk2/tree/1640_Ecc_tool_corrections
> 
>  BaseTools/Source/Python/Ecc/Check.py | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/Ecc/Check.py
> b/BaseTools/Source/Python/Ecc/Check.py
> index 7a012617fd35..d82b42de0119 100644
> --- a/BaseTools/Source/Python/Ecc/Check.py
> +++ b/BaseTools/Source/Python/Ecc/Check.py
> @@ -3,6 +3,7 @@
>  #
>  # Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
>  # Copyright (c) 2008 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
>  from __future__ import absolute_import
> @@ -1437,11 +1438,13 @@ class Check(object):
> 
>              SqlCommand = """select ID, Value from %s where Model
> = %s""" % (FileTable, MODEL_IDENTIFIER_MACRO_IFNDEF)
>              RecordSet = EccGlobalData.gDb.TblFile.Exec(SqlCommand)
> -            for Record in RecordSet:
> -                Name = Record[1].replace('#ifndef', '').strip()
> +            if RecordSet:
> +                # Only check the first ifndef statement of the file
> +                FirstDefine = sorted(RecordSet, key=lambda Record:
> Record[0])[0]
> +                Name = FirstDefine[1].replace('#ifndef', '').strip()
>                  if Name[0] == '_' or Name[-1] != '_' or Name[-2] == '_':
>                      if not
> EccGlobalData.gException.IsException(ERROR_NAMING_CONVENTION_CHE
> CK_IFNDEF_STATEMENT, Name):
> -
> EccGlobalData.gDb.TblReport.Insert(ERROR_NAMING_CONVENTION_CHECK
> _IFNDEF_STATEMENT, OtherMsg="The #ifndef name [%s] does not follow the
> rules" % (Name), BelongsToTable=FileTable, BelongsToItem=Record[0])
> +
> EccGlobalData.gDb.TblReport.Insert(ERROR_NAMING_CONVENTION_CHECK
> _IFNDEF_STATEMENT, OtherMsg="The #ifndef name [%s] does not follow the
> rules" % (Name), BelongsToTable=FileTable, BelongsToItem=FirstDefine[0])
> 
>      # Rule for path name, variable name and function name
>      # 1. First character should be upper case
> --
> 2.17.1
> 
> 
> 
> 
>