From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 19BBF78003C for ; Mon, 15 Apr 2024 03:25:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oDSmbElMKnk5uLcfS/mWARe0CkMPNf/MCAaEvhx7jJA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1713151518; v=1; b=vpcCef6ivOSo4r+v5nzaCsa/6kkqjTY3orfWna3ENW1Wovs+o8rnt4ZZpjGvhqotqqh2dWzu LMpWyDPdzDeFlwQogltJt9DjwCEgYVGuQ+vYnTdMRdz2iFRBZbUR2GzTclL8BkFzbLezchHlG2a lWXtDXbOf2gGiJhgM5GT87/BSKquT7xNQUMCERQsefsEK7GbOouteVSpX39QQb001imLlfnWNqc OHf9/ZRfLspKl02o9H+N0UHAd49V9ZQgN8hmZ2iJ2rrnfDPcQ23DNzQErGSn7LG5oQg6Z+ImPHZ Q3IeErand9lAlfcUTEmiLVz2pEv+Ooyvag5eNSBq6L9fw== X-Received: by 127.0.0.2 with SMTP id 21g4YY7687511x2gG7PyAL6l; Sun, 14 Apr 2024 20:25:18 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.12709.1713151517462492614 for ; Sun, 14 Apr 2024 20:25:17 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 7FD3DDDA7A0 for ; Mon, 15 Apr 2024 11:25:15 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 7B6A6DDA79E for ; Mon, 15 Apr 2024 11:25:15 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id DE4C1DDA7C4 for ; Mon, 15 Apr 2024 11:25:12 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 15 Apr 2024 11:25:07 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Rebecca Cran'" , "'Bob Feng'" , "'Yuwei Chen'" References: <20240322191915.184-1-taylor.d.beebe@gmail.com> <062501da80ab$62ddd8c0$28998a40$@byosoft.com.cn> <968375d9-d671-491d-a544-3372089788a8@gmail.com> <018f01da849e$4caff4b0$e60fde10$@byosoft.com.cn> <92b0faf2-dc7b-4b69-ac24-cd96c071748c@gmail.com> In-Reply-To: <92b0faf2-dc7b-4b69-ac24-cd96c071748c@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MiAwLzJdIFVwZGF0ZSBCYXNlVG9vbHMgTlVMTCBJbmNsdWRlIGFuZCBMaWJyYXJ5IE1hdGNoaW5n?= Date: Mon, 15 Apr 2024 11:25:08 +0800 Message-ID: <00d301da8ee4$84b282b0$8e178810$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIo6TJ5At+K+jnggj+uNmzK8TZe2QJ3HOUhAw9d+GUBvzr0sQLTYmIQsHst07A= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 14 Apr 2024 20:25:17 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6MgUPK5j4Vq8qy2tJn73kNakx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vpcCef6i; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks for your update. Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Taylor Beebe > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8810=E6=97=A5 = 3:43 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.= cn > =E6=8A=84=E9=80=81: 'Rebecca Cran' ; 'Bob Feng' > ; 'Yuwei Chen' > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: =E5=9B=9E=E5=A4=8D: [edk2-dev= el] [PATCH v2 0/2] Update BaseTools NULL > Include and Library Matching >=20 > Hi Liming, >=20 > I made a mistake in patch 2 of the v2 series. In v3, lines 126 and 144 > of WorkspaceCommon.py update the check to: >=20 > `LibraryClassName[4:].isdigit()` >=20 > instead of >=20 > `LibraryClass[4:].isdigit()` >=20 > Can you re-review with this change? >=20 > -Taylor >=20 > On 4/1/2024 6:37 PM, gaoliming via groups.io wrote: > > Taylor: > > Thanks for you detail information. I understand this problem. I agre= e > your fix. Reviewed-by: Liming Gao > > > > Thanks > > Liming > > >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117747): https://edk2.groups.io/g/devel/message/117747 Mute This Topic: https://groups.io/mt/105529073/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-