From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.40052.1636341463476744235 for ; Sun, 07 Nov 2021 19:17:44 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 08 Nov 2021 11:17:40 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Jiang, Xiaolu'" , Cc: "'Feng, Bob C'" , "'Chen, Christine'" , "'Fu, Siyuan'" References: <20211106035056.183-1-xiaolu.jiang@intel.com> <00a601d7d43e$0ae9bbf0$20bd33d0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF1bUEFUQ0hdIEJhc2VUb29sczogSW5jcmVhc2UgdGhlIERldmljZVBhdGggbGVuZ3RoIGZvciBzdXBwb3J0IG1vcmUgUENEIHZhbHVlLg==?= Date: Mon, 8 Nov 2021 11:17:41 +0800 Message-ID: <00d701d7d44f$3095af60$91c10e20$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGP8/mGim3ncWd7smgM7uUFjrw3TQFinKTmAWS8DzcBUIgETKxn9yOQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Xiaolu: Can you calculate the required memory, then allocate it instead of use = hard code memory length? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Jiang, Xiaolu > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B411=E6=9C=888=E6=97=A5 10:26 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; = devel@edk2.groups.io > =E6=8A=84=E9=80=81: Feng, Bob C ; Chen, = Christine > ; Fu, Siyuan > =E4=B8=BB=E9=A2=98: RE: [edk2-devel][PATCH] BaseTools: Increase the = DevicePath length for > support more PCD value. >=20 > Hi Liming, >=20 > I have checked with Team member , Totally We need support 50+ Driver = GUID > in DevicePath PCD value =EF=BC=8CSo the length need to increase again, = I will change > the Patch and re-send again. >=20 > Thanks! >=20 > -----Original Message----- > From: Jiang, Xiaolu > Sent: Monday, November 8, 2021 9:24 AM > To: gaoliming ; devel@edk2.groups.io > Cc: Feng, Bob C ; Chen, Christine > > Subject: RE: [edk2-devel][PATCH] BaseTools: Increase the DevicePath = length > for support more PCD value. >=20 > 1. Currently the PCD value length is More than 1024, less than 2048, = 2. Now > we have 14 members, Also need to add 4~6 part to the PCD. > So we Increase the length to 4096. >=20 > -----Original Message----- > From: gaoliming > Sent: Monday, November 8, 2021 9:15 AM > To: Jiang, Xiaolu ; devel@edk2.groups.io > Cc: Feng, Bob C ; Chen, Christine > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel][PATCH] BaseTools: Increase = the DevicePath > length for support more PCD value. >=20 > Xiaolu: > Why choose 4096? Is it enough? >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Xiaolu.Jiang > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B411=E6=9C=886=E6=97=A5 11:51 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Xiaolu.Jiang ; Bob Feng > > ; Liming Gao ; Yuwei > > Chen > > =E4=B8=BB=E9=A2=98: [edk2-devel][PATCH] BaseTools: Increase the = DevicePath length for > > support more PCD value. > > > > Currently the PCD Value only support 13 Guid,When use more 13 pcd = will > > cause the build tool fail, Need increase the DevicePath length to > > support more value. > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3718 > > > > Cc: Bob Feng > > Cc: Liming Gao > > Cc: Yuwei Chen > > > > Signed-off-by: Xiaolu Jiang > > --- > > BaseTools/Source/C/DevicePath/DevicePath.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Source/C/DevicePath/DevicePath.c > > b/BaseTools/Source/C/DevicePath/DevicePath.c > > index c4d224ed61..ef493f5506 100644 > > --- a/BaseTools/Source/C/DevicePath/DevicePath.c > > +++ b/BaseTools/Source/C/DevicePath/DevicePath.c > > @@ -170,7 +170,7 @@ int main(int argc, CHAR8 *argv[]) > > fprintf(stderr, "Invalid option value, Device Path can't be > > NULL"); > > > > return STATUS_ERROR; > > > > } > > > > - Str16 =3D (CHAR16 *)malloc(1024); > > > > + Str16 =3D (CHAR16 *)malloc(4096); > > > > if (Str16 =3D=3D NULL) { > > > > fprintf(stderr, "Resource, memory cannot be allocated"); > > > > return STATUS_ERROR; > > > > -- > > 2.30.2.windows.1 >=20 >=20