From: Laszlo Ersek <lersek@redhat.com>
To: "Ni, Ruiyu" <ruiyu.ni@Intel.com>, Eric Dong <eric.dong@intel.com>,
edk2-devel@lists.01.org
Subject: Re: [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table.
Date: Tue, 9 Oct 2018 11:14:11 +0200 [thread overview]
Message-ID: <00d98002-fa7e-58a3-3f19-e00f0db4f297@redhat.com> (raw)
In-Reply-To: <86397fca-fa57-470a-8ca0-31e9ad1204b2@Intel.com>
On 10/09/18 10:59, Ni, Ruiyu wrote:
> On 10/9/2018 4:25 PM, Laszlo Ersek wrote:
>> - for clarity, please use ~(UINTN)BIT31 as mask (even though it makes no
>> practical difference).
> Actually we could use IA32_CR0 structure to avoid BIT31 usage.
That's a great idea.
I wish I had known about IA32_CR0 (and IA32_CR4) earlier! Now we have a
bunch of ad-hoc bitmask macros around the tree, e.g. CR0_WP, CR0_PG,
CR4_PSE, CR4_PAE in "UefiCpuPkg/CpuDxe/CpuPageTable.c".
Thanks!
Laszlo
prev parent reply other threads:[~2018-10-09 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 6:01 [Patch v3] UefiCpuPkg/S3Resume2Pei: disable paging before creating new page table Eric Dong
2018-10-09 7:48 ` Ni, Ruiyu
2018-10-09 8:25 ` Laszlo Ersek
2018-10-09 8:59 ` Ni, Ruiyu
2018-10-09 9:14 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d98002-fa7e-58a3-3f19-e00f0db4f297@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox