From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4411EAC0CAD for ; Thu, 30 May 2024 05:00:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ITr/I/nXfsEi84PiSuL5s07+TxTfZANrr3gAXc6Tq78=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1717045231; v=1; b=IOqqmeua5TE1WYkEPh0ZIuPptReAfFEohlrchBsgW034T9gR9HeLE7OzH528grLtgz1Zegeo xrDt33saRIgol6jbeb7l2ooZqZHRcSTRDpQHqFjmZxbDvIICopZ0z6BwcijAahDlKgNlp49fJOp nbTmPlau21WiY9/h6TWIkNo8lo9NQsyhREAowOx5G/7AZdMp6YNiaaYFpvmzkOCy64VHP2pOVjt AwyXP2lvDAxt14k8R0LcA7JbmPIFhaAEqgWz9/o42TSyv7JijIiRZKfS6xtolDrnr0VCn9D2jIM PN/dr0NL6IMGIYJA2/GsaRIe6GMcSiyHIL49y8qfy6Yww== X-Received: by 127.0.0.2 with SMTP id b7DqYY7687511xdGJmtc5hiF; Wed, 29 May 2024 22:00:29 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.853.1717045227219780933 for ; Wed, 29 May 2024 22:00:28 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 86053A32E032 for ; Thu, 30 May 2024 13:00:24 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 6E8BCA32E01C for ; Thu, 30 May 2024 13:00:24 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 986F7A32E031 for ; Thu, 30 May 2024 13:00:21 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 30 May 2024 13:00:17 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Tan, Dun'" , Cc: "'Ni, Ray'" , "'Wang, Jian J'" References: <20240517094610.533-1-dun.tan@intel.com> <17D03DA5161A67E3.17823@groups.io> <00cc01dab0df$bc087f40$34197dc0$@byosoft.com.cn> <00d301dab0e2$e4268c80$ac73a580$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIFYyIDE3LzE4XSBNZGVNb2R1bGVQa2c6UmVtb3ZlIE1wU2VydmljZTJQcGkgZmllbGQgaW4gU01NX1MzX1JFU1VNRV9TVEFURQ==?= Date: Thu, 30 May 2024 13:00:21 +0800 Message-ID: <00dc01dab24e$465e7680$d31b6380$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIg5H60iQpt8qSJAlTHmgqzctF64gISVnDaAUbvIhABErgAugGODL+RAknXHq8Cgc3ELLDMphDg Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 22:00:28 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UikYbAn9D7k7jH77o9FaGNTIx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=IOqqmeua; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Tan, Dun > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8828=E6=97=A5 = 17:44 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@= edk2.groups.io > =E6=8A=84=E9=80=81: Ni, Ray ; Wang, Jian J > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove= MpService2Ppi > field in SMM_S3_RESUME_STATE >=20 > Liming, >=20 > Sure, I think we can remove the field. Could you please add your reviewed= -by for > this patch? >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: gaoliming > Sent: Tuesday, May 28, 2024 5:39 PM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [Patch V2 17/18] MdeModulePkg:R= emove > MpService2Ppi field in SMM_S3_RESUME_STATE >=20 > Dun: > If you confirm that there is no impact on the existing module, you can = remove > it. >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Tan, Dun > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8828=E6=97= =A5 17:34 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; deve= l@edk2.groups.io > > =E6=8A=84=E9=80=81: Ni, Ray ; Wang, Jian J > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remo= ve > > MpService2Ppi field in SMM_S3_RESUME_STATE > > > > Hi Liming, > > > > Sorry I didn't get what the code needs to be compatible with. Could > > you please explain more? > > The MpService2Ppi field was added in " MdeModulePkg: add MpService2Ppi > > field in SMM_S3_RESUME_STATE"( b1955cddb2) last year by me. Previously > > It was added to simplify the code logic to wakeup AP in S3 boot > > related code of CPU SMM driver when code execution modes for PEI and > > DXE are the same. In this patch set, all the related code logic was rem= oved. > > > > Thanks, > > Dun > > > > -----Original Message----- > > From: gaoliming > > Sent: Tuesday, May 28, 2024 5:17 PM > > To: devel@edk2.groups.io; Tan, Dun > > Cc: Ni, Ray ; Wang, Jian J > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [Patch V2 17/18] MdeModulePkg= :Remove > > MpService2Ppi field in SMM_S3_RESUME_STATE > > > > Dun: > > To be compatible, I suggest to keep the same layout of > > SMM_S3_RESUME_STATE. MpService2Ppi field can be kept, but it is not > > used any more. > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 duntan > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=8828=E6=97= =A5 14:35 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Tan, Dun ; Liming Gao > > > > > > =E6=8A=84=E9=80=81: Ni, Ray ; Wang, Jian J > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Re= move > > > MpService2Ppi field in SMM_S3_RESUME_STATE > > > > > > Hi Liming, > > > > > > Could you please help to review this patch? > > > This patch set is to simplify the X86 CPU SMM driver by removing > > > most of > > S3 > > > related logics and we want to merge it as soon as possible. > > > > > > Thanks, > > > Dun > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > duntan > > > Sent: Friday, May 17, 2024 5:46 PM > > > To: devel@edk2.groups.io > > > Cc: Ni, Ray ; Wang, Jian J > > > ; > > Liming > > > Gao > > > Subject: [edk2-devel] [Patch V2 17/18] MdeModulePkg:Remove > > > MpService2Ppi field in SMM_S3_RESUME_STATE > > > > > > This MpService2Ppi field in SMM_S3_RESUME_STATE is used to wakeup AP > > > to do the CPU initialization during smm s3 boot when the execution > > > mode of PEI > > and > > > DXE are the same. > > > Currently, in CpuS3.c of smm cpu driver, BSP doesn't need to wakeup > > > AP anymore. The initialization for AP will be done in S3Resume.c > > > before > > transfer to > > > CpuS3.c of smm cpu driver. > > > So we can remove the MpService2Ppi field in SMM_S3_RESUME_STATE. > > > > > > Signed-off-by: Dun Tan > > > Reviewed-by: Ray Ni > > > Cc: Jian J Wang > > > Cc: Liming Gao > > > --- > > > MdeModulePkg/Include/Guid/AcpiS3Context.h | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/MdeModulePkg/Include/Guid/AcpiS3Context.h > > > b/MdeModulePkg/Include/Guid/AcpiS3Context.h > > > index 72d173c4fd..6c7237727e 100644 > > > --- a/MdeModulePkg/Include/Guid/AcpiS3Context.h > > > +++ b/MdeModulePkg/Include/Guid/AcpiS3Context.h > > > @@ -1,7 +1,7 @@ > > > /** @file > > > Definitions for data structures used in S3 resume. > > > > > > -Copyright (c) 2011 - 2023, Intel Corporation. All rights > > > reserved.
> > > +Copyright (c) 2011 - 2024, Intel Corporation. All rights > > > +reserved.
> > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -30,7 +30,6 @@ typedef struct { > > > EFI_PHYSICAL_ADDRESS ReturnContext1; > > > EFI_PHYSICAL_ADDRESS ReturnContext2; > > > EFI_PHYSICAL_ADDRESS ReturnStackPointer; > > > - EFI_PHYSICAL_ADDRESS MpService2Ppi; > > > EFI_PHYSICAL_ADDRESS Smst; > > > } SMM_S3_RESUME_STATE; > > > > > > -- > > > 2.31.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > > > > > > >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119377): https://edk2.groups.io/g/devel/message/119377 Mute This Topic: https://groups.io/mt/106383229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-