From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.1601.1623806112906186889 for ; Tue, 15 Jun 2021 18:15:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaojie@byosoft.com.cn) Received: from DESKTOP6Q83COE ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 16 Jun 2021 09:15:05 +0800 X-WM-Sender: gaojie@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaojie@byosoft.com.cn From: "Gao Jie" To: , , "'Samer El-Haj-Mahmoud'" , "'Heinrich Schuchardt'" Cc: "'G Edhaya Chandran'" , "'Michael D Kinney'" References: <20210611083521.1127-1-Sunny.Wang@arm.com> <1f992968-484a-3df0-ebeb-97c11012e87d@gmx.de> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItdGVzdF1bUEFUQ0ggdjIgMS8xXSB1ZWZpLXNjdC9TY3RQa2c6IE5vdCBjcmVhdGUgZXZlbnQgd2l0aCBUUExfSElHSF9MRVZFTA==?= Date: Wed, 16 Jun 2021 09:15:06 +0800 Message-ID: <00df01d7624d$0af8a470$20e9ed50$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFmEGAWygDAlTvcER1ANNlvZS8ZGwHIF2+UAogQ3bsBy8sf9KvHl+tQ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Hi Sunny, I believe the result with 13 passes should be tested *with* this fix, righ= t? I saw reviewed-by/Acked-by from Samer and Heinrich, will get this patch up= streamed soon. Thanks Barton -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Sunny Wang =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8814=E6=97=A5 1= 7:53 =E6=94=B6=E4=BB=B6=E4=BA=BA: Samer El-Haj-Mahmoud ; Heinrich Schuchardt ; devel@edk2.groups.io =E6=8A=84=E9=80=81: G Edhaya Chandran ; Barton Ga= o ; Michael D Kinney ; S= unny Wang =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/Sc= tPkg: Not create event with TPL_HIGH_LEVEL Thanks for the review, Samer. Moreover, I just built it and tested it on my ARM system, and confirmed th= e issue got fixed by this patch. Without this fix, the result would be 18 tests, and 4 Errors. CreateEvent_Func: [FAILED] Passes........... 14 Warnings......... 0 Errors........... 4 Without this fix, the result would be 13 tests, and 0 Errors. CreateEvent_Func: [PASSED] Passes........... 13 Warnings......... 0 Errors........... 0 Best Regards, Sunny Wang -----Original Message----- From: Samer El-Haj-Mahmoud Sent: Monday, June 14, 2021 8:36 AM To: Heinrich Schuchardt ; Sunny Wang ; devel@edk2.groups.io Cc: G Edhaya Chandran ; Barton Gao ; Michael D Kinney ; Samer El-Haj-Mahm= oud Subject: RE: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event w= ith TPL_HIGH_LEVEL Reviewed-By: Samer El-Haj-Mahmoud > -----Original Message----- > From: Heinrich Schuchardt > Sent: Friday, June 11, 2021 5:15 AM > To: Sunny Wang ; devel@edk2.groups.io > Cc: Samer El-Haj-Mahmoud ; G Edhaya > Chandran ; Barton Gao > ; Michael D Kinney > Subject: Re: [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event > with TPL_HIGH_LEVEL > > On 11.06.21 10:35, Sunny Wang wrote: > > The commits a9d1fb58 and ae7e5477b555 caused SCT BS.CreateEvent > failures. > > > > Section 7.1 of the UEFI Spec states that TPL_HIGH_LEVEL is designed fo= r > > exclusive use by the firmware. The creation of events by UEFI > > applications, UEFI drivers, and UEFI OS Loaders should not use this TP= L > > level. > > > > Therefore, revert TPL_HIGH_LEVEL change in commits a9d1fb58 and > > ae7e5477b555 to not create event with TPL_HIGH_LEVEL to be compliant > > with UEFI Spec and fix the failures. > > > > For more information, https://edk2.groups.io/g/devel/message/76338 > > > > Cc: Samer El-Haj-Mahmoud > > Cc: G Edhaya Chandran > > Cc: Barton Gao > > Cc: Heinrich Schuchardt > > Cc: Michael D Kinney > > Signed-off-by: Sunny Wang > > Acked-by: Heinrich Schuchardt > > > --- > > .../EventTimerTaskPriorityServicesBBTestCreateEvent.c | 5 +---= - > > .../EventTimerTaskPriorityServicesBBTestCreateEventEx.c | 4 +--- > > 2 files changed, 2 insertions(+), 7 deletions(-) > > > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c > > index a7e7366e..d5c033f7 100644 > > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c > > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEvent.c > > @@ -2,6 +2,7 @@ > > > > Copyright 2006 - 2012 Unified EFI, Inc.
> > Copyright (c) 2010 - 2012, Intel Corporation. All rights reserved.<= BR> > > + Copyright (c) 2021, ARM Limited. All rights reserved. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of t= he > BSD License > > @@ -190,7 +191,6 @@ BBTestCreateEvent_Conf_Sub1 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_TEST_ASSERTION AssertionType; > > @@ -342,7 +342,6 @@ BBTestCreateEvent_Conf_Sub3 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_TEST_ASSERTION AssertionType; > > @@ -407,7 +406,6 @@ BBTestCreateEvent_Conf_Sub4 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_TEST_ASSERTION AssertionType; > > @@ -482,7 +480,6 @@ BBTestCreateEvent_Func_Sub1 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_TEST_ASSERTION AssertionType; > > diff --git a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c > > index eb458de5..03b7ae6e 100644 > > --- a/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c > > +++ b/uefi- > sct/SctPkg/TestCase/UEFI/EFI/BootServices/EventTimerTaskPriorityServices= / > BlackBoxTest/EventTimerTaskPriorityServicesBBTestCreateEventEx.c > > @@ -2,6 +2,7 @@ > > > > Copyright 2006 - 2016 Unified EFI, Inc.
> > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<= BR> > > + Copyright (c) 2021, ARM Limited. All rights reserved. > > > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of t= he > BSD License > > @@ -228,7 +229,6 @@ BBTestCreateEventEx_Conf_Sub1 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_GUID *EventGroups[] =3D { > > @@ -318,7 +318,6 @@ BBTestCreateEventEx_Conf_Sub2 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_GUID *EventGroups[] =3D { > > @@ -413,7 +412,6 @@ BBTestCreateEventEx_Conf_Sub3 ( > > EFI_TPL NotifyTpls[] =3D { > > TPL_CALLBACK, > > TPL_NOTIFY, > > - TPL_HIGH_LEVEL, > > 0 > > }; > > EFI_GUID *EventGroups[] =3D { > > IMPORTANT NOTICE: The contents of this email and any attachments are confi= dential and may also be privileged. If you are not the intended recipient, = please notify the sender immediately and do not disclose the contents to an= y other person, use it for any purpose, or store or copy the information in= any medium. Thank you.