public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* RFC: Adding an alias to format patches with --stat= and --stat-graph-width=
@ 2023-04-05 20:54 Rebecca Cran
  2023-04-06  0:45 ` 回复: [edk2-devel] " gaoliming
  0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2023-04-05 20:54 UTC (permalink / raw)
  To: devel@edk2.groups.io

I've noticed several patches recently which has ellipses at the start of 
the diffstat filenames.

When I started contributing to edk2 I remember being asked to always use 
--stat=1000 --stat-graph-width=20 to avoid that problem: it's mentioned 
in 
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers.

I was wondering if we might want to introduce an alias via SetupGit.py 
to add those parameters automatically?

For example:

diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
index 91814199bf..901d2025ab 100644
--- a/BaseTools/Scripts/SetupGit.py
+++ b/BaseTools/Scripts/SetupGit.py
@@ -82,6 +82,7 @@ OPTIONS = [
      {'section': 'sendemail',   'option': 'chainreplyto', 'value': False},
      {'section': 'sendemail',   'option': 'thread', 'value': True},
      {'section': 'sendemail',   'option': 'transferEncoding', 'value': 
'8bit'},
+    {'section': 'alias',       'option': 'fp', 'value': 'format-patch 
-M --stat=1000 --stat-graph-width=20'},^M
      ]


-- 
Rebecca Cran


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* 回复: [edk2-devel] RFC: Adding an alias to format patches with --stat= and --stat-graph-width=
  2023-04-05 20:54 RFC: Adding an alias to format patches with --stat= and --stat-graph-width= Rebecca Cran
@ 2023-04-06  0:45 ` gaoliming
  0 siblings, 0 replies; 2+ messages in thread
From: gaoliming @ 2023-04-06  0:45 UTC (permalink / raw)
  To: devel, rebecca

Rebecca:
 I think this is a good solution to setup Edk2 development environment. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2023年4月6日 4:54
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] RFC: Adding an alias to format patches with --stat= and
> --stat-graph-width=
> 
> I've noticed several patches recently which has ellipses at the start of
> the diffstat filenames.
> 
> When I started contributing to edk2 I remember being asked to always use
> --stat=1000 --stat-graph-width=20 to avoid that problem: it's mentioned
> in
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-
> git-guide-for-edk2-contributors-and-maintainers.
> 
> I was wondering if we might want to introduce an alias via SetupGit.py
> to add those parameters automatically?
> 
> For example:
> 
> diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
> index 91814199bf..901d2025ab 100644
> --- a/BaseTools/Scripts/SetupGit.py
> +++ b/BaseTools/Scripts/SetupGit.py
> @@ -82,6 +82,7 @@ OPTIONS = [
>       {'section': 'sendemail',   'option': 'chainreplyto', 'value': False},
>       {'section': 'sendemail',   'option': 'thread', 'value': True},
>       {'section': 'sendemail',   'option': 'transferEncoding', 'value':
> '8bit'},
> +    {'section': 'alias',       'option': 'fp', 'value': 'format-patch
> -M --stat=1000 --stat-graph-width=20'},^M
>       ]
> 
> 
> --
> Rebecca Cran
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-06  0:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-05 20:54 RFC: Adding an alias to format patches with --stat= and --stat-graph-width= Rebecca Cran
2023-04-06  0:45 ` 回复: [edk2-devel] " gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox