From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.40935.1640310157973593382 for ; Thu, 23 Dec 2021 17:42:39 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 24 Dec 2021 09:41:56 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Ross Burton'" , "'Kinney, Michael D'" , "'Pedro Falcato'" Cc: , "'Feng, Bob C'" , "'Chen, Christine'" References: <20211220165547.845523-1-ross.burton@arm.com> <001201d7f796$c45663b0$4d032b10$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBCYXNlVG9vbHMvQnJvdGxpOiB1cGRhdGUgdG8gbGF0ZXN0IGJyb3RsaSBzdWJtb2R1bGU=?= Date: Fri, 24 Dec 2021 09:42:05 +0800 Message-ID: <00e701d7f867$7524e0b0$5f6ea210$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJtt0V7RqA86FE0wtwlyFRtOu/l9gF7fb4bAb+lTosBeYHfMgInQgxdAhz5GEuqzZim0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Ross: I know the reason. Your patch is to update brotli version to the latest o= ne e83c7b8e8fb8b696a1df6866bc46cbb76d7e0348, but previos Pedro's patch upda= tes brotli version to one early version 4ec67035c0d97c270c1c73038cc66fc5fcd= fc120. So, your PR can pass, but my PR fail.=20 Pedro: Can you update your patch to reference the latest brotli version e83c7b8e= 8fb8b696a1df6866bc46cbb76d7e0348? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Ross Burton > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B412=E6=9C=8824=E6=97=A5= 6:53 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Gao, Liming ; > Pedro Falcato ; Feng, Bob C > ; Chen, Christine > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to = latest brotli > submodule >=20 > My original PR has passed CI: https://github.com/tianocore/edk2/pull/2231 >=20 > Ross >=20 > On Thu, 23 Dec 2021 at 22:35, Kinney, Michael D > wrote: > > > > Hi Ross, > > > > This PR is showing CI failures with VS2019 > > > > > https://dev.azure.com/tianocore/11ea4a10-ac9f-4e5f-8b13-7def1f19d478/_ > apis/build/builds/36559/logs/178 > > > > 2021-12-23T00:53:44.7544282Z PROGRESS - Running Build DEBUG > > 2021-12-23T00:54:36.3840067Z ERROR - Compiler #2059 from C:\Program > Files (x86)\Microsoft Visual > Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_stri > ng.h(67): syntax error: '(' > > 2021-12-23T00:54:36.3841683Z ERROR - Compiler #2146 from C:\Program > Files (x86)\Microsoft Visual > Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_stri > ng.h(67): syntax error: missing ')' before identifier 'UINTN' > > 2021-12-23T00:54:36.3845453Z WARNING - Compiler #4029 from > C:\Program Files (x86)\Microsoft Visual > Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_stri > ng.h(67): declared formal parameter list different from definition > > 2021-12-23T00:54:36.3847199Z ERROR - Compiler #2059 from C:\Program > Files (x86)\Microsoft Visual > Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_stri > ng.h(67): syntax error: ')' > > 2021-12-23T00:54:36.3851318Z ERROR - Compiler #2059 from C:\Program > Files (x86)\Microsoft Visual > Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\vcruntime_stri > ng.h(67): syntax error: '' > > 2021-12-23T00:54:36.3853972Z WARNING - Compiler #4205 from > C:\Program Files (x86)\Windows > Kits\10\include\10.0.22000.0\ucrt\corecrt_memcpy_s.h(45): nonstandard > extension used: static function declaration in function scope > > 2021-12-23T00:54:36.3858517Z WARNING - Compiler #4020 from > C:\Program Files (x86)\Windows > Kits\10\include\10.0.22000.0\ucrt\corecrt_memcpy_s.h(54): 'SetMem': > too many actual parameters > > 2021-12-23T00:54:36.3861595Z WARNING - Compiler #4020 from > d:\a\1\s\MdeModulePkg\Library\BrotliCustomDecompressLib\brotli\c\comm > on\shared_dictionary.c(103): 'SetMem': too many actual parameters > > 2021-12-23T00:54:36.3864836Z WARNING - Compiler #4020 from > d:\a\1\s\MdeModulePkg\Library\BrotliCustomDecompressLib\brotli\c\comm > on\shared_dictionary.c(496): 'SetMem': too many actual parameters > > 2021-12-23T00:54:36.3867350Z ERROR - Compiler #1077 from NMAKE : > fatal '"C:\Program Files (x86)\Microsoft Visual > Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\Hostx86\x86\cl.ex > e"' : return code '0x2' > > 2021-12-23T00:54:36.3870885Z ERROR - Compiler #7000 from : Failed > to execute command > > 2021-12-23T00:54:36.3873160Z ERROR - EDK2 #002 from : Failed to > build module > > 2021-12-23T00:54:36.3878035Z CRITICAL - Build failed > > > > Can you please resolve and update the PR. > > > > Thanks, > > > > Mike > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Ross > Burton > > > Sent: Thursday, December 23, 2021 2:02 AM > > > To: Gao, Liming > > > Cc: Pedro Falcato ; edk2-devel-groups-io > ; Feng, Bob C ; > > > Chen, Christine > > > Subject: Re: [edk2-devel] [PATCH] BaseTools/Brotli: update to latest = brotli > submodule > > > > > > On Thu, 23 Dec 2021 at 00:48, gaoliming > wrote: > > > > Create PR https://github.com/tianocore/edk2/pull/2346 for this patc= h. > > > > > > There are now *three* PRs on GitHub to solve this issue, which is a > > > build breaker for anyone using a new GCC. > > > > > > Can someone please merge the fix? > > > > > > Ross > > > > > > > > >=20 > > > > >