From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.21834.1683272489418515811 for ; Fri, 05 May 2023 00:41:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=QAZbhT9B; spf=pass (domain: byosoft.com.cn, ip: 114.80.218.36, mailfrom: gaoliming@byosoft.com.cn) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id B1E15A32E1B5 for ; Fri, 5 May 2023 15:41:25 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1683272485; bh=57emHEZ/3ey2pporS2RC5MyWUXPQHMdgsG21PeAlaNo=; h=From:To:References:In-Reply-To:Subject:Date; b=QAZbhT9B0K/8G/PRT8RWrpYGpTcn79nokQYl1hwLUna3Aui46rGT48LvbyS0gitno /+ch2dPJ6SwxEzI2/GqzAlHz4X2WjP1XGlCYE5OKmmomVF0SLoD5KKjc6QGyVQWY0s X+Hi+/3vpCF5is3A9kS+o5E7K95KnBz3Yck+OcOg= Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 77382A32E19D for ; Fri, 5 May 2023 15:41:25 +0800 (CST) Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id EC3C8A32E15F for ; Fri, 5 May 2023 15:41:24 +0800 (CST) Authentication-Results: zrleap.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 47697A32E07F for ; Fri, 5 May 2023 15:41:22 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 05 May 2023 15:41:11 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Yao, Jiewen'" , "'Wang, Jian J'" , "'Lu, Xiaoyu1'" , "'Jiang, Guomin'" , "'Andrew Fish'" , "'Ni, Ray'" , "'Chiu, Chasel'" , "'Desimone, Nathaniel L'" , "'Zeng, Star'" References: <20230501160839.884391-1-rebecca@bsdio.com> <20230501160839.884391-9-rebecca@bsdio.com> <8387e266-9e03-38ea-340b-2db994971bd0@bsdio.com> <86788472-2e1d-fa5d-30f1-9b2a7f139339@bsdio.com> <001d01d97ef5$4d941d20$e8bc5760$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY2IDA4LzE2XSBBZGQgR0NDIGFuZCBHQ0NOT0xUTyB0b29sY2hhaW5zIHRvIHRvb2xzX2RlZi50eHQgYW5kIHVwZGF0ZSBwYWNrYWdlcw==?= Date: Fri, 5 May 2023 15:41:15 +0800 Message-ID: <00e801d97f24$f9033ef0$eb09bcd0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIXLEmiPkG6ZGWE/GLcqPrO3oCNDQKLdMe2AS29+DQCiqVgXQEZgVHJAQ+x5gIBZl62kwEHffQHrnkYGdA= Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Jiewen: As Rebecca describes, IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc GCC49 tool = chain adds -flto option to enable link-time optimization.=20 So, new GCCNOLTO also copies this option. QemuFspPkg.dsc is in IntelFsp2P= kg. Fsp2Pkg maintainer may give the answer why adds -flto option for GCC49. Rebecca: This patch makes the changes cross the different packages. So, it may bri= ng the confuse to the different package maintainers. Can these changes be s= eparated for the different packages? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Rebecca Cran > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=885=E6=97=A5 1= 0:12 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Yao, Jiewen ; Gao, Lim= ing > ; devel@edk2.groups.io; Wang, Jian J > ; Lu, Xiaoyu1 ; Jiang, Guomi= n > ; 'Andrew Fish' ; Ni, Ray > ; Chiu, Chasel ; Desimone, > Nathaniel L ; Zeng, Star > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v6 08/16] Add GCC and GCCNOLT= O toolchains > to tools_def.txt and update packages >=20 > If you look at the entire block, GCC49 also has -flto, so since GCCNOLTO > is a copy of GCC49, that's why it has -flto: >=20 >=20 > # Append build options for EDK and EDKII drivers (=3D is Append, =3D=3D i= s > Replace) > # Enable link-time optimization when building with GCC49 or GCCNOLTO > *_GCC49_IA32_CC_FLAGS =3D -flto > *_GCC49_IA32_DLINK_FLAGS =3D -flto > *_GCCNOLTO_IA32_CC_FLAGS =3D -flto > *_GCCNOLTO_IA32_DLINK_FLAGS =3D -flto > *_GCC5_IA32_CC_FLAGS =3D -fno-pic > *_GCC5_IA32_DLINK_FLAGS =3D -no-pie > *_GCC5_IA32_ASLCC_FLAGS =3D -fno-pic > *_GCC5_IA32_ASLDLINK_FLAGS =3D -no-pie > *_GCC_IA32_CC_FLAGS =3D -fno-pic > *_GCC_IA32_DLINK_FLAGS =3D -no-pie > *_GCC_IA32_ASLCC_FLAGS =3D -fno-pic > *_GCC_IA32_ASLDLINK_FLAGS =3D -no-pie >=20 > Hopefully we can remove the flag in future, but since it's in > IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc and not a main .dsc file I'm not > sure it's very important. >=20 >=20 > -- >=20 > Rebecca Cran >=20 >=20 > On 5/4/23 20:02, Yao, Jiewen wrote: > > Thanks Liming. > > > > I am not sure below change is expected or not. Please feedback if possi= ble. > Thank you! > > > >> Why we add "-flto" for "NOLTO" ? > >>>> + *_GCCNOLTO_IA32_CC_FLAGS =3D -flto > >>>> + *_GCCNOLTO_IA32_DLINK_FLAGS =3D -flto > > > >> -----Original Message----- > >> From: gaoliming > >> Sent: Friday, May 5, 2023 10:00 AM > >> To: devel@edk2.groups.io; rebecca@bsdio.com; Yao, Jiewen > >> ; Wang, Jian J ; Lu, > Xiaoyu1 > >> ; Jiang, Guomin ; > 'Andrew > >> Fish' ; Ni, Ray ; Chiu, Chasel > >> ; Desimone, Nathaniel L > >> ; Zeng, Star > >> Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v6 08/16] Add GCC and= GCCNOLTO > >> toolchains to tools_def.txt and update packages > >> > >> Rebecca: > >> I understand this change is to add GCC and GCCNOLTO toolchain. GCC > is > >> same to GCC5, GCCNOLTO is same to GCC49. So, new tool chain copies the > >> same changes from origin one. Right? > >> > >> Thanks > >> Liming > >>> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >>> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Rebecca > >> Cran > >>> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B45=E6=9C=882=E6=97= =A5 22:23 > >>> =E6=94=B6=E4=BB=B6=E4=BA=BA: Yao, Jiewen ; deve= l@edk2.groups.io; > >> Wang, > >>> Jian J ; Lu, Xiaoyu1 ; > Jiang, > >>> Guomin ; Andrew Fish ; Ni, > >> Ray > >>> ; Chiu, Chasel ; Desimone, > >>> Nathaniel L ; Zeng, Star > >>> > >>> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v6 08/16] Add GCC and GCC= NOLTO > >> toolchains > >>> to tools_def.txt and update packages > >>> > >>> On 5/2/23 00:35, Yao, Jiewen wrote: > >>>> Have you evaluated size impact with this new compiler option? > Especially > >>> crypto library. > >>>> Bigger? Smaller? > >>> The increase in size when we disable LTO doesn't seem too bad: > >>> > >>> With LTO: > >>> > >>> -rwxrwxr-x 1 bcran bcran 13M May 2 08:11 > >>> CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.debug > >>> -rwxrwxr-x 1 bcran bcran 13M May 2 08:11 > >>> CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.debug > >>> -rwxrwxr-x 1 bcran bcran 11M May 2 08:11 > >>> CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.debug > >>> -rwxrwxr-x 1 bcran bcran 11M May 2 08:11 > >>> CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.debug > >>> -rwxrwxr-x 1 bcran bcran 8.5M May 2 08:11 > >>> CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.debug > >>> -rwxrwxr-x 1 bcran bcran 8.3M May 2 08:11 > >>> CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.debug > >>> -rwxrwxr-x 1 bcran bcran 8.0M May 2 08:11 > >>> CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.debug > >>> -rwxrwxr-x 1 bcran bcran 7.8M May 2 08:11 > >>> CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.debug > >>> -rwxrwxr-x 1 bcran bcran 7.0M May 2 08:11 > >>> BaseCryptLibUnitTestShell.debug > >>> -rwxrwxr-x 1 bcran bcran 7.0M May 2 08:11 > >>> CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.debug > >>> -rwxrwxr-x 1 bcran bcran 6.9M May 2 08:11 > >>> CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.debug > >>> -rwxrwxr-x 1 bcran bcran 6.7M May 2 08:11 > >>> CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.debug > >>> -rwxrwxr-x 1 bcran bcran 6.7M May 2 08:11 > >>> CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.debug > >>> -rwxrwxr-x 1 bcran bcran 6.5M May 2 08:11 > >>> CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.debug > >>> -rwxrwxr-x 1 bcran bcran 6.2M May 2 08:11 > >>> CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.debug > >>> -rwxrwxr-x 1 bcran bcran 6.2M May 2 08:11 > >>> CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.debug > >>> -rw-rw-r-- 1 bcran bcran 1005K May 2 08:11 > >>> CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.efi > >>> -rw-rw-r-- 1 bcran bcran 903K May 2 08:11 > >>> CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.efi > >>> -rw-rw-r-- 1 bcran bcran 811K May 2 08:11 > >>> CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.efi > >>> -rw-rw-r-- 1 bcran bcran 755K May 2 08:11 > >>> CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.efi > >>> -rw-rw-r-- 1 bcran bcran 724K May 2 08:11 > >>> CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.efi > >>> -rw-rw-r-- 1 bcran bcran 710K May 2 08:11 > >>> CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.efi > >>> -rw-rw-r-- 1 bcran bcran 654K May 2 08:11 > >>> CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.efi > >>> -rw-rw-r-- 1 bcran bcran 623K May 2 08:11 > >>> CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.efi > >>> -rw-rw-r-- 1 bcran bcran 585K May 2 08:11 > >>> CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.efi > >>> -rw-rw-r-- 1 bcran bcran 560K May 2 08:11 > BaseCryptLibUnitTestShell.efi > >>> -rw-rw-r-- 1 bcran bcran 555K May 2 08:11 > >>> CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.efi > >>> -rw-rw-r-- 1 bcran bcran 500K May 2 08:11 > >>> CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.efi > >>> -rw-rw-r-- 1 bcran bcran 485K May 2 08:11 > >>> CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.efi > >>> -rw-rw-r-- 1 bcran bcran 485K May 2 08:11 > >>> CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.efi > >>> -rw-rw-r-- 1 bcran bcran 454K May 2 08:11 > >>> CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.efi > >>> -rw-rw-r-- 1 bcran bcran 454K May 2 08:11 > >>> CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.efi > >>> > >>> Without LTO: > >>> -rwxrwxr-x 1 bcran bcran 14M May 2 08:13 > >>> CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.debug > >>> -rwxrwxr-x 1 bcran bcran 14M May 2 08:13 > >>> CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.debug > >>> -rwxrwxr-x 1 bcran bcran 12M May 2 08:13 > >>> CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.debug > >>> -rwxrwxr-x 1 bcran bcran 12M May 2 08:13 > >>> CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.debug > >>> -rwxrwxr-x 1 bcran bcran 9.5M May 2 08:13 > >>> CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.debug > >>> -rwxrwxr-x 1 bcran bcran 9.2M May 2 08:13 > >>> CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.debug > >>> -rwxrwxr-x 1 bcran bcran 8.9M May 2 08:13 > >>> CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.debug > >>> -rwxrwxr-x 1 bcran bcran 8.7M May 2 08:13 > >>> CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.debug > >>> -rwxrwxr-x 1 bcran bcran 8.0M May 2 08:13 > >>> CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.debug > >>> -rwxrwxr-x 1 bcran bcran 7.9M May 2 08:13 > >>> BaseCryptLibUnitTestShell.debug > >>> -rwxrwxr-x 1 bcran bcran 7.9M May 2 08:12 > >>> CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.debug > >>> -rwxrwxr-x 1 bcran bcran 7.7M May 2 08:12 > >>> CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.debug > >>> -rwxrwxr-x 1 bcran bcran 7.7M May 2 08:13 > >>> CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.debug > >>> -rwxrwxr-x 1 bcran bcran 7.4M May 2 08:13 > >>> CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.debug > >>> -rwxrwxr-x 1 bcran bcran 7.2M May 2 08:12 > >>> CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.debug > >>> -rwxrwxr-x 1 bcran bcran 7.2M May 2 08:13 > >>> CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.debug > >>> -rw-rw-r-- 1 bcran bcran 1.1M May 2 08:13 > >>> CryptoDxe_41A491D1-A972-468B-A299-DABF415A43B7.efi > >>> -rw-rw-r-- 1 bcran bcran 1011K May 2 08:13 > >>> CryptoDxe_AA83B296-F6EA-447F-B013-E80E98629CF8.efi > >>> -rw-rw-r-- 1 bcran bcran 914K May 2 08:13 > >>> CryptoDxe_9FBDAD27-910C-4229-9EFF-A93BB5FE18C6.efi > >>> -rw-rw-r-- 1 bcran bcran 823K May 2 08:13 > >>> CryptoSmm_C1760694-AB3A-4532-8C6D-52D8F86EB1AA.efi > >>> -rw-rw-r-- 1 bcran bcran 813K May 2 08:13 > >>> CryptoDxe_ADD6D05A-52A2-437B-98E7-DBFDA89352CD.efi > >>> -rw-rw-r-- 1 bcran bcran 789K May 2 08:13 > >>> CryptoPei_A10827AD-7598-4955-B661-52EE2B62B057.efi > >>> -rw-rw-r-- 1 bcran bcran 722K May 2 08:13 > >>> CryptoSmm_1930CE7E-6598-48ED-8AB1-EBE7E85EC254.efi > >>> -rw-rw-r-- 1 bcran bcran 687K May 2 08:13 > >>> CryptoPei_D51FCE59-6860-49C0-9B35-984470735D17.efi > >>> -rw-rw-r-- 1 bcran bcran 644K May 2 08:13 > >>> CryptoSmm_828959D3-CEA6-4B79-B1FC-5AFA0D7F2144.efi > >>> -rw-rw-r-- 1 bcran bcran 632K May 2 08:13 > BaseCryptLibUnitTestShell.efi > >>> -rw-rw-r-- 1 bcran bcran 610K May 2 08:13 > >>> CryptoPei_DCC9CB49-7BE2-47C6-864E-6DCC932360F9.efi > >>> -rw-rw-r-- 1 bcran bcran 567K May 2 08:12 > >>> CryptoDxe_31C17C54-325D-47D5-8622-888098F10E44.efi > >>> -rw-rw-r-- 1 bcran bcran 543K May 2 08:12 > >>> CryptoSmm_1A1C9E13-5722-4636-AB73-31328EDE8BAF.efi > >>> -rw-rw-r-- 1 bcran bcran 543K May 2 08:13 > >>> CryptoSmm_E4D7D1E3-E886-4412-A442-EFD6F2502DD3.efi > >>> -rw-rw-r-- 1 bcran bcran 508K May 2 08:12 > >>> CryptoPei_C693A250-6B36-49B9-B7F3-7283F8136A72.efi > >>> -rw-rw-r-- 1 bcran bcran 508K May 2 08:13 > >>> CryptoPei_EBD49F5C-6D8B-40D1-A56D-9AFA485A8661.efi > >>> > >>>> Why we add "-flto" for "NOLTO" ? > >>>>>> + *_GCCNOLTO_IA32_CC_FLAGS =3D -flto > >>>>>> + *_GCCNOLTO_IA32_DLINK_FLAGS =3D -flto > >>> I don't know why -flto was added for the GCC49 flags, but when I crea= ted > >>> the GCCNOLTO flags I copied it because I presume there's a reason thi= s > >>> specific test package requires it. > >>> > >>> > >>> -- > >>> > >>> Rebecca Cran > >>> > >>> > >>> > >>> > >>> > >> >=20 >=20 >=20 >=20