From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 65722941A48 for ; Wed, 6 Mar 2024 14:08:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YX0sjOIr1D9dvUtgeTpIJdAPyrkL6y9sLvF8udxMH3Y=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1709734083; v=1; b=vJ00CKDKhfqg8JZwX4zBOeu1gpUof3GE7tZp2t/vwbpakGv/nhHWtVmO1C+0fo35VLY6YNK8 5/ttSKnhAsnhOJX+9WuXwx/TqzQQ3XRRR1wfrOC6pGDpKW+kPUzCirMbmLUIzj3e9EnsO3mBMgU zjyh3JzN+SJmJ4OUIZvEP8YUrfrNr3N0eD+af/06h+f3BNictg0/uUjR8tJohylJ8d21qWprhFv dathk+dk3i/n5IhscokSFdrDx7eJwJtAeg0PcZGq0cGrFIx8Q8kYX96ExCqGv5MTPp9KOdBh4L5 WG75tMGrY/B/SdxsGFXvnoNfn4MdkdKvljPVFFD/8LAjw== X-Received: by 127.0.0.2 with SMTP id 4vFLYY7687511xyqmNYjVHVf; Wed, 06 Mar 2024 06:08:03 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.12482.1709734082391969053 for ; Wed, 06 Mar 2024 06:08:02 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id A0358A32E043 for ; Wed, 6 Mar 2024 22:07:58 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 8DCB1A32E017 for ; Wed, 6 Mar 2024 22:07:58 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id B50E3A32E047 for ; Wed, 6 Mar 2024 22:07:55 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.93.194.54]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Wed, 06 Mar 2024 22:07:53 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.93.194.54 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Pethaiyan Madhan'" , Cc: "'Michael D Kinney'" , "'Zhiguang Liu'" , "'Yi Li'" , "'GuoX Xu'" References: In-Reply-To: Subject: =?UTF-8?B?W2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIXSBTaWduZWRDYXBzdWxlUGtnOiBVcGRhdGUgR2V0SW1hZ2UgYW5kIEdldEltYWdlSW5mbyBkZXNjcmlwdGlvbiBkZXRhaWxz?= Date: Wed, 06 Mar 2024 06:08:02 -0800 Message-ID: <00e801da6fcf$afafd320$0f0f7960$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQFvqK1VOlDs/xkTrvFm/CIm3apDYLIATgKQ Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: f1ztAybM1BE02od8IL2bUoZBx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vJ00CKDK; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Pethaiyan Madhan > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA2=D4=C227=C8=D5 18:04 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Pethaiyan Madhan ; Michael D Ki= nney > ; Liming Gao ; > Zhiguang Liu ; Yi Li ; GuoX Xu > > =D6=F7=CC=E2: [PATCH] SignedCapsulePkg: Update GetImage and GetImageInfo > description details >=20 > 1.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage(): > Add the following sentence at the end of the Image parameter > description. "May be NULL with a zero ImageSize in order to determine > the size of the buffer needed". >=20 > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > ImageSize is not too small and Image is NULL." >=20 > 2.For EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImageInfo(): > Add the following sentence at the end of the ImageInfo parameter > description."May be NULL with a zero ImageInfoSize in order to > determine the size of the buffer needed". >=20 > Modify the description of "EFI_INVALID_PARAMETER" return code as "The > ImageInfoSize is not too small and Image is NULL." and add new > descriptions for "EFI_INVALID_PARAMETER" return code. >=20 > REF: UEFI spec v2.10 23.1.2 >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Yi Li > Cc: GuoX Xu > Signed-off-by: Pethaiyan Madhan > --- > .../SystemFirmwareUpdate/SystemFirmwareCommonDxe.c | 13 > +++++++++++-- > .../SystemFirmwareUpdate/SystemFirmwareDxe.h | 13 > +++++++++++-- > 2 files changed, 22 insertions(+), 4 deletions(-) >=20 > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCo > mmonDxe.c > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCo > mmonDxe.c > index 077bd0cb31..6e394d85d4 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCo > mmonDxe.c > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareCo > mmonDxe.c > @@ -34,6 +34,8 @@ EFI_FIRMWARE_MANAGEMENT_PROTOCOL > mFirmwareManagementProtocol =3D { > to contain the image(s) > information if the buffer was too small. > @param[in, out] ImageInfo A pointer to the buffer in which > firmware places the current image(s) > information. The information > is an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs. > + May be NULL with a zero > ImageInfoSize in order to determine the size of the > + buffer needed. > @param[out] DescriptorVersion A pointer to the location in which > firmware returns the version number > associated with the > EFI_FIRMWARE_IMAGE_DESCRIPTOR. > @param[out] DescriptorCount A pointer to the location in > which firmware returns the number of > @@ -54,7 +56,12 @@ EFI_FIRMWARE_MANAGEMENT_PROTOCOL > mFirmwareManagementProtocol =3D { > @retval EFI_SUCCESS The device was successfully > updated with the new image. > @retval EFI_BUFFER_TOO_SMALL The ImageInfo buffer was too > small. The current buffer size > needed to hold the image(s) > information is returned in ImageInfoSize. > - @retval EFI_INVALID_PARAMETER ImageInfoSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is not too small > and ImageInfo is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorCount is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersionName is NULL. > @retval EFI_DEVICE_ERROR Valid information could not be > returned. Possible corrupted image. >=20 > **/ > @@ -153,6 +160,8 @@ FmpGetImageInfo ( > @param[in] ImageIndex A unique number identifying the > firmware image(s) within the device. > The number is between 1 and > DescriptorCount. > @param[in,out] Image Points to the buffer where the > current image is copied to. > + May be NULL with a zero > ImageSize in order to determine the size of the > + buffer needed. > @param[in,out] ImageSize On entry, points to the size of the > buffer pointed to by Image, in bytes. > On return, points to the length of > the image, in bytes. >=20 > @@ -160,7 +169,7 @@ FmpGetImageInfo ( > @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize is > too small to hold the > image. The current buffer size > needed to hold the image is returned > in ImageSize. > - @retval EFI_INVALID_PARAMETER The Image was NULL. > + @retval EFI_INVALID_PARAMETER The ImageSize is not too small and > Image is NULL > @retval EFI_NOT_FOUND The current image is not copied to > the buffer. > @retval EFI_UNSUPPORTED The operation is not supported. > @retval EFI_SECURITY_VIOLATION The operation could not be performed > due to an authentication failure. > diff --git > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe > .h > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe > .h > index c8443865cb..b2b2c78318 100644 > --- > a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe > .h > +++ > b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareDxe > .h > @@ -137,6 +137,8 @@ typedef struct { > to contain the image(s) > information if the buffer was too small. > @param[in, out] ImageInfo A pointer to the buffer in which > firmware places the current image(s) > information. The information > is an array of EFI_FIRMWARE_IMAGE_DESCRIPTORs. > + May be NULL with a zero > ImageInfoSize in order to determine the size of the > + buffer needed. > @param[out] DescriptorVersion A pointer to the location in which > firmware returns the version number > associated with the > EFI_FIRMWARE_IMAGE_DESCRIPTOR. > @param[out] DescriptorCount A pointer to the location in > which firmware returns the number of > @@ -157,7 +159,12 @@ typedef struct { > @retval EFI_SUCCESS The device was successfully > updated with the new image. > @retval EFI_BUFFER_TOO_SMALL The ImageInfo buffer was too > small. The current buffer size > needed to hold the image(s) > information is returned in ImageInfoSize. > - @retval EFI_INVALID_PARAMETER ImageInfoSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is not too small > and ImageInfo is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorCount is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > DescriptorSize is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersion is NULL. > + @retval EFI_INVALID_PARAMETER ImageInfoSize is non-zero and > PackageVersionName is NULL. > @retval EFI_DEVICE_ERROR Valid information could not be > returned. Possible corrupted image. >=20 > **/ > @@ -184,6 +191,8 @@ FmpGetImageInfo ( > @param[in] ImageIndex A unique number identifying the > firmware image(s) within the device. > The number is between 1 and > DescriptorCount. > @param[in,out] Image Points to the buffer where the > current image is copied to. > + May be NULL with a zero > ImageSize in order to determine the size of the > + buffer needed. > @param[in,out] ImageSize On entry, points to the size of the > buffer pointed to by Image, in bytes. > On return, points to the length of > the image, in bytes. >=20 > @@ -191,7 +200,7 @@ FmpGetImageInfo ( > @retval EFI_BUFFER_TOO_SMALL The buffer specified by ImageSize is > too small to hold the > image. The current buffer size > needed to hold the image is returned > in ImageSize. > - @retval EFI_INVALID_PARAMETER The Image was NULL. > + @retval EFI_INVALID_PARAMETER The ImageSize is not too small and > Image is NULL > @retval EFI_NOT_FOUND The current image is not copied to > the buffer. > @retval EFI_UNSUPPORTED The operation is not supported. > @retval EFI_SECURITY_VIOLATION The operation could not be performed > due to an authentication failure. > -- > 2.38.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116439): https://edk2.groups.io/g/devel/message/116439 Mute This Topic: https://groups.io/mt/104765999/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-