public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <ardb@kernel.org>, <kraxel@redhat.com>
Cc: "'Rebecca Cran'" <rebecca@bsdio.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang
Date: Mon, 15 May 2023 08:55:09 +0800	[thread overview]
Message-ID: <00ee01d986c7$e61f38c0$b25daa40$@byosoft.com.cn> (raw)
In-Reply-To: <CAMj1kXH+JZ+BmDkm-XKvyuE42VGu4twRUKXJUrRtuaTkci=n9g@mail.gmail.com>

Ard:
  I am OK. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> Biesheuvel
> 发送时间: 2023年5月12日 14:40
> 收件人: devel@edk2.groups.io; kraxel@redhat.com
> 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable overzealous
> unused variable warning on Clang
> 
> Liming:
> 
> I'd like to merge this one for the stable tag - any objections?
> 
> 
> On Thu, 11 May 2023 at 06:55, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > On Wed, May 10, 2023 at 04:50:08PM +0200, Ard Biesheuvel wrote:
> > > The warnings Clang emits when enabling
> -Wunneeded-internal-declaration
> > > (which is part of -Wall) are generating false positives for variables
> > > whose size gets taken but are not referenced beyond that.
> > >
> > > This may happen legitimately in debug code, so let's disable this
> > > warning for Clang, rather than tiptoe around it in the code base.
> > >
> > > This fixes the RELEASE build for OVMF, which triggers this issue in the
> > > newly added VirtioSerialDxe driver.
> > >
> > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 




      reply	other threads:[~2023-05-15  0:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 14:50 [PATCH] BaseTools/tools_def: Disable overzealous unused variable warning on Clang Ard Biesheuvel
2023-05-10 14:54 ` Rebecca Cran
2023-05-11  4:55 ` Gerd Hoffmann
2023-05-12  6:39   ` [edk2-devel] " Ard Biesheuvel
2023-05-15  0:55     ` gaoliming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00ee01d986c7$e61f38c0$b25daa40$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox