Re: [edk2-devel] [PATCH v4 00/11] SEV-ES guest support fixes and cleanup

["Lendacky, Thomas" <thomas.lendacky@amd.com>]

On 11/10/20 1:28 PM, Laszlo Ersek wrote:
> On 11/06/20 18:53, Lendacky, Thomas wrote:
>> From: Tom Lendacky <thomas.lendacky@amd.com>
>>
>> This patch series provides some fixes, updates and cleanup to the SEV-ES
>> guest support:
>>
>> - Update the calculation of the qword offset of fields within the GHCB
>>   by removing the hardcoding of the offsets and using the OFFSET_OF ()
>>   and sizeof () functions to calculate the values. Remove unused values
>>   and add values that will be used in later patches.
>>
>> - Set the SwExitCode, SwExitInfo1, SwExitInfo2 and SwScratch valid bits
>>   in the GHCB ValidBitmap area when these fields are for a VMGEXIT. This
>>   is done by adding two new interfaces to the VmgExitLib library to set
>>   and test the bits of the GHCB ValidBitmap. This reduces code duplication
>>   and keeps access to the ValidBitmap field within the VmgExitLib library.
>>
>> - Update the Qemu flash drive services support to add SEV-ES support for
>>   erasing blocks.
>>
>> - Disable interrupts when using the GHCB.
>>
>> - Use the processor number for setting the AP stack pointer instead of the
>>   APIC ID by calling GetProcessorNumber().
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3008
> 
> Merged as commit range 8c610e6075f2..d150439b7263, via
> <https://github.com/tianocore/edk2/pull/1110>.
> 

Thanks you, Laszlo, as well as everyone involved in reviewing the patches.

Tom

> Thanks
> Laszlo
> 
>>
>> ---
>>
>> These patches are based on commit:
>> dc0dae2d18d4 ("BaseTools: Fix BaseTools nmake cleanall hang issue")
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>>
>> Changes since v3:
>> - Replace the use of "sizeof (UINT64)" in the GHCB_REGISTER enum with
>>   a macro that uses "sizeof (UINT64)" to avoid ECC errors during CI
>>   (suggested by Laszlo).
>>
>> Changes since v2:
>> - Don't rename the GHCB_REGISTER enum type.
>>
>> Changes since v1:
>> - For the GHCB savearea changes, create a new reserved area name instead
>>   of "renumbering" the reserved areas.
>> - Rework the ValidBitmap set/test support to be part of the VmgExitLib
>>   library. Create two new interfaces for setting and testing bits in the
>>   GHCB ValidBitmap field and adjust all existing code and the new code in
>>   this series to use these interfaces for the ValidBitmap updates/checks.
>> - Don't disable interrupts for just the Qemu flash services support, but
>>   rather, cover all users of the GHCB by disabling interrupts in VmgInit()
>>   and restoring them in VmgDone(). This requires changes to those
>>   interaces.
>>
>> Tom Lendacky (11):
>>   MdePkg: Clean up GHCB field offsets and save area
>>   UefiCpuPkg/VmgExitLib: Add interfaces to set/read GHCB ValidBitmap
>>     bits
>>   OvmfPkg/VmgExitLib: Implement new VmgExitLib interfaces
>>   OvmfPkg/VmgExitLib: Set the SW exit fields when performing VMGEXIT
>>   OvmfPkg/VmgExitLib: Set the SwScratch valid bit for IOIO events
>>   OvmfPkg/VmgExitLib: Set the SwScratch valid bit for MMIO events
>>   UefiCpuPkg/MpInitLib: Set the SW exit fields when performing VMGEXIT
>>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Set the SwScratch valid bit
>>   OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Fix erase blocks for SEV-ES
>>   UefiCpuPkg, OvmfPkg: Disable interrupts when using the GHCB
>>   UefiCpuPkg/MpInitLib: For SEV-ES guest, set stack based on processor
>>     number
>>
>>  MdePkg/Include/Register/Amd/Ghcb.h                    |  43 +++----
>>  UefiCpuPkg/Include/Library/VmgExitLib.h               |  51 +++++++-
>>  OvmfPkg/Library/VmgExitLib/VmgExitLib.c               |  84 ++++++++++++-
>>  OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c         | 129 ++++++--------------
>>  OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlash.c    |   4 +-
>>  OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c |   6 +-
>>  UefiCpuPkg/Library/MpInitLib/DxeMpLib.c               |   5 +-
>>  UefiCpuPkg/Library/MpInitLib/MpLib.c                  |  14 ++-
>>  UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.c    |  60 +++++++--
>>  UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm         |   6 +
>>  10 files changed, 261 insertions(+), 141 deletions(-)
>>
>