From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lucky1.263xmail.com (lucky1.263xmail.com [211.157.147.132]) by mx.groups.io with SMTP id smtpd.web11.2427.1654139121657832081 for ; Wed, 01 Jun 2022 20:05:23 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: byosoft.net, ip: 211.157.147.132, mailfrom: byomail@byosoft.net) Received: from localhost (unknown [192.168.167.13]) by lucky1.263xmail.com (Postfix) with ESMTP id 630FE109D7A for ; Thu, 2 Jun 2022 11:05:16 +0800 (CST) X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from mail.byosoft.com.cn (unknown [58.240.74.242]) by smtp.263.net (postfix) whith ESMTP id P28208T139949040969472S1654139115155001_; Thu, 02 Jun 2022 11:05:15 +0800 (CST) X-IP-DOMAINF: 1 X-RL-SENDER: byomail@byosoft.net X-SENDER: byomail@byosoft.net X-LOGIN-NAME: byomail@byosoft.net X-FST-TO: devel@edk2.groups.io X-RCPT-COUNT: 1 X-LOCAL-RCPT-COUNT: 0 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 58.240.74.242 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: X-System-Flag: 0 Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 02 Jun 2022 11:04:28 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Pedro Falcato'" , "'edk2-devel-groups-io'" Cc: "'Leif Lindholm'" , "'Michael D Kinney'" , "'Zhiguang Liu'" References: <20220407220146.149580-1-pedro.falcato@gmail.com> <16E9330A7A87074F.18109@groups.io> <16EE1DD8FA9A45F3.9448@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIGVkazItcGxhdGZvcm1zIDAvM10gRXh0NFBrZzogQWRkIGV4dDIvMyBzdXBwb3J0IGFuZCBtb3ZlIGNyYzE2LzMyYyB0byBCYXNlTGli?= Date: Thu, 2 Jun 2022 11:04:30 +0800 Message-ID: <00f801d8762d$7a24fd40$6e6ef7c0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI13qJ0wLmD4RK0XAEXqcCpyGJjbwNOhEO8AmyQ5wwBv2n19qxEyX9Q Sender: "gaoliming" Content-Type: multipart/alternative; boundary="----=_NextPart_000_00F9_01D87670.88494EB0" Content-Language: zh-cn ------=_NextPart_000_00F9_01D87670.88494EB0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Pedro=EF=BC=9A Thanks for your enhancement to support ext2/3 file system. Acked-by: Limin= g Gao for this patch set.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Pedro Falcato =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=881=E6=97=A5 5:3= 3 =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io ; P= edro Falcato =E6=8A=84=E9=80=81: Leif Lindholm ; Michael D Kinney ; Liming Gao ; Zhiguang = Liu =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Ad= d ext2/3 support and move crc16/32c to BaseLib =20 Ping. Please review now that the stable freeze is over. =20 On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io > wr= ote: Ping. Could someone review these patches? =20 On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io > wr= ote: Ping. If someone could take a look, it would be much appreciated. =20 On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato > wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3871 Hi all, This patch-set attempts to address two open feature requests for Ext4Pkg by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib = (id 3871). The previous patch-set regarding 3871 attempted to merge the different crc1= 6 implementations but failed because, contrary to what I thought, there are many, many differ= ent CRC16s which are all slightly different. This one (plus the separate edk2 patch) attempt= s to just merge CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. Since this patch set grew to be considerably different from the original, I= didn't mark it as v2 but rather a separate, new patch-set. CC'ing the edk2-platforms stewards (as I cannot review my own code) and the= CC's of the MdePkg patch. Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao = > Cc: Zhiguang Liu > Pedro Falcato (3): Ext4Pkg: Replace the CRC implementations with BaseLib Ext4Pkg: Format using uncrustify Ext4Pkg: Add ext2/3 support Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- 16 files changed, 640 insertions(+), 487 deletions(-) create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c --=20 2.35.1 --=20 Pedro Falcato --=20 Pedro Falcato --=20 Pedro Falcato ------=_NextPart_000_00F9_01D87670.88494EB0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Pedro=EF=BC=9A

=C2=A0Thanks for your enhancement to support ext2= /3 file system. Acked-by: Liming Gao <gaoliming@byosoft.com.cn> for t= his patch set.

 

Thanks

Liming

<= p class=3DMsoNormal>=E5=8F=91=E4=BB=B6=E4=BA=BA:= Pedro Falcato <pedro.falcato@gmail.com>
=E5=8F=91=E9=80= =81=E6=97=B6=E9=97=B4: 2022=E5=B9=B46=E6=9C=881=E6=97=A5 5:33
=E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.group= s.io>; Pedro Falcato <pedro.falcato@gmail.com>
=E6=8A= =84=E9=80=81: Leif Lindhol= m <leif@nuviainc.com>; Michael D Kinney <michael.d.kinney@intel.co= m>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhigua= ng.liu@intel.com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext= 4Pkg: Add ext2/3 support and move crc16/32c to BaseLib

 

Ping. Please revi= ew now that the stable freeze is over.

 

On Wed, May 11, 2022 at 6:42 PM Pedro Fa= lcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> wrote:

Ping. Could someone review th= ese patches?

 

On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> = wrote:

Ping. If someone co= uld take a look, it would be much appreciated.

<= p class=3DMsoNormal> 

On Thu, Apr 7, 2022 at 11:01 PM P= edro Falcato <pedro.falcato@gmail.com> wrote:

BZ: https://bugzilla.tia= nocore.org/show_bug.cgi?id=3D3745
BZ: https://bugzilla.tian= ocore.org/show_bug.cgi?id=3D3871

Hi all,

This patch-set a= ttempts to address two open feature requests for Ext4Pkg
by adding ext2/= 3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib (id 3871).
<= br>The previous patch-set regarding 3871 attempted to merge the different c= rc16 implementations
but failed because, contrary to what I thought, the= re are many, many different CRC16s which
are all slightly different. Thi= s one (plus the separate edk2 patch) attempts to just merge
CRC16-ANSI (= confusingly, also known as CRC16) into BaseLib.

Since this patch set= grew to be considerably different from the original, I didn't mark it
a= s v2 but rather a separate, new patch-set.

CC'ing the edk2-platforms= stewards (as I cannot review my own code) and the CC's of the MdePkg
pa= tch.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@i= ntel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang = Liu <zhiguan= g.liu@intel.com>

Pedro Falcato (3):
  Ext4Pkg: Replac= e the CRC implementations with BaseLib
  Ext4Pkg: Format using uncr= ustify
  Ext4Pkg: Add ext2/3 support

 Features/Ext4Pkg/= Ext4Dxe/BlockGroup.c |  10 +-
 Features/Ext4Pkg/Ext4Dxe/BlockM= ap.c   | 279 +++++++++++++++++
 Features/Ext4Pkg/Ext4Dxe/= Collation.c  |   4 +-
 Features/Ext4Pkg/Ext4Dxe/Crc1= 6.c      |  75 -----
 Features/Ext4Pkg/Ext4Dxe/= Crc32c.c     |  84 ------
 Features/Ext4Pkg/Ext= 4Dxe/Directory.c  |  13 +-
 Features/Ext4Pkg/Ext4Dxe/Disk= Util.c   |   6 +-
 Features/Ext4Pkg/Ext4Dxe/Ext= 4Disk.h   |  30 +-
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe= .c    |  95 +++---
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe= .h    | 417 ++++++++++++++------------
 Features/Ext4Pkg/= Ext4Dxe/Ext4Dxe.inf  |   3 +-
 Features/Ext4Pkg/Ext4= Dxe/Extents.c    |  27 +-
 Features/Ext4Pkg/Ext4Dxe/= File.c       |  19 +-
 Features/Ext4Pkg/Ex= t4Dxe/Inode.c      |  33 +-
 Features/Ext4Pkg/E= xt4Dxe/Partition.c  |  12 +-
 Features/Ext4Pkg/Ext4Dxe/Su= perblock.c |  20 +-
 16 files changed, 640 insertions(+), 487 = deletions(-)
 create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.= c
 delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
 del= ete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c

--
2.35.1=



--

Pedro Falcato



-- =

Ped= ro Falcato



--

Pedro Falcato

= ------=_NextPart_000_00F9_01D87670.88494EB0--