public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
	"'Sean Brogan'" <sean.brogan@microsoft.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg
Date: Fri, 28 Jan 2022 17:20:06 +0800	[thread overview]
Message-ID: <00f901d81428$3d756220$b8602660$@byosoft.com.cn> (raw)
In-Reply-To: <16CE645E8FF49BA2.17874@groups.io>

Sean and Mike:
 Today, I create PR https://github.com/tianocore/edk2/pull/2448. It pass CI
and auto merged. But, this change brings the build break in NetworkPkg and
ShellPkg. Can you help check why PR 2448 can pass? Are some CI tasks
skipped?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2022年1月28日 17:14
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and
> NetworkPkg
> 
> Commit f4b7b473b4afd0093768905529bfae09a2061d41 adds new library
> class
> dependency in UefiBootManagerLib. The package DSC should add this library
> class instance if it consumes UefiBootManagerLib.
> 
> Because this change fixes CI break, it will be merged soon.
> 
> Liming Gao (2):
>   ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc
>   NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc
> 
>  NetworkPkg/NetworkPkg.dsc | 1 +
>  ShellPkg/ShellPkg.dsc     | 1 +
>  2 files changed, 2 insertions(+)
> 
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 




       reply	other threads:[~2022-01-28  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16CE645E8FF49BA2.17874@groups.io>
2022-01-28  9:20 ` gaoliming [this message]
2022-01-29  1:45 ` 回复: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00f901d81428$3d756220$b8602660$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox