public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* 回复: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg
       [not found] <16CE645E8FF49BA2.17874@groups.io>
@ 2022-01-28  9:20 ` gaoliming
  2022-01-29  1:45 ` gaoliming
  1 sibling, 0 replies; 2+ messages in thread
From: gaoliming @ 2022-01-28  9:20 UTC (permalink / raw)
  To: devel, gaoliming, 'Sean Brogan',
	'Michael D Kinney'

Sean and Mike:
 Today, I create PR https://github.com/tianocore/edk2/pull/2448. It pass CI
and auto merged. But, this change brings the build break in NetworkPkg and
ShellPkg. Can you help check why PR 2448 can pass? Are some CI tasks
skipped?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2022年1月28日 17:14
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and
> NetworkPkg
> 
> Commit f4b7b473b4afd0093768905529bfae09a2061d41 adds new library
> class
> dependency in UefiBootManagerLib. The package DSC should add this library
> class instance if it consumes UefiBootManagerLib.
> 
> Because this change fixes CI break, it will be merged soon.
> 
> Liming Gao (2):
>   ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc
>   NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc
> 
>  NetworkPkg/NetworkPkg.dsc | 1 +
>  ShellPkg/ShellPkg.dsc     | 1 +
>  2 files changed, 2 insertions(+)
> 
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread
* 回复: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg
       [not found] <16CE645E8FF49BA2.17874@groups.io>
  2022-01-28  9:20 ` 回复: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg gaoliming
@ 2022-01-29  1:45 ` gaoliming
  1 sibling, 0 replies; 2+ messages in thread
From: gaoliming @ 2022-01-29  1:45 UTC (permalink / raw)
  To: devel, gaoliming

PR https://github.com/tianocore/edk2/pull/2450 is created for this fix. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2022年1月28日 17:14
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and
> NetworkPkg
> 
> Commit f4b7b473b4afd0093768905529bfae09a2061d41 adds new library
> class
> dependency in UefiBootManagerLib. The package DSC should add this library
> class instance if it consumes UefiBootManagerLib.
> 
> Because this change fixes CI break, it will be merged soon.
> 
> Liming Gao (2):
>   ShellPkg: Add the missing VariablePolicyHelperLib in ShellPkg.dsc
>   NetworkPkg: Add the missing VariablePolicyHelperLib in NetworkPkg.dsc
> 
>  NetworkPkg/NetworkPkg.dsc | 1 +
>  ShellPkg/ShellPkg.dsc     | 1 +
>  2 files changed, 2 insertions(+)
> 
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 




^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-29  1:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <16CE645E8FF49BA2.17874@groups.io>
2022-01-28  9:20 ` 回复: [edk2-devel] [PATCH 0/2] Fix package build break in ShellPkg and NetworkPkg gaoliming
2022-01-29  1:45 ` gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox