From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9C7F178003C for ; Thu, 9 May 2024 07:36:57 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xc/LkTmgHrGoZNtUAorD11k//m294v68LG4KBT51B6k=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1715240216; v=1; b=Vn0cbaYRLct6hm8sVhLLGCzwFr0k3bHAdPylBdkK5HQULh13dPQG08lDqWzw7AM12cAJqvN+ Xmx4iXK5ts0c0Z+ksHgc8RMCUriDZSIFSA5+cZCUrIKJeMJfFgHNyao6ztiWAJLExpN5/5cdRDd IVZcHHWYvrQ3p5rShR2k1AReN2JwEtd2lT3QjXoOKxOoRCj9n4xENUAPEcLSZ6likdkKTS7rBNK 8FpDBKXivBNZQQZS2D6VczLHS3lhc4rkSbgmEpSvxQJJwOyT0oxB7gUyntZyp/CNwoK8Ems5Cxs QhYA2RbWvhuyPp7spYhVzJdDzkWNDiNd52EQt1Qr2wsDQ== X-Received: by 127.0.0.2 with SMTP id lSoUYY7687511x9fpJUcZKp8; Thu, 09 May 2024 00:36:56 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.4817.1715240214505931274 for ; Thu, 09 May 2024 00:36:55 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id E5144DDA7B7 for ; Thu, 9 May 2024 15:36:51 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id E03DDDDA7A3 for ; Thu, 9 May 2024 15:36:51 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 39FFFDDA7AF for ; Thu, 9 May 2024 15:36:48 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 09 May 2024 15:36:37 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , , "'Wu, Jiaxin'" Cc: "'Yao, Jiewen'" , "'Ni, Ray'" , "'Zeng, Star'" , "'Gerd Hoffmann'" , "'Kumar, Rahul R'" , "'Dong, Guo'" , "'Rhodes, Sean'" , "'Lu, James'" , "'Guo, Gua'" , "'Abdul Lateef Attar'" , "'Abner Chang'" , "'Tom Lendacky'" References: <20240426121720.54308-1-jiaxin.wu@intel.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY0IDAwLzE0XSBBZGQgU21tUmVsb2NhdGlvbkxpYg==?= Date: Thu, 9 May 2024 15:36:40 +0800 Message-ID: <00fb01daa1e3$a1db8fa0$e592aee0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQHKegMUdmCLzWYHBlmq/XqWlhNFtwHdjopLAXcP0LUCaVgnXQGCl4LVActhlDyxZnJDMA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 09 May 2024 00:36:55 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1xASEntwROhygsWDQwwGLnbRx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Vn0cbaYR; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Ard: Gerd is the reviewer of OvmfPkg. He gave Acked-by before soft feature fre= eze. So, this patch set can be merged for this stable tag 202405.=20 And, this patch set has been merged.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Ard Biesheuvel > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B45=E6=9C=889=E6=97=A5 0= :44 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Wu, Jiaxin ; Liming Gao= (Byosoft address) > > =E6=8A=84=E9=80=81: Yao, Jiewen ; Ni, Ray ; > devel@edk2.groups.io; Zeng, Star ; Gerd Hoffmann > ; Kumar, Rahul R ; Dong, Guo > ; Rhodes, Sean ; Lu, James > ; Guo, Gua ; Abdul Lateef Attar > ; Abner Chang ; Tom > Lendacky > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v4 00/14] Add SmmRelocationLi= b >=20 > Happy to merge this. >=20 > Liming, please let me know if this meets the soft freeze requirements? >=20 > Thanks, >=20 >=20 > On Tue, 7 May 2024 at 07:18, Wu, Jiaxin wrote: > > > > Thanks Jiewen. > > > > > > > > > > > > > > > > From: Yao, Jiewen > > Sent: Tuesday, May 7, 2024 12:59 PM > > To: Wu, Jiaxin ; Ni, Ray ; > devel@edk2.groups.io; Ard Biesheuvel > > Cc: Zeng, Star ; Gerd Hoffmann = ; > Kumar, Rahul R ; Dong, Guo ; > Rhodes, Sean ; Lu, James ; Guo= , > Gua ; Abdul Lateef Attar ; > Abner Chang ; Tom Lendacky > > > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > Acked-by: Jiewen Yao > > > > > > > > From: Wu, Jiaxin > > Sent: Tuesday, May 7, 2024 11:39 AM > > To: Ni, Ray ; devel@edk2.groups.io; Ard Biesheuvel > ; Yao, Jiewen > > Cc: Zeng, Star ; Gerd Hoffmann = ; > Kumar, Rahul R ; Dong, Guo ; > Rhodes, Sean ; Lu, James ; Guo= , > Gua ; Abdul Lateef Attar ; > Abner Chang ; Tom Lendacky > > > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > Hi Jiewen and Ard, > > > > > > > > @Yao, Jiewen, @Ard Biesheuvel, do you agree we merge the change related= to > OVMF package since you are the OVMF maintainers. Please help check /revie= w. > > > > > > > > The patches have been acked/tested by the Gerd. > > > > > > > > [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for > OVMF > > [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create > gEfiSmmSmramMemoryGuid > > [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation > > [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation > is done or not > > [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > > > > > > > Thanks, > > > > Jiaxin > > > > > > > > From: Wu, Jiaxin > > Sent: Tuesday, April 30, 2024 6:14 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Zeng, Star ; Gerd Hoffmann = ; > Kumar, Rahul R ; Dong, Guo ; > Rhodes, Sean ; Lu, James ; Guo= , > Gua ; Ard Biesheuvel ; Yao, > Jiewen ; Abdul Lateef Attar > ; Abner Chang ; Tom > Lendacky > > Subject: RE: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > Thanks Ray, I missed to add some already reviewed-by tag in v4. All V4 = patches > are tested & acted by Gerd: > > > > Tested-by: Gerd Hoffmann > > > > Acked-by: Gerd Hoffmann > > > > > > > > For each one: listed as below, *so need Ray =E2=80=9Creviewed-by=E2=80= =9D tag on the patch: > 05/06/14, need Gerd =E2=80=9Creviewed-by=E2=80=9D tag on the patch: 08/0= 9/10/11/12* > > > > > > > > [PATCH v4 01/14] UefiCpuPkg: Add SmmRelocationLib class > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > [PATCH v4 02/14] UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib > library instance > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > [PATCH v4 03/14] UefiCpuPkg/SmmRelocationLib: Rename global variables > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > [PATCH v4 04/14] UefiCpuPkg/SmmRelocationLib: Avoid unnecessary > memory allocation > > > > Reviewed-by: Ray Ni --> no change compared to V3 > > > > > > [PATCH v4 05/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary > global variable > > [PATCH v4 06/14] UefiCpuPkg/SmmRelocationLib: Remove unnecessary > CpuIndex > > > > * Change Based on Ray=E2=80=99s comment on V3: split the removal of Cpu= Index > parameter in a new patch, so add the 06 patch in V4.* > > > > > > [PATCH v4 07/14] UefiCpuPkg/SmmRelocationLib: Add library instance fo= r > AMD > > > > Reviewed-by: Abdul Lateef Attar --> no chan= ge > compared to V3 > > > > > > [PATCH v4 08/14] OvmfPkg/SmmRelocationLib: Add library instance for > OVMF > > [PATCH v4 09/14] OvmfPkg/PlatformInitLib: Create > gEfiSmmSmramMemoryGuid > > [PATCH v4 10/14] OvmfPkg: Refine SmmAccess implementation > > [PATCH v4 11/14] OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation > is done or not > > [PATCH v4 12/14] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > > > *Change Based on Gerd=E2=80=99s comment on V3: 1. Creating the > EFI_SMM_SMRAM_MEMORY_GUID HOB should be moved to its own function. > 2) refine the comment in SmmAccess 3) refine the commit log.* > > > > > > [PATCH v4 13/14] UefiPayloadPkg/UefiPayloadPkg.dsc: Include > SmmRelocationLib > > > > Reviewed-by: Gua Guo > > > > Reviewed-by: Guo Dong > > > > > > [PATCH v4 14/14] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases > relocation logic > > > > *Change Based on Ray=E2=80=99s comment on V3: move the "TileSize" check= just below > the original TileSize calculation logic* > > > > > > > > Thanks, > > > > Jiaxin > > > > > > > > From: Ni, Ray > > Sent: Tuesday, April 30, 2024 2:01 PM > > To: Wu, Jiaxin ; devel@edk2.groups.io > > Cc: Zeng, Star ; Gerd Hoffmann = ; > Kumar, Rahul R ; Dong, Guo ; > Rhodes, Sean ; Lu, James ; Guo= , > Gua ; Ard Biesheuvel ; Yao, > Jiewen ; Abdul Lateef Attar > ; Abner Chang ; Tom > Lendacky > > Subject: Re: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > Jiaxin, > > > > You need to add the missing Reviewed-by for each patch if the patch doe= sn't > change in V4. > > > > > > > > Can you reply to this mail to list what patches have already got Review= ed-by > from whom? > > > > > > > > > > > > > > > > Thanks, > > > > Ray > > > > ________________________________ > > > > From: Wu, Jiaxin > > Sent: Friday, April 26, 2024 20:17 > > To: devel@edk2.groups.io > > Cc: Ni, Ray ; Zeng, Star ; Gerd > Hoffmann ; Kumar, Rahul R ; > Dong, Guo ; Rhodes, Sean ; Lu, > James ; Guo, Gua ; Ard Biesheuvel > ; Yao, Jiewen ; Abdul > Lateef Attar ; Abner Chang > ; Tom Lendacky > > Subject: [PATCH v4 00/14] Add SmmRelocationLib > > > > > > > > PR: https://github.com/tianocore/edk2/pull/5546 > > > > Intel plans to separate the smbase relocation logic from > > PiSmmCpuDxeSmm driver, and the related behavior will be > > moved to the new interface defined by the SmmRelocationLib > > class. > > > > The SmmRelocationLib class provides the SmmRelocationInit() > > interface for platform to do the smbase relocation, which > > shall provide below 2 functionalities: > > 1. Relocate smbases for each processor. > > 2. Create the gSmmBaseHobGuid HOB. > > > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > > a later phase) can be simplfied as below for SMM init: > > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > > for each Processor. > > 2. Execute the early SMM Init. > > > > Cc: Ray Ni > > Cc: Zeng Star > > Cc: Gerd Hoffmann > > Cc: Rahul Kumar > > Cc: Guo Dong > > Cc: Sean Rhodes > > Cc: James Lu > > Cc: Gua Guo > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Abdul Lateef Attar > > Cc: Abner Chang > > Cc: Tom Lendacky > > Signed-off-by: Jiaxin Wu > > > > Jiaxin Wu (14): > > UefiCpuPkg: Add SmmRelocationLib class > > UefiCpuPkg/SmmRelocationLib: Add SmmRelocationLib library instance > > UefiCpuPkg/SmmRelocationLib: Rename global variables > > UefiCpuPkg/SmmRelocationLib: Avoid unnecessary memory allocation > > UefiCpuPkg/SmmRelocationLib: Remove unnecessary global variable > > UefiCpuPkg/SmmRelocationLib: Remove unnecessary CpuIndex > > UefiCpuPkg/SmmRelocationLib: Add library instance for AMD > > OvmfPkg/SmmRelocationLib: Add library instance for OVMF > > OvmfPkg/PlatformInitLib: Create gEfiSmmSmramMemoryGuid > > OvmfPkg: Refine SmmAccess implementation > > OvmfPkg/SmmCpuFeaturesLib: Check Smbase Relocation is done or not > > OvmfPkg/PlatformPei: Relocate SmBases in PEI phase > > UefiPayloadPkg/UefiPayloadPkg.dsc: Include SmmRelocationLib > > UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic > > > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 + > > OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + > > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 135 +++-- > > .../Library/PlatformInitLib/PlatformInitLib.inf | 6 +- > > .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 33 +- > > .../Library/SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > > .../Library/SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > +++++++++++++++++++++ > > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 60 +++ > > .../SmmRelocationLib/SmramSaveStateConfig.c | 100 ++++ > > .../Library/SmmRelocationLib}/X64/Semaphore.c | 13 +- > > .../Library/SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > > OvmfPkg/Microvm/MicrovmX64.dsc | 1 + > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > OvmfPkg/PlatformPei/Platform.c | 3 + > > OvmfPkg/PlatformPei/Platform.h | 5 + > > OvmfPkg/PlatformPei/PlatformPei.inf | 5 +- > > OvmfPkg/PlatformPei/SmmRelocation.c | 80 +++ > > OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 4 +- > > OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 5 + > > OvmfPkg/SmmAccess/SmmAccessPei.c | 116 ++--- > > OvmfPkg/SmmAccess/SmmAccessPei.inf | 11 +- > > OvmfPkg/SmmAccess/SmramInternal.c | 72 +-- > > OvmfPkg/SmmAccess/SmramInternal.h | 19 +- > > UefiCpuPkg/Include/Library/SmmRelocationLib.h | 42 ++ > > .../SmmRelocationLib/AmdSmmRelocationLib.inf | 60 +++ > > .../SmmRelocationLib/AmdSmramSaveStateConfig.c | 125 +++++ > > .../SmmRelocationLib}/Ia32/Semaphore.c | 13 +- > > .../SmmRelocationLib}/Ia32/SmmInit.nasm | 83 +++- > > .../SmmRelocationLib/InternalSmmRelocationLib.h | 127 +++++ > > .../Library/SmmRelocationLib/SmmRelocationLib.c | 549 > +++++++++++++++++++++ > > .../Library/SmmRelocationLib/SmmRelocationLib.inf | 61 +++ > > .../SmmRelocationLib/SmramSaveStateConfig.c | 136 +++++ > > .../SmmRelocationLib}/X64/Semaphore.c | 13 +- > > .../SmmRelocationLib}/X64/SmmInit.nasm | 85 +++- > > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 21 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 334 > ++----------- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 103 +--- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 - > > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMpPerf.h | 2 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 69 --- > > UefiCpuPkg/UefiCpuPkg.dec | 3 + > > UefiCpuPkg/UefiCpuPkg.dsc | 2 + > > UefiPayloadPkg/UefiPayloadPkg.dsc | 2 + > > 48 files changed, 2578 insertions(+), 796 deletions(-) > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.c > > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > > create mode 100644 > OvmfPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/X64/Semaphore.c (78%) > > copy {UefiCpuPkg/PiSmmCpuDxeSmm =3D> > OvmfPkg/Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > > create mode 100644 OvmfPkg/PlatformPei/SmmRelocation.c > > create mode 100644 UefiCpuPkg/Include/Library/SmmRelocationLib.h > > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/AmdSmmRelocationLib.inf > > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/AmdSmramSaveStateConfig.c > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/Ia32/Semaphore.c (71%) > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/Ia32/SmmInit.nasm (47%) > > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/InternalSmmRelocationLib.h > > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.c > > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/SmmRelocationLib.inf > > create mode 100644 > UefiCpuPkg/Library/SmmRelocationLib/SmramSaveStateConfig.c > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/X64/Semaphore.c (78%) > > rename UefiCpuPkg/{PiSmmCpuDxeSmm =3D> > Library/SmmRelocationLib}/X64/SmmInit.nasm (59%) > > > > -- > > 2.16.2.windows.1 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118746): https://edk2.groups.io/g/devel/message/118746 Mute This Topic: https://groups.io/mt/105997264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-