From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.47308.1669909604264474443 for ; Thu, 01 Dec 2022 07:46:44 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=Eif3xAA0; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B1Cu4uv027782; Thu, 1 Dec 2022 15:46:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=Wu26qUqwfu6xReaeyTeTSh3kyPcIfRTY6rZCJP1PQFc=; b=Eif3xAA0582rLo+hQDnttUl2hwM0Q2vcjTgmlt1OUnEfjx2ir5sw9TR3fzioUJObeKv6 OPuzLXyfGuqrkYXP3QPSIpXWqblvVDPKM+I+LNjrthGLEYWt+PqAgRjASoLOXtqq1XAC crwbg4JoMgxzR4MDf/oLflx/EsB7YBZUUoluybr5GY0hukiTYt5ldgHoW2EkiPZJGsgF rw8FJhl1mWxlruSRG3MMEWBUP1hGYtXYDUTn7J5RPiggXaK325LTXeB4biJKwSTDtXtD MRgKZUrOfRbTV8IuwuapUDIU3mzDQHiBd+UfYBLi09tCXNv3ofiPlX1qwvf8B6E/f5MW PQ== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m6k5tajga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 15:46:33 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2B1FkWGY013055 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Dec 2022 15:46:32 GMT Received: from [10.110.26.238] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 1 Dec 2022 07:46:32 -0800 Message-ID: <00fb9e9e-565f-08ba-cd67-9536915d2b8d@quicinc.com> Date: Thu, 1 Dec 2022 08:46:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [edk2-devel] [PATCH 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support To: , CC: Andrew Fish , Leif Lindholm , Michael D Kinney , Michael Kubacki , Zhiguang Liu , Liming Gao , =?UTF-8?B?VG9ueUxvIFvnvoXph5Hmnb5d?= References: <20221003092643.4813-1-richardho@ami.com> From: "Rebecca Cran" In-Reply-To: <20221003092643.4813-1-richardho@ami.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: Cy5IqBEUpUXnGiQYn5Ze4svgyCnJ7KcE X-Proofpoint-ORIG-GUID: Cy5IqBEUpUXnGiQYn5Ze4svgyCnJ7KcE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-01_11,2022-12-01_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212010115 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 2B1Cu4uv027782 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 10/3/22 03:26, RichardHo [=E4=BD=95=E6=98=8E=E5=BF=A0] via groups.io w= rote: > diff --git a/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c b/UsbNetworkPkg/= UsbRndis/UsbRndisFunction.c > new file mode 100644 > index 0000000000..5db95b284c > --- /dev/null > +++ b/UsbNetworkPkg/UsbRndis/UsbRndisFunction.c > +/** > + This function is called when UndiShutdown is invoked. > + > + @param[in] Cdb A pointer to the command descriptor block. > + @param[in] Nic A pointer to the Network interface controller data. > + > + @retval EFI_SUCCESS The request executed successfully. > + > +**/ > +EFI_STATUS > +EFIAPI > +RndisUndiShutdown ( > + IN PXE_CDB *Cdb, > + IN NIC_DATA *Nic > + ) > +{ > + EDKII_USB_ETHERNET_PROTOCOL *UsbEthDriver =3D Nic->UsbEth; > + USB_RNDIS_DEVICE *UsbRndisDevice =3D USB_RNDIS_DEVICE_FR= OM_THIS (UsbEthDriver); > + REMOTE_NDIS_HALT_MSG RndisHltMsg; > + EFI_STATUS Status; > + > + DEBUG ((DEBUG_INFO, "RndisUndiShutdown\n")); According to the edk2 coding style, you should declare and initialize=20 variables separately. +/** + This is a dummy function which just returns. Unimplimented=20 EDKII_USB_ETHERNET_PROTOCOL functions + point to this function. Typo. Should be "Unimplemented". diff --git a/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h=20 b/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h index 98eef820d895..9d607da72051 100644 --- a/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h +++ b/UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h +#define USB_ETH_FRAME_SIZE 0x5F2 // frome network stack Typo. --=20 Rebecca Cran