From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.716.1668130360297252646 for ; Thu, 10 Nov 2022 17:32:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=c4vKFs/V; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id D4F77CD1F6E9 for ; Fri, 11 Nov 2022 09:32:37 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1668130357; bh=3DkHKRfQ5rN+kcsimPmHVuGOOyGqaJ5JD1KTsxJpO4o=; h=From:To:References:In-Reply-To:Subject:Date; b=c4vKFs/VNwttCsFyAE50Ipns1+Gk1m86dy2kCu0CwmoJnIxZoexh3n9FBYIMfwqYY vU70EdQDf1WZCFcUq/OizI/sNlbZZNyGY2C2a33n/MLcaWecBwviBYdmteX5lojhcS FxrCMHaGC1qjEQGNEPeabYBO9DfgYBVw23g9mjuI= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id D0CD0CD1F6E6 for ; Fri, 11 Nov 2022 09:32:37 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id A2A1ACD1F6BA for ; Fri, 11 Nov 2022 09:32:37 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 4B501CD1F6CF for ; Fri, 11 Nov 2022 09:32:34 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 11 Nov 2022 09:32:31 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kinney, Michael D'" , References: <20221108231252.1864-1-michael.d.kinney@intel.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIHYzIDAvN10gQWRkIEdvb2dsZVRlc3QgdG8gVW5pdFRlc3RGcmFtZXdvcmtQa2c=?= Date: Fri, 11 Nov 2022 09:32:34 +0800 Message-ID: <00fd01d8f56d$795b5a20$6c120e60$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHn2y8cdK6VYmMFMkeG4ZKYL1VSqAIGqvElrgruq/A= Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike: Since there is no big change in soft feature freeze phase, I agree to mer= ge it for this stable tag. =20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B411=E6=9C=8811=E6=97=A5= 9:10 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Gao, Liming ; Kinn= ey, Michael D > ; devel@edk2.groups.io > =E4=B8=BB=E9=A2=98: FW: [edk2-devel] [Patch v3 0/7] Add GoogleTest to > UnitTestFrameworkPkg >=20 > Liming, >=20 > The review for adding GoogleTest support to the UnitTestFrameworkPkg was > started > before Soft Freeze and only had some minor documentation updates during > the Soft Freeze. >=20 > I would like to request this PR be merged for the stable tag. >=20 > https://github.com/tianocore/edk2/pull/3595 >=20 > It has all the commit messages updated with Rb/Ab and passes all CI check= s. >=20 > Thanks, >=20 > Mike >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Tuesday, November 8, 2022 3:13 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Liu, Zhiguang > ; Feng, Bob C ; Chen, > Christine ; Sean Brogan > ; Michael Kubacki > ; Andrew Fish ; Leif > Lindholm > Subject: [edk2-devel] [Patch v3 0/7] Add GoogleTest to > UnitTestFrameworkPkg >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4134 >=20 > Add GoogleTest support to UnitTestFrameworkPkg to provide an > additional host-based unit test framework to developers. >=20 > Code: https://github.com/google/googletest > Docs: https://google.github.io/googletest >=20 > GoogleTest is implemented in C++, but does support implementing > unit tests for C code. This patch series makes a few updates for C++ > compatibility and build issues related to multiple definitions of _ASSERT= (). > The GoogleTest git submodule is added to the UnitTestFrameworkPkg > and .pytools/CISettings.py file along with an update to the host-based > test runner plugin to set the GTEST_OUTPUT environment variable to > specify the XML output file format and location. >=20 > A port of the unit tests for the the MdePkg BaseSafeIntLib are included > to provide an example that is in both the current unit test style and the > GoogleTest style. >=20 > New in V2 > --------- > * Update maintainers/reviewers > * Add feature table to Readme.md and fix typos >=20 > New in V3 > --------- > * Add link to googletest license file to Readme.rst >=20 > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Andrew Fish > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (7): > MdePkg/Include: Update Base.h to improve C++ compatibility > MdePkg/Include/Library: Undefine _ASSERT() if already defined > UnitTestFrameworkPkg: Add googletest submodule and GoogleTestLib > UnitTestFrameworkPkg/Library/CmockaLib: Generate symbol information > .pytool: Add googletest submodule to CISettings.py > BaseTools/Plugin/HostBaseUnitTestRunner: Enable gtest xml output > MdePkg/Test: Add port of BaseSafeIntLib unit tests to GoogleTest >=20 > .gitmodules | 3 + > .pytool/CISettings.py | 2 + > .../HostBasedUnitTestRunner.py | 7 +- > MdePkg/Include/Base.h | 12 +- > MdePkg/Include/Library/DebugLib.h | 3 + > .../GoogleTestBaseSafeIntLib.inf | 37 + > .../GoogleTestBaseSafeIntLib.uni | 13 + > .../SafeIntLibUintnIntnUnitTests32.cpp | 425 +++ > .../SafeIntLibUintnIntnUnitTests64.cpp | 429 ++++ > .../BaseSafeIntLib/TestBaseSafeIntLib.cpp | 2274 > +++++++++++++++++ > MdePkg/Test/MdePkgHostTest.dsc | 1 + > ReadMe.rst | 1 + > .../Include/Library/GoogleTestLib.h | 14 + > .../Library/CmockaLib/CmockaLib.inf | 2 +- > .../Library/GoogleTestLib/GoogleTestLib.inf | 36 + > .../Library/GoogleTestLib/GoogleTestLib.uni | 14 + > .../Library/GoogleTestLib/googletest | 1 + > UnitTestFrameworkPkg/ReadMe.md | 255 +- > .../SampleGoogleTest/SampleGoogleTest.cpp | 263 ++ > .../SampleGoogleTest/SampleGoogleTestHost.inf | 35 + > .../Test/UnitTestFrameworkPkgHostTest.dsc | 4 +- > .../UnitTestFrameworkPkg.ci.yaml | 4 +- > UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec | 8 + > .../UnitTestFrameworkPkgHost.dsc.inc | 4 +- > 24 files changed, 3811 insertions(+), 36 deletions(-) > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/GoogleTestBaseSafeIntLib.i > nf > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/GoogleTestBaseSafeIntLib.u > ni > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTest > s32.cpp > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/SafeIntLibUintnIntnUnitTest > s64.cpp > create mode 100644 > MdePkg/Test/GoogleTest/Library/BaseSafeIntLib/TestBaseSafeIntLib.cpp > create mode 100644 > UnitTestFrameworkPkg/Include/Library/GoogleTestLib.h > create mode 100644 > UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.inf > create mode 100644 > UnitTestFrameworkPkg/Library/GoogleTestLib/GoogleTestLib.uni > create mode 160000 > UnitTestFrameworkPkg/Library/GoogleTestLib/googletest > create mode 100644 > UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleG > oogleTest.cpp > create mode 100644 > UnitTestFrameworkPkg/Test/GoogleTest/Sample/SampleGoogleTest/SampleG > oogleTestHost.inf >=20 > -- > 2.37.1.windows.1 >=20 >=20 >=20 >=20 >=20