From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <bob.c.feng@intel.com>
Subject: 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python
Date: Thu, 14 Jan 2021 08:53:30 +0800 [thread overview]
Message-ID: <010101d6ea0f$ad1a0160$074e0420$@byosoft.com.cn> (raw)
In-Reply-To: <20210113095609.1398-1-bob.c.feng@intel.com>
Bob:
Have you plan to convert all C tools to Python tools? Or only some ones?
Can you share your planning for the changes in BaseTools?
And, I see you also add unittest for new split tool. Can you introduce the
unittest framework for python tool? If so, new added tool can follow the
same way to add unittest.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70232+4905953+8761045@groups.io
> <bounce+27952+70232+4905953+8761045@groups.io> 代表 Bob Feng
> 发送时间: 2021年1月13日 17:56
> 收件人: devel@edk2.groups.io
> 主题: [edk2-devel] [Patch 0/2] Convert Split tool to python
>
> There are 2 reasons to convert Split tool from C to Python.
>
> 1. We are in the process of moving the Basetools Python code
>
> to a separate repository. But there still are many C tools under
>
> edk2/BaseTools. To make all Basetools be in the separate repo,
>
> we can convert the C tools to Python tools.
>
> 2. The original Split tool is very slow. This python tool can reduce
>
> 90% time
>
> Bob Feng (2):
> BaseTools: Convert Split tool to python
> BaseTools: Add unittest for Split tool
>
> BaseTools/Source/C/Split/Split.c | 466 --------------------
> BaseTools/BinWrappers/PosixLike/Split | 31 +-
> BaseTools/BinWrappers/WindowsLike/Split.bat | 3 +
> BaseTools/Source/C/GNUmakefile | 1 -
> BaseTools/Source/C/Makefile | 1 -
> BaseTools/Source/C/Split/GNUmakefile | 17 -
> BaseTools/Source/C/Split/Makefile | 16 -
> BaseTools/Source/Python/Split/Split.py | 203 +++++++++
> BaseTools/Source/Python/Split/__init__.py | 10 +
> BaseTools/Source/Python/tests/test_split.py | 101 +++++
> 10 files changed, 325 insertions(+), 524 deletions(-)
> delete mode 100644 BaseTools/Source/C/Split/Split.c
> create mode 100644 BaseTools/BinWrappers/WindowsLike/Split.bat
> delete mode 100644 BaseTools/Source/C/Split/GNUmakefile
> delete mode 100644 BaseTools/Source/C/Split/Makefile
> create mode 100644 BaseTools/Source/Python/Split/Split.py
> create mode 100644 BaseTools/Source/Python/Split/__init__.py
> create mode 100644 BaseTools/Source/Python/tests/test_split.py
>
> --
> 2.29.1.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#70232): https://edk2.groups.io/g/devel/message/70232
> Mute This Topic: https://groups.io/mt/79647273/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
next prev parent reply other threads:[~2021-01-14 0:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 9:56 [Patch 0/2] Convert Split tool to python Bob Feng
2021-01-13 9:56 ` [Patch 1/2] BaseTools: " Bob Feng
2021-01-13 9:56 ` [Patch 2/2] BaseTools: Add unittest for Split tool Bob Feng
2021-01-14 0:53 ` gaoliming [this message]
2021-01-14 2:46 ` [edk2-devel] 回复: [edk2-devel] [Patch 0/2] Convert Split tool to python Bob Feng
2021-01-15 1:12 ` 回复: " gaoliming
2021-01-15 1:49 ` Bob Feng
2021-01-18 23:56 ` Bob Feng
2021-01-19 1:10 ` 回复: " gaoliming
2021-01-19 1:28 ` Bob Feng
[not found] ` <165B7DE8D411B030.2239@groups.io>
2021-01-19 13:58 ` Bob Feng
[not found] ` <165BA6D400EB9835.28472@groups.io>
2021-01-21 8:15 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010101d6ea0f$ad1a0160$074e0420$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox