From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.1328.1610585611292773220 for ; Wed, 13 Jan 2021 16:53:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 14 Jan 2021 08:53:27 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , References: <20210113095609.1398-1-bob.c.feng@intel.com> In-Reply-To: <20210113095609.1398-1-bob.c.feng@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BhdGNoIDAvMl0gQ29udmVydCBTcGxpdCB0b29sIHRvIHB5dGhvbg==?= Date: Thu, 14 Jan 2021 08:53:30 +0800 Message-ID: <010101d6ea0f$ad1a0160$074e0420$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFCoTv9OMsk0v2gigKV30tC9jmHPatO23zA Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Bob: Have you plan to convert all C tools to Python tools? Or only some = ones? Can you share your planning for the changes in BaseTools? =20 And, I see you also add unittest for new split tool. Can you introduce = the unittest framework for python tool? If so, new added tool can follow the same way to add unittest.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+70232+4905953+8761045@groups.io > =B4=FA=B1=ED Bob Feng > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA1=D4=C213=C8=D5 17:56 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =D6=F7=CC=E2: [edk2-devel] [Patch 0/2] Convert Split tool to python >=20 > There are 2 reasons to convert Split tool from C to Python. >=20 > 1. We are in the process of moving the Basetools Python code >=20 > to a separate repository. But there still are many C tools under >=20 > edk2/BaseTools. To make all Basetools be in the separate repo, >=20 > we can convert the C tools to Python tools. >=20 > 2. The original Split tool is very slow. This python tool can reduce >=20 > 90% time >=20 > Bob Feng (2): > BaseTools: Convert Split tool to python > BaseTools: Add unittest for Split tool >=20 > BaseTools/Source/C/Split/Split.c | 466 = -------------------- > BaseTools/BinWrappers/PosixLike/Split | 31 +- > BaseTools/BinWrappers/WindowsLike/Split.bat | 3 + > BaseTools/Source/C/GNUmakefile | 1 - > BaseTools/Source/C/Makefile | 1 - > BaseTools/Source/C/Split/GNUmakefile | 17 - > BaseTools/Source/C/Split/Makefile | 16 - > BaseTools/Source/Python/Split/Split.py | 203 +++++++++ > BaseTools/Source/Python/Split/__init__.py | 10 + > BaseTools/Source/Python/tests/test_split.py | 101 +++++ > 10 files changed, 325 insertions(+), 524 deletions(-) > delete mode 100644 BaseTools/Source/C/Split/Split.c > create mode 100644 BaseTools/BinWrappers/WindowsLike/Split.bat > delete mode 100644 BaseTools/Source/C/Split/GNUmakefile > delete mode 100644 BaseTools/Source/C/Split/Makefile > create mode 100644 BaseTools/Source/Python/Split/Split.py > create mode 100644 BaseTools/Source/Python/Split/__init__.py > create mode 100644 BaseTools/Source/Python/tests/test_split.py >=20 > -- > 2.29.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#70232): = https://edk2.groups.io/g/devel/message/70232 > Mute This Topic: https://groups.io/mt/79647273/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20