From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a7-12.smtp-out.eu-west-1.amazonses.com (a7-12.smtp-out.eu-west-1.amazonses.com [54.240.7.12]) by mx.groups.io with SMTP id smtpd.web10.30213.1683634108704051399 for ; Tue, 09 May 2023 05:08:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ipxe.org header.s=cphpx6z2rfcgehlykjjh3gknqe3hsoe2 header.b=cVWQN55l; spf=pass (domain: eu-west-1.amazonses.com, ip: 54.240.7.12, mailfrom: 010201880069b0b6-6a5f2d29-9bab-44b2-aa25-0a7507daf587-000000@eu-west-1.amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=cphpx6z2rfcgehlykjjh3gknqe3hsoe2; d=ipxe.org; t=1683634106; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=vKg2s4RwDx8uVS+0JYyq6iF2CEldJvneI6FSbvQ4J+k=; b=cVWQN55lg4MferZpC+9xx+KVGLDmQ7lq8hva4wsPrSnC3T9xnsTh3nDlp00+Et/o o77J+DpRLDP3BRzw2FgW8gymLmOHX7d5wwN933RbGS9ul9OU+WyTJk8cSrUoVz1Ncgd si/2y1KdH/TSvR8TTdb2+U9U9O1q7sgR1eP2ko6zYRcMInVWPT7FJbUukjVDp+pCpNj wJtKPUGx8ZwxkJYFR76L4c5U6/DFy+mvdr3+hRgUBX49HRf4qT598gIHSra0rIxlQyT EA0w785r5BFc21/kzbvikHtQWBlysjodWUKWLL4VM21X/vI08KsxpKHbkRJ2+uvOI3n HEG0lJ6mKw== DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=shh3fegwg5fppqsuzphvschd53n6ihuv; d=amazonses.com; t=1683634106; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=vKg2s4RwDx8uVS+0JYyq6iF2CEldJvneI6FSbvQ4J+k=; b=peznCH388MtagEM/Iu5vfFOvSPx6/a/yebDGZ2QSbaAx0RkNQRYX/9TA2Cfr67w3 y3bLqeZ3jboIjwJ3jus5YeUXjohjr5cpXXMPecJCxjoxyyJA36ain8hPca6ZU+AQltK QQ1dB8mDGAWneLuF+xXW7KiJ+GFOrSVkKLnh5wPI= Message-ID: <010201880069b0b6-6a5f2d29-9bab-44b2-aa25-0a7507daf587-000000@eu-west-1.amazonses.com> Date: Tue, 9 May 2023 12:08:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH 0/2] OvmfPkg: Relax assertion that interrupts do not occur at TPL_HIGH_LEVEL To: devel@edk2.groups.io, lersek@redhat.com Cc: Gerd Hoffmann , Oliver Steffen , Pawel Polawski , Jiewen Yao , Ard Biesheuvel , Jordan Justen References: <476bbc17-6484-9afd-9be9-08de14d1d72e@redhat.com> <01020187fd46b80f-a69b4ae5-545f-45ae-ab0d-a48f725c7a40-000000@eu-west-1.amazonses.com> <50bf1804-70ba-dfff-73ad-d2afdbedf5e7@redhat.com> From: "Michael Brown" In-Reply-To: <50bf1804-70ba-dfff-73ad-d2afdbedf5e7@redhat.com> X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on blyat.fensystems.co.uk Feedback-ID: 1.eu-west-1.fspj4M/5bzJ9NLRzJP0PaxRwxrpZqiDQJ1IF94CF2TA=:AmazonSES X-SES-Outgoing: 2023.05.09-54.240.7.12 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/05/2023 09:43, Laszlo Ersek wrote: > I'm not subscribed to the list, so I don't have a copy of patch#1. I've > checked patch#1 at this URL: > > https://listman.redhat.com/archives/edk2-devel-archive/2023-May/063591.html > > and I'll comment on it using the cover letter: > > I really like that patch, with one stylistic exception: in edk2, > explicit FALSE and TRUE comparisons are not desired. So I suggest: > > ASSERT (!GetInterruptState ()); > > Twice. > > In fact, I *think* that if you run uncrustify with the edk2 config on > the patch, then it will rewrite that code. I built and ran uncrustify with the edk2 config but it did not modify the code. (I did check that it would fix other deliberate errors such as extra whitespace, so I don't think this was an error in my setup.) I will send through v2 with the explicit "== FALSE" still present, for consistency with the rest of the code in that file. (I think I vaguely remember someone asking me to add the explicit comparisons when I first submitted the code.) I'm happy for there to be a follow up patch to change the coding style to remove all of the explicit boolean comparisons, if that is what is wanted. Thanks, Michael