public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: "'Sachin Ganesh'" <sachinganesh@ami.com>, <devel@edk2.groups.io>
Cc: <michael.d.kinney@intel.com>, <zhiguang.liu@intel.com>,
	"'Felix Polyudov'" <Felixp@ami.com>,
	"'Dhanaraj V'" <vdhanaraj@ami.com>
Subject: [edk2-devel] 回复: [PATCH v2 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path
Date: Tue, 16 Apr 2024 12:50:56 +0800	[thread overview]
Message-ID: <010401da8fb9$ab50ec60$01f2c520$@byosoft.com.cn> (raw)
In-Reply-To: <9b8c3d9c587260b2418fe897a2a8b41414220bd5.1713208978.git.sachinganesh@ami.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Sachin Ganesh <sachinganesh@ami.com>
> 发送时间: 2024年4月16日 3:28
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Dhanaraj V
> <vdhanaraj@ami.com>; Sachin Ganesh <sachinganesh@ami.com>
> 主题: [PATCH v2 1/5] MdePkg: Add definition for NVMe Over Fabric Device
> Path
> 
> In accordance with UEFI 2.10 Specification:
> Adding definition for NVMe Over Fabric (NVMe-oF) Device Path
> of Messaging Sub-Type.
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Felix Polyudov <felixp@ami.com>
> Cc: Dhanaraj V <vdhanaraj@ami.com>
> Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
> ---
>  MdePkg/Include/Protocol/DevicePath.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/DevicePath.h
> b/MdePkg/Include/Protocol/DevicePath.h
> index 9060dd782e..35008ddcdf 100644
> --- a/MdePkg/Include/Protocol/DevicePath.h
> +++ b/MdePkg/Include/Protocol/DevicePath.h
> @@ -837,6 +837,26 @@ typedef struct {
>    UINT64                      NamespaceUuid;
> 
>  } NVME_NAMESPACE_DEVICE_PATH;
> 
> 
> 
> +///
> 
> +/// NVMe over Fabric (NVMe-oF) Namespace Device Path SubType.
> 
> +///
> 
> +#define MSG_NVME_OF_NAMESPACE_DP  0x22
> 
> +typedef struct {
> 
> +  EFI_DEVICE_PATH_PROTOCOL    Header;
> 
> +  ///
> 
> +  /// Namespace Identifier Type (NIDT)
> 
> +  ///
> 
> +  UINT8                       NamespaceIdType;
> 
> +  ///
> 
> +  /// Namespace Identifier (NID)
> 
> +  ///
> 
> +  UINT8                       NamespaceId[16];
> 
> +  ///
> 
> +  /// Unique identifier of an NVM subsystem
> 
> +  ///
> 
> +  CHAR8                       SubsystemNqn[];
> 
> +} NVME_OF_NAMESPACE_DEVICE_PATH;
> 
> +
> 
>  ///
> 
>  /// DNS Device Path SubType
> 
>  ///
> 
> @@ -1287,6 +1307,7 @@ typedef union {
>    SAS_DEVICE_PATH                            Sas;
> 
>    SASEX_DEVICE_PATH                          SasEx;
> 
>    NVME_NAMESPACE_DEVICE_PATH
> NvmeNamespace;
> 
> +  NVME_OF_NAMESPACE_DEVICE_PATH
> NvmeOfNamespace;
> 
>    DNS_DEVICE_PATH                            Dns;
> 
>    URI_DEVICE_PATH                            Uri;
> 
>    BLUETOOTH_DEVICE_PATH                      Bluetooth;
> 
> @@ -1343,6 +1364,7 @@ typedef union {
>    SAS_DEVICE_PATH                            *Sas;
> 
>    SASEX_DEVICE_PATH                          *SasEx;
> 
>    NVME_NAMESPACE_DEVICE_PATH
> *NvmeNamespace;
> 
> +  NVME_OF_NAMESPACE_DEVICE_PATH
> *NvmeOfNamespace;
> 
>    DNS_DEVICE_PATH                            *Dns;
> 
>    URI_DEVICE_PATH                            *Uri;
> 
>    BLUETOOTH_DEVICE_PATH                      *Bluetooth;
> 
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117845): https://edk2.groups.io/g/devel/message/117845
Mute This Topic: https://groups.io/mt/105551420/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2024-04-16  4:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 19:27 [edk2-devel] [PATCH v2 1/5] MdePkg: Add definition for NVMe Over Fabric Device Path Sachin Ganesh via groups.io
2024-04-16  4:50 ` gaoliming via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='010401da8fb9$ab50ec60$01f2c520$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox