From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web09.1487.1668481239352423543 for ; Mon, 14 Nov 2022 19:00:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=FkVpRWNG; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id ED439CD1F7F8 for ; Tue, 15 Nov 2022 11:00:36 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1668481237; bh=L6/J6hnS8r5A+wppmxmf/rM4jSKRFhtt0XrIXDeBIss=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=FkVpRWNGk0ZsT2esiaquMYrHjduBS65Za5JsEKBubLU2Z3QOMujlhRM5SPJ5vpr5r Xp6e3wnyQO1JF3+aAY6I0oVB6GSVxpAzkRUuQ11ofxE9iTyyB7PSKld2nPz/62brWy Fhr/xBOP4eu0ZTlQJT+M287lNV1L+uVpoE0jqaQA= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id E9917CD1F7F7 for ; Tue, 15 Nov 2022 11:00:36 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id C1B0FCD1F7E9 for ; Tue, 15 Nov 2022 11:00:36 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id D9A09CD1F7E3 for ; Tue, 15 Nov 2022 11:00:33 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 15 Nov 2022 11:00:28 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Sean Brogan'" , "'Andrew Fish'" , "'Leif Lindholm'" , "'Kinney, Michael D'" References: <20221115001841.2018-1-mikuback@linux.microsoft.com> In-Reply-To: <20221115001841.2018-1-mikuback@linux.microsoft.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggZWRrMi1zdGFibGUyMDIyMTEgdjIgMC8yXSBVcGRhdGUgUHl0b29sIFBJUCBWZXJzaW9ucw==?= Date: Tue, 15 Nov 2022 11:00:28 +0800 Message-ID: <010701d8f89e$6afaeb60$40f0c220$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIXGkf/1tCSRRVyYr1n7SxZ4bJfhK3DCAyQ Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Michael: I have no comments to merge this patch set for the stable tag.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: mikuback@linux.microsoft.com = > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA11=D4=C215=C8=D5 8:19 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Sean Brogan ; Michael Kubacki > ; Liming Gao ; > Andrew Fish ; Leif Lindholm = > =D6=F7=CC=E2: [PATCH edk2-stable202211 v2 0/2] Update Pytool PIP = Versions >=20 > From: Michael Kubacki >=20 > 1. Updates edk2-pytool-library to 0.12.1 > - Picks up a minor bug fix >=20 > 2. Updates edk2-pytool-extensions to 0.20.0 > - Picks up a major release >=20 > The changes in each update are in the respective patch commit > messages. >=20 > CI was run against both of these patches in this pull request: > https://github.com/tianocore/edk2/pull/3632 >=20 > These changes are recommended to be included in the edk2-stable202211 > tag for the following reasons: >=20 > 1. edk2-pytool-library 0.12.0 to 0.12.1 includes a single bug fix > that simply returns file paths from > Edk2Path.GetContainingModules() with the original case used by > the operating system. This allow case sensitive callers to match > paths returned by the function correctly. >=20 > This can impact flows such as PR Eval that use this function to > determine which modules were impacted by a code change. Without > this change PR eval may not return consistent/expected results > across operating systems. >=20 > 2. The edk2-pytool-library change requires edk2-pytool-extensions > 0.20.0. For this reason, edk2-pytool-extensions setup.py was > updated in 0.20.0 to specify 0.12.1 as the edk2-pytool-library > requirement. The logic of determining a package in pytool-library > (Edk2Path.GetContainingPackage()) needs a corresponding change in > the edk2-pytool-extensions 0.20.0 release. >=20 > Without this change, flows such as PR Eval will not have updated > logic for calling the function and return incorrect results. >=20 > These changes have been tested against edk2 in pytool integration > testing, the PR linked above, and against similar code in Mu. >=20 > V2 changes: >=20 > 1. Add stable tag to patch subject > 2. Explain why changes should be included in stable tag > 3. Add Reviewed-by tags to patches from v1 >=20 > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Liming Gao > Cc: Andrew Fish > Cc: Leif Lindholm > Signed-off-by: Michael Kubacki >=20 > Michael Kubacki (2): > pip-requirements.txt: Update to edk2-pytool-library 0.12.1 > pip-requirements.txt: Update to edk2-pytool-extensions 0.20.0 >=20 > pip-requirements.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > -- > 2.28.0.windows.1