回复: 回复: [edk2-devel] Dynamic Stack Cookies PR For edk2-stable202502

["gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>]

Mike, Lefi and Fish:
  Coud you give your opinion for this PR https://github.com/tianocore/edk2/pull/6381 to be merged for edk2-stable202502?

  This PR has been almost reviewed. Its platform change is also submitted in edk2-platform https://github.com/tianocore/edk2-platforms/pull/736. I think its impact is acceptable.

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Oliver
> Smith-Denny via groups.io
> 发送时间: 2025年2月6日 0:07
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Michael Kinney'
> <michael.d.kinney@intel.com>
> 主题: Re: 回复: [edk2-devel] Dynamic Stack Cookies PR For
> edk2-stable202502
> 
> Thanks Liming.
> 
> I also responded to the comment on the PR, but yes this is correct.
> Dynamic stack cookies are only used if CUSTOM_STACK_CHECK_LIB is
> defined in the platform.
> 
> This change will affect platforms (as noted in the integration
> instructions) by requiring StackCheckLib to be linked against
> all custom entry point libs and modules with their own custom
> entry points (such as SEC modules).
> 
> Thanks,
> Oliver
> 
> On 2/5/2025 1:18 AM, gaoliming via groups.io wrote:
> > Oliver:
> >    I have added 202502 milestone for this PR.
> >
> >    If the platform wants to enable this feature, it needs to define
> CUSTOM_STACK_CHECK_LIB in its DSC file. If the platform doesn't enable this
> feature, it will not be impacted by this change. Right?
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Oliver
> >> Smith-Denny via groups.io
> >> 发送时间: 2025年2月4日 2:33
> >> 收件人: devel@edk2.groups.io; Liming Gao
> <gaoliming@byosoft.com.cn>;
> >> Michael Kinney <michael.d.kinney@intel.com>
> >> 主题: [edk2-devel] Dynamic Stack Cookies PR For edk2-stable202502
> >>
> >> Hi Liming,
> >>
> >> I am planning to merge https://github.com/tianocore/edk2/pull/6381
> >> for stable tag edk2-stable202502. It has been under review for
> >> several months now and currently has multiple approvals, just
> >> waiting for Mike Kinney to confirm he is done reviewing and
> >> hopefully approve :).
> >>
> >> I will also put up a PR in edk2-platforms to resolve the
> >> breaking change there.
> >>
> >> Thanks,
> >> Oliver
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#121105): https://edk2.groups.io/g/devel/message/121105
Mute This Topic: https://groups.io/mt/111033241/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-