From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0FE659406CF for ; Thu, 6 Feb 2025 15:10:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TNak/JoHbq4SD6cT6CqjlzArTHW8FU7Pb7N8lgHHCXs=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240830; t=1738854618; v=1; x=1739113817; b=U7BbekRWx163tEEmvoZWJZ8qzBxjUmodj/mS/zluCnTOl7jrK4jfIfFNV/0nPvJs5qpkH9xi s24A3axyJvfxiDTNOC5DSbgYFXBs2CLT9Q+gwsuyGGVf4rDFbKLei04QR9vnKg87GwqzhhX1gAJ ta8EJqnXhhCbPGFykNEYdhpjvWH1w87gvCEyX/9rYbVYcHbKPb4BCypeBMp93IBTGmpyoKdsema kQkp6U6+/A4nbMSkHIhYUmdeNOmWmPmFJVMNwU5wr2LQQxZI59vic7I2Z95K7xTwIODJ4xA3EXG Ce58ua1PWA2TgvERLoF4AY+NEutfpk3FA9mQ0cHfyeK4Q== X-Received: by 127.0.0.2 with SMTP id Ip3pYY7687511xpNiIWavCYi; Thu, 06 Feb 2025 07:10:17 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.43362.1738854610883347446 for ; Thu, 06 Feb 2025 07:10:11 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 7FF6FA32E031 for ; Thu, 6 Feb 2025 23:10:04 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 63280A32E027 for ; Thu, 6 Feb 2025 23:10:04 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id ABB12A32DFEA for ; Thu, 6 Feb 2025 23:10:00 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.92.34.228]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 06 Feb 2025 23:09:46 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.92.34.228 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , "'Michael Kinney'" , , "'Andrew Fish'" , "'Ard Biesheuvel'" Cc: References: <002701db77ae$fc921ad0$f5b65070$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBEeW5hbWljIFN0YWNrIENvb2tpZXMgUFIgRm9yIGVkazItc3RhYmxlMjAyNTAy?= Date: Thu, 6 Feb 2025 23:09:45 +0800 Message-ID: <010c01db78a9$2ac28980$80479c80$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKJZoW8jUR2fSmaXJS+PJ2l56jw+QIdT5vbARe3W3GxxNmj4A== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 06 Feb 2025 07:10:11 -0800 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AjMszLFij1UEthATYjCj0qsSx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=U7BbekRW; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Mike, Lefi and Fish: Coud you give your opinion for this PR https://github.com/tianocore/edk2/= pull/6381 to be merged for edk2-stable202502? This PR has been almost reviewed. Its platform change is also submitted i= n edk2-platform https://github.com/tianocore/edk2-platforms/pull/736. I thi= nk its impact is acceptable. Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Oliver > Smith-Denny via groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2025=E5=B9=B42=E6=9C=886=E6=97=A5 0= :07 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.= cn; 'Michael Kinney' > > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] Dynamic Stack Co= okies PR For > edk2-stable202502 >=20 > Thanks Liming. >=20 > I also responded to the comment on the PR, but yes this is correct. > Dynamic stack cookies are only used if CUSTOM_STACK_CHECK_LIB is > defined in the platform. >=20 > This change will affect platforms (as noted in the integration > instructions) by requiring StackCheckLib to be linked against > all custom entry point libs and modules with their own custom > entry points (such as SEC modules). >=20 > Thanks, > Oliver >=20 > On 2/5/2025 1:18 AM, gaoliming via groups.io wrote: > > Oliver: > > I have added 202502 milestone for this PR. > > > > If the platform wants to enable this feature, it needs to define > CUSTOM_STACK_CHECK_LIB in its DSC file. If the platform doesn't enable th= is > feature, it will not be impacted by this change. Right? > > > > Thanks > > Liming > >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Oliver > >> Smith-Denny via groups.io > >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2025=E5=B9=B42=E6=9C=884=E6=97= =A5 2:33 > >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Liming Gao > ; > >> Michael Kinney > >> =E4=B8=BB=E9=A2=98: [edk2-devel] Dynamic Stack Cookies PR For edk2-sta= ble202502 > >> > >> Hi Liming, > >> > >> I am planning to merge https://github.com/tianocore/edk2/pull/6381 > >> for stable tag edk2-stable202502. It has been under review for > >> several months now and currently has multiple approvals, just > >> waiting for Mike Kinney to confirm he is done reviewing and > >> hopefully approve :). > >> > >> I will also put up a PR in edk2-platforms to resolve the > >> breaking change there. > >> > >> Thanks, > >> Oliver > >> > >> > >> > >> > > > > > > > > > > > > > > >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121105): https://edk2.groups.io/g/devel/message/121105 Mute This Topic: https://groups.io/mt/111033241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-