From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.5394.1621386047918190952
 for <devel@edk2.groups.io>;
 Tue, 18 May 2021 18:00:48 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <dandan.bi@intel.com>; Wed, 19 May 2021 09:00:43 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<xiewenyi2@huawei.com>,
	<jian.j.wang@intel.com>,
	<hao.a.wu@intel.com>,
	<dandan.bi@intel.com>,
	<eric.dong@intel.com>
Cc: <songdongkuang@huawei.com>
References: <1621322219-109579-1-git-send-email-xiewenyi2@huawei.com> <1621322219-109579-2-git-send-email-xiewenyi2@huawei.com>
In-Reply-To: <1621322219-109579-2-git-send-email-xiewenyi2@huawei.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIEVESzIgdjEgMS8xXSBNZGVNb2R1bGVQa2cvSGlpRGF0YWJhc2VEeGU6IHJlbW92ZSBkZWFkIGNvZGU=?=
Date: Wed, 19 May 2021 09:00:30 +0800
Message-ID: <011101d74c4a$66e14850$34a3d8f0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQF00kmEe3JD2x274u2y7jIFPPk/EQHlMVRqq5/Gk7A=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=
=B1=ED wenyi,xie via
> groups.io
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C218=C8=D5 15:17
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; jian.j.wang@intel.com; hao.a.w=
u@intel.com;
> dandan.bi@intel.com; eric.dong@intel.com
> =B3=AD=CB=CD: songdongkuang@huawei.com; xiewenyi2@huawei.com
> =D6=F7=CC=E2: [edk2-devel] [PATCH EDK2 v1 1/1] MdeModulePkg/HiiDatabaseD=
xe:
> remove dead code
>=20
> Outer condition is 'BlockData->Name=3D=3DNULL' and inner
> condition is 'BlockData->Name!=3DNULL', Opposite 'if'
> condition leads to a dead code block.
>=20
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> index d492b769d51c..17a914208c6d 100644
> --- a/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> +++ b/MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c
> @@ -2871,9 +2871,6 @@ ParseIfrData (
>          //
>          if ((BlockData->Name =3D=3D NULL) && ((BlockData->Offset +
> BlockData->Width) > VarStorageData->Size)) {
>            Status =3D EFI_INVALID_PARAMETER;
> -          if (BlockData->Name !=3D NULL) {
> -            FreePool (BlockData->Name);
> -          }
>            FreePool (BlockData);
>            goto Done;
>          }
> --
> 2.20.1.windows.1
>=20
>=20
>=20
>=20
>=20