public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <tlaronde@polynum.com>, <devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [PATCH 1/1] BaseTools: remove useless header inclusion
Date: Sun, 29 Jan 2023 09:59:29 +0800	[thread overview]
Message-ID: <011101d93385$52b411e0$f81c35a0$@byosoft.com.cn> (raw)
In-Reply-To: <Y9JP5n4V2GI5hVpk@polynum.com>

With this change, does GenFv pass build on Linux environment?

> -----邮件原件-----
> 发件人: tlaronde@polynum.com <tlaronde@polynum.com>
> 发送时间: 2023年1月26日 18:03
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 主题: [PATCH 1/1] BaseTools: remove useless header inclusion
> 
> GenFvInternalLib.c: useless inclusion and dependency on uuid.h.
> 
> From 6c0ba96fa11390750e102ebd277f59ef38970394 Mon Sep 17 00:00:00
> 2001
> From: Thierry LARONDE <tlaronde@polynum.com>
> Date: Thu, 26 Jan 2023 10:49:12 +0100
> Subject: [PATCH] Remove useless uuid.h include.
> 
> Signed-off-by: Thierry LARONDE <tlaronde@polynum.com>
> ---
>  BaseTools/Source/C/GenFv/GenFvInternalLib.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> index 6bd59515b1..2df7182f8b 100644
> --- a/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> +++ b/BaseTools/Source/C/GenFv/GenFvInternalLib.c
> @@ -14,11 +14,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>  // Include files
>  //
> 
> -#if defined(__FreeBSD__)
> -#include <uuid.h>
> -#elif defined(__GNUC__)
> -#include <uuid/uuid.h>
> -#endif
>  #ifdef __GNUC__
>  #include <sys/stat.h>
>  #endif
> --
> 2.39.0
> 
> --
>         Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
>                      http://www.kergis.com/
>                     http://kertex.kergis.com/
> Key fingerprint = 0FF7 E906 FBAF FE95 FD89  250D 52B1 AE95 6006 F40C



  reply	other threads:[~2023-01-29  1:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 10:03 [PATCH 1/1] BaseTools: remove useless header inclusion tlaronde
2023-01-29  1:59 ` gaoliming [this message]
2023-01-29  9:45   ` [edk2-devel] ??: " tlaronde
2023-01-30  6:42     ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011101d93385$52b411e0$f81c35a0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox