public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Rebecca Cran'" <rebecca@nuviainc.com>, <devel@edk2.groups.io>
Cc: "'Leif Lindholm'" <leif@nuviainc.com>,
	"'Ard Biesheuvel'" <ard.biesheuvel@arm.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>
Subject: 回复: [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with processor status data
Date: Wed, 11 Nov 2020 09:18:38 +0800	[thread overview]
Message-ID: <011201d6b7c8$95b1d490$c1157db0$@byosoft.com.cn> (raw)
In-Reply-To: <20201111001748.20217-3-rebecca@nuviainc.com>

This change follows SmBios spec. It is ok to me. Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@nuviainc.com>
> 发送时间: 2020年11月11日 8:18
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Leif Lindholm
> <leif@nuviainc.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Michael D
> Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with
> processor status data
> 
> Add a bitfield that describes the structure of the byte in the Status
> field of the SMBIOS Type 4 Processor Information table.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index 1ee01645679a..bb4a3a8dc0d3 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -875,6 +875,19 @@ typedef struct {
>    UINT16  ProcessorReserved2             :6;
>  } PROCESSOR_CHARACTERISTIC_FLAGS;
> 
> +///
> +/// Processor Information - Status
> +///
> +typedef union {
> +  struct {
> +    UINT8 CpuStatus       :3; // Indicates the status of the processor.
> +    UINT8 Reserved1       :3; // Reserved for future use. Should be set
> to zero.
> +    UINT8 SocketPopulated :1; // Indicates if the processor socket is
> populated or not.
> +    UINT8 Reserved2       :1; // Reserved for future use. Should be set
> to zero.
> +  } Bits;
> +  UINT8 Data;
> +} PROCESSOR_STATUS_DATA;
> +
>  typedef struct {
>    PROCESSOR_SIGNATURE     Signature;
>    PROCESSOR_FEATURE_FLAGS FeatureFlags;
> --
> 2.26.2




  reply	other threads:[~2020-11-11  1:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  0:17 [PATCH v3 0/3] ArmPkg,MdePkg: Add Universal/Smbios and Drivers/VersionInfoPeim Rebecca Cran
2020-11-11  0:17 ` [PATCH v3 1/3] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h Rebecca Cran
2020-11-12 21:49   ` [edk2-devel] " Sami Mujawar
2020-11-19 12:00   ` Leif Lindholm
2020-11-11  0:17 ` [PATCH v3 2/3] MdePkg: Update IndustryStandard/SmBios.h with processor status data Rebecca Cran
2020-11-11  1:18   ` gaoliming [this message]
2020-11-13 11:25   ` [edk2-devel] " Sami Mujawar
2020-11-19 12:05   ` Leif Lindholm
2020-11-11  0:17 ` [PATCH v3 3/3] ArmPkg: add Universal/Smbios as a generic SMBIOS library Rebecca Cran
2020-11-16 13:43   ` [edk2-devel] " Sami Mujawar
2020-11-17  3:27     ` Rebecca Cran
2020-11-19 12:58   ` Leif Lindholm
2020-12-07  4:59     ` Rebecca Cran
2020-12-07 17:11       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011201d6b7c8$95b1d490$c1157db0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox