From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Ard Biesheuvel'" <ardb@kernel.org>, <pierre.gondois@arm.com>
Cc: <devel@edk2.groups.io>, "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>,
"'Leif Lindholm'" <quic_llindhol@quicinc.com>,
"'Sami Mujawar'" <sami.mujawar@arm.com>,
"'Laszlo Ersek'" <lersek@redhat.com>
Subject: 回复: [PATCH 1/1] tools_def: Remove duplicated -Os
Date: Sun, 29 Jan 2023 10:03:33 +0800 [thread overview]
Message-ID: <011201d93385$e41293f0$ac37bbd0$@byosoft.com.cn> (raw)
In-Reply-To: <CAMj1kXHf=W8gv2zcxjjf0QoKLiXHJ7Vj6hbv3sQ1CJN_AQnBKA@mail.gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Ard Biesheuvel <ardb@kernel.org>
> 发送时间: 2023年1月27日 22:00
> 收件人: pierre.gondois@arm.com
> 抄送: devel@edk2.groups.io; Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>; Leif
> Lindholm <quic_llindhol@quicinc.com>; Sami Mujawar
> <sami.mujawar@arm.com>; Laszlo Ersek <lersek@redhat.com>
> 主题: Re: [PATCH 1/1] tools_def: Remove duplicated -Os
>
> On Wed, 25 Jan 2023 at 10:21, <pierre.gondois@arm.com> wrote:
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2928
> >
> > commit 17bd834eb5fd ("BaseTools: Factorize GCC flags")
> > makes GCC48_ALL_CC_FLAGS inherit from GCC_ALL_CC_FLAGS.
> > GCC_ALL_CC_FLAGS contains the '-Os' flag.
> > The latest flag in a command line overrides the previous
> > optimization option. This allows more specific build
> > configuration to override the inherited '-Os' flag.
> >
> > If a build configuration includes GCC48_ALL_CC_FLAGS,
> > hard-coded '-Os' options are not necessary anymore.
> > Remove them.
> >
> > Reported-by: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
>
> Acked-by: Ard Biesheuvel <ardb@kernel.org>
>
> > ---
> > BaseTools/Conf/tools_def.template | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> > index 380d4587335a..f77e936c0453 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -2024,8 +2024,8 @@ DEFINE GCC5_LOONGARCH64_PP_FLAGS
> = -mabi=lp64d -march=loongarch64 DEF(
> > *_GCC48_IA32_OBJCOPY_FLAGS =
> > *_GCC48_IA32_NASM_FLAGS = -f elf32
> >
> > - DEBUG_GCC48_IA32_CC_FLAGS = DEF(GCC48_IA32_CC_FLAGS)
> -Os
> > -RELEASE_GCC48_IA32_CC_FLAGS = DEF(GCC48_IA32_CC_FLAGS)
> -Os -Wno-unused-but-set-variable
> > + DEBUG_GCC48_IA32_CC_FLAGS =
> DEF(GCC48_IA32_CC_FLAGS)
> > +RELEASE_GCC48_IA32_CC_FLAGS = DEF(GCC48_IA32_CC_FLAGS)
> -Wno-unused-but-set-variable
> > NOOPT_GCC48_IA32_CC_FLAGS =
> DEF(GCC48_IA32_CC_FLAGS) -O0
> >
> > ##################
> > @@ -2052,8 +2052,8 @@ RELEASE_GCC48_IA32_CC_FLAGS =
> DEF(GCC48_IA32_CC_FLAGS) -Os -Wno-unused-but
> > *_GCC48_X64_OBJCOPY_FLAGS =
> > *_GCC48_X64_NASM_FLAGS = -f elf64
> >
> > - DEBUG_GCC48_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS)
> -Os
> > -RELEASE_GCC48_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS)
> -Os -Wno-unused-but-set-variable
> > + DEBUG_GCC48_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS)
> > +RELEASE_GCC48_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS)
> -Wno-unused-but-set-variable
> > NOOPT_GCC48_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS)
> -O0
> >
> > ##################
> > @@ -2161,8 +2161,8 @@ RELEASE_GCC48_AARCH64_CC_FLAGS =
> DEF(GCC48_AARCH64_CC_FLAGS) -Wno-unused-but-s
> > *_GCC49_IA32_OBJCOPY_FLAGS =
> > *_GCC49_IA32_NASM_FLAGS = -f elf32
> >
> > - DEBUG_GCC49_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS)
> -Os
> > -RELEASE_GCC49_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS)
> -Os -Wno-unused-but-set-variable -Wno-unused-const-variable
> > + DEBUG_GCC49_IA32_CC_FLAGS =
> DEF(GCC49_IA32_CC_FLAGS)
> > +RELEASE_GCC49_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS)
> -Wno-unused-but-set-variable -Wno-unused-const-variable
> > NOOPT_GCC49_IA32_CC_FLAGS =
> DEF(GCC49_IA32_CC_FLAGS) -O0
> >
> > ##################
> > @@ -2189,8 +2189,8 @@ RELEASE_GCC49_IA32_CC_FLAGS =
> DEF(GCC49_IA32_CC_FLAGS) -Os -Wno-unused-but
> > *_GCC49_X64_OBJCOPY_FLAGS =
> > *_GCC49_X64_NASM_FLAGS = -f elf64
> >
> > - DEBUG_GCC49_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS)
> -Os
> > -RELEASE_GCC49_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS)
> -Os -Wno-unused-but-set-variable -Wno-unused-const-variable
> > + DEBUG_GCC49_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS)
> > +RELEASE_GCC49_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS)
> -Wno-unused-but-set-variable -Wno-unused-const-variable
> > NOOPT_GCC49_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS)
> -O0
> >
> > ##################
> > @@ -2304,10 +2304,10 @@ RELEASE_GCC49_AARCH64_DLINK_XIPFLAGS
> = -z common-page-size=0x20
> > *_GCC5_IA32_OBJCOPY_FLAGS =
> > *_GCC5_IA32_NASM_FLAGS = -f elf32
> >
> > - DEBUG_GCC5_IA32_CC_FLAGS = DEF(GCC5_IA32_CC_FLAGS)
> -flto -Os
> > + DEBUG_GCC5_IA32_CC_FLAGS = DEF(GCC5_IA32_CC_FLAGS)
> -flto
> > DEBUG_GCC5_IA32_DLINK_FLAGS =
> DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os
> -Wl,-m,elf_i386,--oformat=elf32-i386
> >
> > -RELEASE_GCC5_IA32_CC_FLAGS = DEF(GCC5_IA32_CC_FLAGS)
> -flto -Os -Wno-unused-but-set-variable -Wno-unused-const-variable
> > +RELEASE_GCC5_IA32_CC_FLAGS = DEF(GCC5_IA32_CC_FLAGS)
> -flto -Wno-unused-but-set-variable -Wno-unused-const-variable
> > RELEASE_GCC5_IA32_DLINK_FLAGS =
> DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os
> -Wl,-m,elf_i386,--oformat=elf32-i386
> >
> > NOOPT_GCC5_IA32_CC_FLAGS = DEF(GCC5_IA32_CC_FLAGS)
> -O0
> > @@ -2336,10 +2336,10 @@ RELEASE_GCC5_IA32_DLINK_FLAGS =
> DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os -Wl,
> > *_GCC5_X64_OBJCOPY_FLAGS =
> > *_GCC5_X64_NASM_FLAGS = -f elf64
> >
> > - DEBUG_GCC5_X64_CC_FLAGS = DEF(GCC5_X64_CC_FLAGS)
> -flto -DUSING_LTO -Os
> > + DEBUG_GCC5_X64_CC_FLAGS = DEF(GCC5_X64_CC_FLAGS)
> -flto -DUSING_LTO
> > DEBUG_GCC5_X64_DLINK_FLAGS =
> DEF(GCC5_X64_DLINK_FLAGS) -flto -Os
> >
> > -RELEASE_GCC5_X64_CC_FLAGS = DEF(GCC5_X64_CC_FLAGS)
> -flto -DUSING_LTO -Os -Wno-unused-but-set-variable
> -Wno-unused-const-variable
> > +RELEASE_GCC5_X64_CC_FLAGS = DEF(GCC5_X64_CC_FLAGS)
> -flto -DUSING_LTO -Wno-unused-but-set-variable
> -Wno-unused-const-variable
> > RELEASE_GCC5_X64_DLINK_FLAGS = DEF(GCC5_X64_DLINK_FLAGS)
> -flto -Os
> >
> > NOOPT_GCC5_X64_CC_FLAGS = DEF(GCC5_X64_CC_FLAGS)
> -O0
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2023-01-29 2:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 9:20 [PATCH 1/1] tools_def: Remove duplicated -Os PierreGondois
2023-01-27 14:00 ` Ard Biesheuvel
2023-01-29 1:53 ` 回复: [edk2-devel] " gaoliming
2023-01-29 2:03 ` gaoliming [this message]
2023-01-30 5:21 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011201d93385$e41293f0$ac37bbd0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox