From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.8974.1674957823875423599 for ; Sat, 28 Jan 2023 18:03:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=UdbF7CNB; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 6C1F8CD1F6AD for ; Sun, 29 Jan 2023 10:03:40 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1674957820; bh=aDgfPafuGdI/TzxlNHCqhFwMwuj4GRIRRS6AxrokgNs=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=UdbF7CNBK6Es6LoXFJQpZn8oisujvxjDpYijcCkakxU/wb/U1XTS6mJIYsxRBPF5E W+PBkNsCQShp58fHtbayoWd95cvh5uvhf5/jHkru4WWrJ9EBpdy/8x2j/OvoSAqc0S 50M7bRw7ho6eIy+3nTtOLZbDIVPaH2aU3qG5Tugg= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 67E0ACD1F66F for ; Sun, 29 Jan 2023 10:03:40 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 321A2CD1F64D for ; Sun, 29 Jan 2023 10:03:40 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id B2682CD1F66F for ; Sun, 29 Jan 2023 10:03:37 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Sun, 29 Jan 2023 10:03:32 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Ard Biesheuvel'" , Cc: , "'Bob Feng'" , "'Yuwei Chen'" , "'Leif Lindholm'" , "'Sami Mujawar'" , "'Laszlo Ersek'" References: <20230125092059.497721-1-pierre.gondois@arm.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggMS8xXSB0b29sc19kZWY6IFJlbW92ZSBkdXBsaWNhdGVkIC1Pcw==?= Date: Sun, 29 Jan 2023 10:03:33 +0800 Message-ID: <011201d93385$e41293f0$ac37bbd0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQNK4OyW2SA4fRBl/RJQcEmOZDNl5gFhziYEq8Y7WlA= Sender: "gaoliming" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Ard Biesheuvel > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2023=E5=B9=B41=E6=9C=8827=E6=97=A5 22:00 > =E6=94=B6=E4=BB=B6=E4=BA=BA: pierre.gondois@arm.com > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Bob Feng = ; Liming Gao > ; Yuwei Chen ; Leif > Lindholm ; Sami Mujawar > ; Laszlo Ersek > =E4=B8=BB=E9=A2=98: Re: [PATCH 1/1] tools_def: Remove duplicated -Os >=20 > On Wed, 25 Jan 2023 at 10:21, wrote: > > > > From: Pierre Gondois > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2928 > > > > commit 17bd834eb5fd ("BaseTools: Factorize GCC flags") > > makes GCC48_ALL_CC_FLAGS inherit from GCC_ALL_CC_FLAGS. > > GCC_ALL_CC_FLAGS contains the '-Os' flag. > > The latest flag in a command line overrides the previous > > optimization option. This allows more specific build > > configuration to override the inherited '-Os' flag. > > > > If a build configuration includes GCC48_ALL_CC_FLAGS, > > hard-coded '-Os' options are not necessary anymore. > > Remove them. > > > > Reported-by: Laszlo Ersek > > Signed-off-by: Pierre Gondois >=20 > Acked-by: Ard Biesheuvel >=20 > > --- > > BaseTools/Conf/tools_def.template | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > > index 380d4587335a..f77e936c0453 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -2024,8 +2024,8 @@ DEFINE GCC5_LOONGARCH64_PP_FLAGS > =3D -mabi=3Dlp64d -march=3Dloongarch64 DEF( > > *_GCC48_IA32_OBJCOPY_FLAGS =3D > > *_GCC48_IA32_NASM_FLAGS =3D -f elf32 > > > > - DEBUG_GCC48_IA32_CC_FLAGS =3D DEF(GCC48_IA32_CC_FLAGS) > -Os > > -RELEASE_GCC48_IA32_CC_FLAGS =3D DEF(GCC48_IA32_CC_FLAGS) > -Os -Wno-unused-but-set-variable > > + DEBUG_GCC48_IA32_CC_FLAGS =3D > DEF(GCC48_IA32_CC_FLAGS) > > +RELEASE_GCC48_IA32_CC_FLAGS =3D DEF(GCC48_IA32_CC_FLAGS) > -Wno-unused-but-set-variable > > NOOPT_GCC48_IA32_CC_FLAGS =3D > DEF(GCC48_IA32_CC_FLAGS) -O0 > > > > ################## > > @@ -2052,8 +2052,8 @@ RELEASE_GCC48_IA32_CC_FLAGS =3D > DEF(GCC48_IA32_CC_FLAGS) -Os -Wno-unused-but > > *_GCC48_X64_OBJCOPY_FLAGS =3D > > *_GCC48_X64_NASM_FLAGS =3D -f elf64 > > > > - DEBUG_GCC48_X64_CC_FLAGS =3D DEF(GCC48_X64_CC_FLAGS) > -Os > > -RELEASE_GCC48_X64_CC_FLAGS =3D DEF(GCC48_X64_CC_FLAGS) > -Os -Wno-unused-but-set-variable > > + DEBUG_GCC48_X64_CC_FLAGS =3D DEF(GCC48_X64_CC_FLAGS) > > +RELEASE_GCC48_X64_CC_FLAGS =3D DEF(GCC48_X64_CC_FLAGS) > -Wno-unused-but-set-variable > > NOOPT_GCC48_X64_CC_FLAGS =3D DEF(GCC48_X64_CC_FLAGS) > -O0 > > > > ################## > > @@ -2161,8 +2161,8 @@ RELEASE_GCC48_AARCH64_CC_FLAGS =3D > DEF(GCC48_AARCH64_CC_FLAGS) -Wno-unused-but-s > > *_GCC49_IA32_OBJCOPY_FLAGS =3D > > *_GCC49_IA32_NASM_FLAGS =3D -f elf32 > > > > - DEBUG_GCC49_IA32_CC_FLAGS =3D DEF(GCC49_IA32_CC_FLAGS) > -Os > > -RELEASE_GCC49_IA32_CC_FLAGS =3D DEF(GCC49_IA32_CC_FLAGS) > -Os -Wno-unused-but-set-variable -Wno-unused-const-variable > > + DEBUG_GCC49_IA32_CC_FLAGS =3D > DEF(GCC49_IA32_CC_FLAGS) > > +RELEASE_GCC49_IA32_CC_FLAGS =3D DEF(GCC49_IA32_CC_FLAGS) > -Wno-unused-but-set-variable -Wno-unused-const-variable > > NOOPT_GCC49_IA32_CC_FLAGS =3D > DEF(GCC49_IA32_CC_FLAGS) -O0 > > > > ################## > > @@ -2189,8 +2189,8 @@ RELEASE_GCC49_IA32_CC_FLAGS =3D > DEF(GCC49_IA32_CC_FLAGS) -Os -Wno-unused-but > > *_GCC49_X64_OBJCOPY_FLAGS =3D > > *_GCC49_X64_NASM_FLAGS =3D -f elf64 > > > > - DEBUG_GCC49_X64_CC_FLAGS =3D DEF(GCC49_X64_CC_FLAGS) > -Os > > -RELEASE_GCC49_X64_CC_FLAGS =3D DEF(GCC49_X64_CC_FLAGS) > -Os -Wno-unused-but-set-variable -Wno-unused-const-variable > > + DEBUG_GCC49_X64_CC_FLAGS =3D DEF(GCC49_X64_CC_FLAGS) > > +RELEASE_GCC49_X64_CC_FLAGS =3D DEF(GCC49_X64_CC_FLAGS) > -Wno-unused-but-set-variable -Wno-unused-const-variable > > NOOPT_GCC49_X64_CC_FLAGS =3D DEF(GCC49_X64_CC_FLAGS) > -O0 > > > > ################## > > @@ -2304,10 +2304,10 @@ RELEASE_GCC49_AARCH64_DLINK_XIPFLAGS > =3D -z common-page-size=3D0x20 > > *_GCC5_IA32_OBJCOPY_FLAGS =3D > > *_GCC5_IA32_NASM_FLAGS =3D -f elf32 > > > > - DEBUG_GCC5_IA32_CC_FLAGS =3D DEF(GCC5_IA32_CC_FLAGS) > -flto -Os > > + DEBUG_GCC5_IA32_CC_FLAGS =3D DEF(GCC5_IA32_CC_FLAGS) > -flto > > DEBUG_GCC5_IA32_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os > -Wl,-m,elf_i386,--oformat=3Delf32-i386 > > > > -RELEASE_GCC5_IA32_CC_FLAGS =3D DEF(GCC5_IA32_CC_FLAGS) > -flto -Os -Wno-unused-but-set-variable -Wno-unused-const-variable > > +RELEASE_GCC5_IA32_CC_FLAGS =3D DEF(GCC5_IA32_CC_FLAGS) > -flto -Wno-unused-but-set-variable -Wno-unused-const-variable > > RELEASE_GCC5_IA32_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os > -Wl,-m,elf_i386,--oformat=3Delf32-i386 > > > > NOOPT_GCC5_IA32_CC_FLAGS =3D DEF(GCC5_IA32_CC_FLAGS) > -O0 > > @@ -2336,10 +2336,10 @@ RELEASE_GCC5_IA32_DLINK_FLAGS =3D > DEF(GCC5_IA32_X64_DLINK_FLAGS) -flto -Os -Wl, > > *_GCC5_X64_OBJCOPY_FLAGS =3D > > *_GCC5_X64_NASM_FLAGS =3D -f elf64 > > > > - DEBUG_GCC5_X64_CC_FLAGS =3D DEF(GCC5_X64_CC_FLAGS) > -flto -DUSING_LTO -Os > > + DEBUG_GCC5_X64_CC_FLAGS =3D DEF(GCC5_X64_CC_FLAGS) > -flto -DUSING_LTO > > DEBUG_GCC5_X64_DLINK_FLAGS =3D > DEF(GCC5_X64_DLINK_FLAGS) -flto -Os > > > > -RELEASE_GCC5_X64_CC_FLAGS =3D DEF(GCC5_X64_CC_FLAGS) > -flto -DUSING_LTO -Os -Wno-unused-but-set-variable > -Wno-unused-const-variable > > +RELEASE_GCC5_X64_CC_FLAGS =3D DEF(GCC5_X64_CC_FLAGS) > -flto -DUSING_LTO -Wno-unused-but-set-variable > -Wno-unused-const-variable > > RELEASE_GCC5_X64_DLINK_FLAGS =3D DEF(GCC5_X64_DLINK_FLAGS) > -flto -Os > > > > NOOPT_GCC5_X64_CC_FLAGS =3D DEF(GCC5_X64_CC_FLAGS) > -O0 > > -- > > 2.25.1 > >