public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Min Xu'" <min.m.xu@intel.com>, <devel@edk2.groups.io>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>,
	"'Jiewen Yao'" <jiewen.yao@intel.com>,
	"'Jian J Wang'" <jian.j.wang@intel.com>,
	"'Ken Lu'" <ken.lu@intel.com>,
	"'Sami Mujawar'" <sami.mujawar@arm.com>,
	"'Gerd Hoffmann'" <kraxel@redhat.com>
Subject: 回复: [PATCH V2 6/8] MdePkg: Define CC Measure EventLog ACPI Table
Date: Tue, 12 Apr 2022 09:09:40 +0800	[thread overview]
Message-ID: <011401d84e09$fc72e510$f558af30$@byosoft.com.cn> (raw)
In-Reply-To: <5c92547a681f8eced03b3705db7c79fe50ebc976.1649399642.git.min.m.xu@intel.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Min Xu <min.m.xu@intel.com>
> 发送时间: 2022年4月8日 14:39
> 收件人: devel@edk2.groups.io
> 抄送: Min Xu <min.m.xu@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Jiewen Yao <jiewen.yao@intel.com>;
> Jian J Wang <jian.j.wang@intel.com>; Ken Lu <ken.lu@intel.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@redhat.com>
> 主题: [PATCH V2 6/8] MdePkg: Define CC Measure EventLog ACPI Table
> 
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853
> 
> TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the
> event-log information. The event log created by the TD owner contains
> the hashes to reconstruct the MRTD and RTMR registers.
> 
> Please refer to Sec 4.3.3 in blow link:
> https://www.intel.com/content/dam/develop/external/us/en/documents/
> intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf
> 
> Please be noted, the definition of EFI_CC_EVENTLOG_ACPI_TABLE is a
> little different from the above document. This difference is based on
> below discussion:
> - https://edk2.groups.io/g/devel/message/87396
> - https://edk2.groups.io/g/devel/message/87402
> 
> This change will be reflected in the next version of the above document.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ken Lu <ken.lu@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Min Xu <min.m.xu@intel.com>
> ---
>  MdePkg/Include/Protocol/CcMeasurement.h | 21
> +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/CcMeasurement.h
> b/MdePkg/Include/Protocol/CcMeasurement.h
> index 68029e977fac..58123ca72163 100644
> --- a/MdePkg/Include/Protocol/CcMeasurement.h
> +++ b/MdePkg/Include/Protocol/CcMeasurement.h
> @@ -299,4 +299,25 @@ typedef struct {
> 
>  extern EFI_GUID  gEfiCcFinalEventsTableGuid;
> 
> +//
> +// Define the CC Measure EventLog ACPI Table
> +//
> +#pragma pack(1)
> +
> +typedef struct {
> +  EFI_ACPI_DESCRIPTION_HEADER    Header;
> +  EFI_CC_TYPE                    CcType;
> +  UINT32                         Rsvd;
> +  UINT64                         Laml;
> +  UINT64                         Lasa;
> +} EFI_CC_EVENTLOG_ACPI_TABLE;
> +
> +#pragma pack()
> +
> +//
> +// Define the signature and revision of CC Measurement EventLog ACPI
Table
> +//
> +#define EFI_CC_EVENTLOG_ACPI_TABLE_SIGNATURE  SIGNATURE_32('C',
> 'C', 'E', 'L')
> +#define EFI_CC_EVENTLOG_ACPI_TABLE_REVISION   1
> +
>  #endif
> --
> 2.29.2.windows.2




  parent reply	other threads:[~2022-04-12  1:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  6:39 [PATCH V2 0/8] Enable RTMR based measurement and measure boot for Td guest Min Xu
2022-04-08  6:39 ` [PATCH V2 1/8] Security: Add HashLibBaseCryptoRouterTdx Min Xu
2022-04-08  7:42   ` Yao, Jiewen
2022-04-08  8:07     ` Min Xu
2022-04-08  6:39 ` [PATCH V2 2/8] CryptoPkg: Add SecCryptLib Min Xu
2022-04-08  7:36   ` Yao, Jiewen
2022-04-08  8:04     ` Min Xu
2022-04-08  6:39 ` [PATCH V2 3/8] SecurityPkg: Add definition of EFI_CC_EVENT_HOB_GUID Min Xu
2022-04-08  7:36   ` Yao, Jiewen
2022-04-08  6:39 ` [PATCH V2 4/8] OvmfPkg/IntelTdx: Measure Td HobList and Configuration FV Min Xu
2022-04-08  7:43   ` Yao, Jiewen
2022-04-08  8:08     ` Min Xu
2022-04-08  6:39 ` [PATCH V2 5/8] OvmfPkg: Add PCDs for LAML/LASA field in CC EVENTLOG ACPI table Min Xu
2022-04-08  7:39   ` Yao, Jiewen
2022-04-08  6:39 ` [PATCH V2 6/8] MdePkg: Define CC Measure EventLog ACPI Table Min Xu
2022-04-08  7:37   ` Yao, Jiewen
2022-04-12  1:09   ` gaoliming [this message]
2022-04-08  6:39 ` [PATCH V2 7/8] OvmfPkg/IntelTdx: Add TdTcg2Dxe Min Xu
2022-04-08  6:39 ` [PATCH V2 8/8] OvmfPkg/IntelTdx: Enable RTMR based measurement and measure boot Min Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011401d84e09$fc72e510$f558af30$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox