回复: [PATCH v4 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, add GCC and GCCNOLTO, update CLANGDWARF

["gaoliming" <gaoliming@byosoft.com.cn>]

Rebecca:
  For the whole patch set, I give the comments for 09/13. Others are good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@bsdio.com>
> 发送时间: 2023年4月20日 3:58
> 收件人: devel@edk2.groups.io; Liming Gao <gaoliming@byosoft.com.cn>;
> Bob Feng <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>;
> Michael D Kinney <michael.d.kinney@intel.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Chasel Chiu <chasel.chiu@intel.com>; Nate
> DeSimone <nathaniel.l.desimone@intel.com>; Star Zeng
> <star.zeng@intel.com>; Andrew Fish <afish@apple.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; Ray Ni <ray.ni@intel.com>; Leif
> Lindholm <quic_llindhol@quicinc.com>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Jian J Wang <jian.j.wang@intel.com>; Xiaoyu Lu
> <xiaoyu1.lu@intel.com>; Guomin Jiang <guomin.jiang@intel.com>; Gua Guo
> <gua.guo@intel.com>; Ard Biesheuvel <ardb@kernel.org>; Pedro Falcato
> <pedro.falcato@gmail.com>; Gerd Hoffmann <kraxel@redhat.com>; Marvin
> Häuser <mhaeuser@posteo.de>
> 主题: [PATCH v4 00/13] BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others:
> Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5,
> add GCC and GCCNOLTO, update CLANGDWARF
> 
> Update the toolchain definitions:
> 
> - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
>   CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
> and IA32.
> 
> - Mark GCC48, GCC49 and GCC5 as deprecated.
> 
> - Add GCC and GCCNOLTO toolchain definitions.
> 
> - Remove VS2008, VS2010, VS2012 and VS2013.
> 
> - Remove EBC compiler definitions. Full removal of EBC support from the
>   various packages etc. will be done in a follow-up patch series.
> 
> - Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS
> definitions.
> 
> - Remove unused CYGWIN_ definitions.
> 
> Personal GitHub PR: https://github.com/tianocore/edk2/pull/4240
> GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf
> 
> Note: CI is now passing.
> 
> Changes from v1 to v2
> =====================
> 
> - Added a commit to delete GCC48 and GCC49, rename GCC5 to GCC and
>   update the flags for other toolchains to work with the new GCC
>   definitions.
> 
> - Bumped VERSION from 2.00 to 3.00 to inform users that they should
>   update their Conf/tools_def.txt.
> 
> Changes from v2 to v3
> =====================
> 
> - Keep GCC48, GCC49 and GCC5 but mark them deprecated, including with
>   warnings at the start and end of running a build.
> 
> - Dropped the commit fixing the IA32 build of UefiPayloadPkg, because it
>   causes CI to fail due to building both IA32 and X64 at the same time:
> 
>   "Module built under multiple ARCHs [IA32, X64]. Not able to determine
> which output to put into flash for Module..."
> 
> - Added more information to the VERSION section in tools_def.template.
> 
> - Various fixes to the CLANGDWARF flags.
> 
> Changes from v3 to v4
> =====================
> 
> - Use lld for -a ARM -t CLANGDWARF.
> 
> Rebecca Cran (13):
>   BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38
> toolchains
>   BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions
>   BaseTools: Remove VS2008-VS2013 remnants
>   MdePkg: Remove VS2008-VS2013 remnants
>   edksetup.bat: Remove VS2008-VS2013 remnants
>   BaseTools: Remove unused IPHONE_TOOLS and
> SOURCERY_CYGWIN_TOOLS defs
>   BaseTools: Remove EBC (EFI Byte Code) compiler definitions
>   BaseTools: Update VS toolchain descriptions in tools_def.txt.template
>   BaseTools/Conf/tools_def.template: Add GCC and GCCNOLTO toolchains
>   BaseTools: Only call LoadConfiguration once in build.py
>   BaseTools: Add a deprecation warning for GCC48,GCC49,GCC5 to build.py
>   BaseTools/Conf/tools_def.template: Add section for deprecated
>     toolchains
>   BaseTools/Conf/tools_def.template: Bump VERSION to 3.00
> 
>  UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc       |    2
> ++
>  IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc                     |    9
> ++++++++-
>  CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf             |    3
> +--
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf              |    3 +--
>  CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf          |    3 +--
>  CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf              |    3 +--
>  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf              |    3
> +--
>  CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf |    3 +--
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf                 |    3
> +--
>  CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf            |    3 +--
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf           |    3 +--
>  CryptoPkg/Library/OpensslLib/OpensslLibFull.inf             |    3 +--
>  CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf        |    3 +--
>  EmulatorPkg/Unix/Host/Host.inf                              |
> 2 ++
>  MdePkg/Include/Ia32/ProcessorBind.h                         |
> 8 ++------
>  MdePkg/Include/X64/ProcessorBind.h                          |
> 8 ++------
>  BaseTools/Conf/tools_def.template                           | 1993
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++---------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> -----------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> ---------------------------------------------------------------------------------------------
> -----------------------------------------------------------
> ---------------
>  BaseTools/Scripts/SetVisualStudio.bat                       |   22
> +---------------------
>  BaseTools/Scripts/ShowEnvironment.bat                       |   44
> --------------------------------------------
>  BaseTools/Source/Python/build/build.py                      |   18
> +++++++++++++++---
>  BaseTools/get_vsvars.bat                                    |
> 13 -------------
>  BaseTools/set_vsprefix_envs.bat                             |   64
> ----------------------------------------------------------------
>  BaseTools/toolsetup.bat                                     |
> 24 +-----------------------
>  edksetup.bat                                                |
> 6 +-----
>  24 files changed, 627 insertions(+), 1619 deletions(-)
> 
> --
> 2.37.2