From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web11.3260.1682044564103981036 for ; Thu, 20 Apr 2023 19:36:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=pwGS0FoG; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 88091CD1F6A8 for ; Fri, 21 Apr 2023 10:36:01 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1682044561; bh=JmiLCscybxrGuC9ydOJxWXXLhYgJioB7VPQtKfmfthI=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=pwGS0FoGEbh8LZVL/0q8hMetSdBHu4EPQF476iO32ix8lG89V1Jw6UOv7u4BcP1ua IS3H7pjuS3BX3ot+3r3PnrxubnuWYfNfLPHggJ/ynDdvDLxdGmOuh6vaudMGZ61XgJ 96C+UuWhnMMZm+6LsPnaRoKElUtn/1TZwGu0t/VE= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 82445CD1F6DA for ; Fri, 21 Apr 2023 10:36:01 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 48BB6CD1F701 for ; Fri, 21 Apr 2023 10:36:01 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id CF99FCD1F6A8 for ; Fri, 21 Apr 2023 10:35:58 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 21 Apr 2023 10:35:47 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Rebecca Cran'" , , "'Bob Feng'" , "'Yuwei Chen'" , "'Michael D Kinney'" , "'Michael Kubacki'" , "'Sean Brogan'" , "'Chasel Chiu'" , "'Nate DeSimone'" , "'Star Zeng'" , "'Andrew Fish'" Cc: "'Ray Ni'" , "'Leif Lindholm'" , "'Zhiguang Liu'" , "'Jian J Wang'" , "'Xiaoyu Lu'" , "'Guomin Jiang'" , "'Gua Guo'" , "'Ard Biesheuvel'" , "'Pedro Falcato'" , "'Gerd Hoffmann'" , =?utf-8?Q?'Marvin_H=C3=A4user'?= References: <20230419195746.99074-1-rebecca@bsdio.com> In-Reply-To: <20230419195746.99074-1-rebecca@bsdio.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjQgMDAvMTNdIEJhc2VUb29scyxDcnlwdG9Qa2csRW11bGF0b3JQa2csTWRlUGtnLG90aGVyczogRGVsZXRlIENMQU5HMzUsQ0xBTkczOCxWUzIwMDgtMjAxMyxFQkMsIGRlcHJlY2F0ZSBHQ0M0OCxHQ0M0OSxHQ0M1LCBhZGQgR0NDIGFuZCBHQ0NOT0xUTywgdXBkYXRlIENMQU5HRFdBUkY=?= Date: Fri, 21 Apr 2023 10:35:52 +0800 Message-ID: <011b01d973f9$fe1dff50$fa59fdf0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGealt5gHqEc24wT6EfRFc/tyT3jq+rHnFQ Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Rebecca: For the whole patch set, I give the comments for 09/13. Others are = good to me. Reviewed-by: Liming Gao Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Rebecca Cran > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2023=E5=B9=B44=E6=9C=8820=E6=97=A5 3:58 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Liming Gao = ; > Bob Feng ; Yuwei Chen ; > Michael D Kinney ; Michael Kubacki > ; Sean Brogan > ; Chasel Chiu ; Nate > DeSimone ; Star Zeng > ; Andrew Fish > =E6=8A=84=E9=80=81: Rebecca Cran ; Ray Ni = ; Leif > Lindholm ; Zhiguang Liu > ; Jian J Wang ; Xiaoyu = Lu > ; Guomin Jiang ; Gua Guo > ; Ard Biesheuvel ; Pedro Falcato > ; Gerd Hoffmann ; Marvin > H=C3=A4user > =E4=B8=BB=E9=A2=98: [PATCH v4 00/13] = BaseTools,CryptoPkg,EmulatorPkg,MdePkg,others: > Delete CLANG35,CLANG38,VS2008-2013,EBC, deprecate GCC48,GCC49,GCC5, > add GCC and GCCNOLTO, update CLANGDWARF >=20 > Update the toolchain definitions: >=20 > - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with > CLANGDWARF, updating it to support ARM and AARCH64 in addition to = X64 > and IA32. >=20 > - Mark GCC48, GCC49 and GCC5 as deprecated. >=20 > - Add GCC and GCCNOLTO toolchain definitions. >=20 > - Remove VS2008, VS2010, VS2012 and VS2013. >=20 > - Remove EBC compiler definitions. Full removal of EBC support from = the > various packages etc. will be done in a follow-up patch series. >=20 > - Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS > definitions. >=20 > - Remove unused CYGWIN_ definitions. >=20 > Personal GitHub PR: https://github.com/tianocore/edk2/pull/4240 > GitHub branch: https://github.com/bcran/edk2/tree/clangdwarf >=20 > Note: CI is now passing. >=20 > Changes from v1 to v2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > - Added a commit to delete GCC48 and GCC49, rename GCC5 to GCC and > update the flags for other toolchains to work with the new GCC > definitions. >=20 > - Bumped VERSION from 2.00 to 3.00 to inform users that they should > update their Conf/tools_def.txt. >=20 > Changes from v2 to v3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > - Keep GCC48, GCC49 and GCC5 but mark them deprecated, including with > warnings at the start and end of running a build. >=20 > - Dropped the commit fixing the IA32 build of UefiPayloadPkg, because = it > causes CI to fail due to building both IA32 and X64 at the same = time: >=20 > "Module built under multiple ARCHs [IA32, X64]. Not able to = determine > which output to put into flash for Module..." >=20 > - Added more information to the VERSION section in tools_def.template. >=20 > - Various fixes to the CLANGDWARF flags. >=20 > Changes from v3 to v4 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > - Use lld for -a ARM -t CLANGDWARF. >=20 > Rebecca Cran (13): > BaseTools,CryptoPkg: Update CLANGDWARF, remove CLANG 35/38 > toolchains > BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions > BaseTools: Remove VS2008-VS2013 remnants > MdePkg: Remove VS2008-VS2013 remnants > edksetup.bat: Remove VS2008-VS2013 remnants > BaseTools: Remove unused IPHONE_TOOLS and > SOURCERY_CYGWIN_TOOLS defs > BaseTools: Remove EBC (EFI Byte Code) compiler definitions > BaseTools: Update VS toolchain descriptions in = tools_def.txt.template > BaseTools/Conf/tools_def.template: Add GCC and GCCNOLTO toolchains > BaseTools: Only call LoadConfiguration once in build.py > BaseTools: Add a deprecation warning for GCC48,GCC49,GCC5 to = build.py > BaseTools/Conf/tools_def.template: Add section for deprecated > toolchains > BaseTools/Conf/tools_def.template: Bump VERSION to 3.00 >=20 > UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 > ++ > IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 9 > ++++++++- > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 > +-- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 = +-- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 = +-- > CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 = +-- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 > +-- > CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 = +-- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 3 > +-- > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 3 = +-- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 3 = +-- > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 3 = +-- > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 3 = +-- > EmulatorPkg/Unix/Host/Host.inf | > 2 ++ > MdePkg/Include/Ia32/ProcessorBind.h | > 8 ++------ > MdePkg/Include/X64/ProcessorBind.h | > 8 ++------ > BaseTools/Conf/tools_def.template | 1993 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > = ++++++++++++++++++++++++-------------------------------------------------= -------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = ----------------------------------------------------------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > = -------------------------------------------------------------------------= -------------------- > ----------------------------------------------------------- > --------------- > BaseTools/Scripts/SetVisualStudio.bat | 22 > +--------------------- > BaseTools/Scripts/ShowEnvironment.bat | 44 > -------------------------------------------- > BaseTools/Source/Python/build/build.py | 18 > +++++++++++++++--- > BaseTools/get_vsvars.bat | > 13 ------------- > BaseTools/set_vsprefix_envs.bat | 64 > ---------------------------------------------------------------- > BaseTools/toolsetup.bat | > 24 +----------------------- > edksetup.bat | > 6 +----- > 24 files changed, 627 insertions(+), 1619 deletions(-) >=20 > -- > 2.37.2