From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.30729.1578876975127465450 for ; Sun, 12 Jan 2020 16:56:15 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2020 16:56:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,427,1571727600"; d="scan'208";a="224774069" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2020 16:56:14 -0800 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 12 Jan 2020 16:56:14 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 13 Jan 2020 08:56:12 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Mon, 13 Jan 2020 08:56:12 +0800 From: "Liming Gao" To: "Ni, Ray" , "Kinney, Michael D" CC: "Dong, Eric" , "lersek@redhat.com" , "Fu, Siyuan" , "devel@edk2.groups.io" Subject: Re: [PATCH v2 1/2] MdePkg: Add header file for Firmware Interface Table specification. Thread-Topic: [PATCH v2 1/2] MdePkg: Add header file for Firmware Interface Table specification. Thread-Index: AQHVxpKAME/NfYozVE2MCfEtvKjLTafjOY/Q///4MoCABJbKYA== Date: Mon, 13 Jan 2020 00:56:12 +0000 Message-ID: <011bc7e52eb0425697e6733f52591530@intel.com> References: <22247fcc9c3a4f5fe237ff2e9ec289fb41ceb3ec.1578535686.git.siyuan.fu@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E58F6BF@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C3E871D@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C3E871D@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Ray: MdePkg has included Intel specific register. You can see MdePkg\Include\R= egister\Intel and MdePkg\Include\Register\AMD.=20 And, MdePkg also includes the vendor specific definition in MdePkg\Includ= e\IndustryStandard directory, such as Intel ServiceProcessorManagementInter= faceTable.h and Microsoft SerialPortConsoleRedirectionTable.h So, I think MdePkg allows to add vendor specific definition. Then, I give= my Review-By.=20 Thanks Liming -----Original Message----- From: Ni, Ray =20 Sent: 2020=1B$BG/=1B(B1=1B$B7n=1B(B10=1B$BF|=1B(B 18:41 To: Kinney, Michael D Cc: Dong, Eric ; lersek@redhat.com; Gao, Liming ; Fu, Siyuan ; devel@edk2.groups.io Subject: RE: [PATCH v2 1/2] MdePkg: Add header file for Firmware Interface = Table specification. Siyuan, FIT is Intel-only interface that's not consumed by other vendors. We may ne= ed to keep it in IntelSiliconPkg. I proposed this movement earlier in offline discussion with you but based o= n new discussion with Mike, I withdrew my proposal. Sorry about that! + Mike for additional comments. Thanks, Ray > -----Original Message----- > From: Gao, Liming > Sent: Friday, January 10, 2020 11:09 AM > To: Fu, Siyuan ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Dong, Eric=20 > ; Ni, Ray ; lersek@redhat.com > Subject: RE: [PATCH v2 1/2] MdePkg: Add header file for Firmware=20 > Interface Table specification. >=20 > Reviewed-by: Liming Gao >=20 > > -----Original Message----- > > From: Fu, Siyuan > > Sent: Thursday, January 9, 2020 10:14 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > > ; lersek@redhat.com > > Subject: [PATCH v2 1/2] MdePkg: Add header file for Firmware=20 > > Interface Table > specification. > > > > This patch add FirmwareInterfaceTable.h for the Firmware Interface=20 > > Table BIOS specification. > > > > This is to remove future edk2 dependency on edk2-platforms repo. The=20 > > file content comes from =20 > > edk2-platforms\Silicon\Intel\IntelSiliconPkg\Include\IndustryStandar > > d > > > > BZ link: https://tianocore.acgmultimedia.com/show_bug.cgi?id=3D2449 > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Signed-off-by: Siyuan Fu > > --- > > .../IndustryStandard/FirmwareInterfaceTable.h | 76=20 > > +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 > MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h > > > > diff --git=20 > > a/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h > b/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h > > new file mode 100644 > > index 0000000000..be3e34ae1b > > --- /dev/null > > +++ b/MdePkg/Include/IndustryStandard/FirmwareInterfaceTable.h > > @@ -0,0 +1,76 @@ > > +/** @file > > + Industry Standard Definitions of Firmware Interface Table BIOS=20 > > +Specification > 1.0. > > + > > + Copyright (c) 2016 - 2020, Intel Corporation. All rights=20 > > + reserved.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#ifndef __FIRMWARE_INTERFACE_TABLE_H__ #define=20 > > +__FIRMWARE_INTERFACE_TABLE_H__ > > + > > +// > > +// FIT Entry type definitions > > +// > > +#define FIT_TYPE_00_HEADER 0x00 > > +#define FIT_TYPE_01_MICROCODE 0x01 > > +#define FIT_TYPE_02_STARTUP_ACM 0x02 > > +#define FIT_TYPE_07_BIOS_STARTUP_MODULE 0x07 > > +#define FIT_TYPE_08_TPM_POLICY 0x08 > > +#define FIT_TYPE_09_BIOS_POLICY 0x09 > > +#define FIT_TYPE_0A_TXT_POLICY 0x0A > > +#define FIT_TYPE_0B_KEY_MANIFEST 0x0B > > +#define FIT_TYPE_0C_BOOT_POLICY_MANIFEST 0x0C > > +#define FIT_TYPE_10_CSE_SECURE_BOOT 0x10 > > +#define FIT_TYPE_2D_TXTSX_POLICY 0x2D > > +#define FIT_TYPE_2F_JMP_DEBUG_POLICY 0x2F > > +#define FIT_TYPE_7F_SKIP 0x7F > > + > > +#define FIT_POINTER_ADDRESS 0xFFFFFFC0 ///< Fixed addr= ess at 4G > - 40h > > + > > +#define FIT_TYPE_VERSION 0x0100 > > + > > +#define FIT_TYPE_00_SIGNATURE SIGNATURE_64 ('_', 'F', 'I', 'T',=20 > > +'_', ' ', ' ', ' ') > > + > > +#pragma pack(1) > > + > > +typedef struct { > > + // > > + // Address is the base address of the firmware component > > + // must be aligned on 16 byte boundary > > + // > > + UINT64 Address; > > + // > > + // Size is the span of the component in multiple of 16 bytes > > + // > > + UINT8 Size[3]; > > + // > > + // Reserved must be set to 0 > > + // > > + UINT8 Reserved; > > + // > > + // Component's version number in binary coded decimal (BCD) format. > > + // For the FIT header entry, the value in this field will=20 > > +indicate the revision > > + // number of the FIT data structure. The upper byte of the=20 > > +revision field > > + // indicates the major revision and the lower byte indicates the=20 > > +minor > revision. > > + // > > + UINT16 Version; > > + // > > + // FIT types 0x00 to 0x7F > > + // > > + UINT8 Type : 7; > > + // > > + // Checksum Valid indicates whether component has valid checksum. > > + // > > + UINT8 C_V : 1; > > + // > > + // Component's checksum. The modulo sum of all the bytes in the > component and > > + // the value in this field (Chksum) must add up to zero. This=20 > > +field is only > > + // valid if the C_V flag is non-zero. > > + // > > + UINT8 Chksum; > > +} FIRMWARE_INTERFACE_TABLE_ENTRY; > > + > > +#pragma pack() > > + > > +#endif > > -- > > 2.19.1.windows.1