From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 28185AC1786 for ; Wed, 16 Aug 2023 22:09:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wEQSktXYm9Ma0+tvY+Cx1WlJkg12w+tHIBmkftlJBtA=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692223770; v=1; b=CCDItBKitUAA8l4R1pxejhVZib3eZrOYrzfSfRSd+z1wBZ6DuoEwKNRXG2OvZ6bhh0+P8NSY HikoLQyIWFkrrtznrkSb61G80CJhaeo8rLO1+J+c42akEMEU0JqAs1yKj2annkc62g2+ZPpODFJ LJdTJ11eCDxB/B6xzX0VVrQ8= X-Received: by 127.0.0.2 with SMTP id iSgzYY7687511xFd5loJbIeL; Wed, 16 Aug 2023 15:09:30 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.173616.1692223770073892960 for ; Wed, 16 Aug 2023 15:09:30 -0700 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id E972B211F7A0; Wed, 16 Aug 2023 15:09:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E972B211F7A0 Message-ID: <011bf871-29c2-6e5d-378d-e5ffd5280945@linux.microsoft.com> Date: Wed, 16 Aug 2023 18:09:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 1/7] .pytool: Set uncrustify check to audit only (temporary) To: VivianNK , devel@edk2.groups.io Cc: Sean Brogan , Michael D Kinney , Liming Gao References: <20230816211523.12-1-vnowkakeane@linux.microsoft.com> <20230816211523.12-2-vnowkakeane@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: <20230816211523.12-2-vnowkakeane@linux.microsoft.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1Ert90uVZzWtt589FgWtfH7kx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CCDItBKi; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Michael Kubacki On 8/16/2023 5:15 PM, VivianNK wrote: > Temporarily set uncrustify to audit only mode so the following commits ca= n adjust the code for new formatting settings before those settings are app= lied. >=20 > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Vivian Nowka-Keane > --- > .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/= Plugin/UncrustifyCheck/UncrustifyCheck.py > index 8dc9ffe6945a..8978ffc443bf 100644 > --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py > @@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin): > """ >=20 > Initializes options that influence test case output. >=20 > """ >=20 > - self._audit_only_mode =3D False >=20 > + self._audit_only_mode =3D True >=20 > self._output_file_diffs =3D True >=20 > =20 >=20 > if "AuditOnly" in self._package_config and self._package_config= ["AuditOnly"]: >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107817): https://edk2.groups.io/g/devel/message/107817 Mute This Topic: https://groups.io/mt/100788666/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-