From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CB6B2941AB6 for ; Thu, 9 Nov 2023 13:51:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ITzLtxzsDZU9JoleeO3RBOx93q6XCdeYghapK94L7Ck=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1699537903; v=1; b=grmnAW7G6Mkja3I0Rz/5uoE+jPuO1gYlhYgK2eBgjlVxy/dIehOyxZh7Dj04onmu+yDReNoi nlQ/+g5PHg744jBS0hrt+1RSygiFCz0yVpnzJtKJMNDA3YxnB/0YkRumuCY12Jg7l+knZjmG6x4 FLSwLpDB1zzLUMftMtLbpDQ0= X-Received: by 127.0.0.2 with SMTP id EkcXYY7687511x92TMyCPB4m; Thu, 09 Nov 2023 05:51:43 -0800 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.121553.1699537902482757372 for ; Thu, 09 Nov 2023 05:51:43 -0800 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 10B54DDA792 for ; Thu, 9 Nov 2023 21:51:38 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 0C19DDDA78C for ; Thu, 9 Nov 2023 21:51:38 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 5A026DDA78A for ; Thu, 9 Nov 2023 21:51:35 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([124.133.49.51]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Thu, 09 Nov 2023 21:51:28 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 124.133.49.51 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Xu, Min M'" , "'Kinney, Michael D'" Cc: "'Aktas, Erdem'" , "'James Bottomley'" , "'Tom Lendacky'" , "'Michael Roth'" , "'Gerd Hoffmann'" , "'Yao, Jiewen'" , "'Sun, CepingX'" , References: <20231108083203.1417-1-cepingx.sun@intel.com> <20231108083203.1417-2-cepingx.sun@intel.com> In-Reply-To: Subject: =?UTF-8?B?W2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIIFYzIDEvMl0gTWRlUGtnL0Jhc2VMaWI6IFVwZGF0ZSBUZFZtY2FsbCB0byBhbHdheXMgb3V0cHV0IHRoZSB2YWx1ZSBpbiBSMTE=?= Date: Thu, 9 Nov 2023 21:51:30 +0800 Message-ID: <012001da1313$d8753fc0$895fbf40$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJPSaiiBGXwFLPV/7BrtyTBTk0OigEqJI3uAmEBn4avazsKwA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VNw5dnrJdPKlEyQYO5jjNQCBx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=grmnAW7G; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Xu, Min M > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA11=D4=C28=C8=D5 16:41 > =CA=D5=BC=FE=C8=CB: Gao, Liming ; Kinney, Micha= el D > > =B3=AD=CB=CD: Aktas, Erdem ; James Bottomley > ; Tom Lendacky ; > Michael Roth ; Gerd Hoffmann > ; Yao, Jiewen ; Sun, CepingX > ; devel@edk2.groups.io; Xu, Min M > > =D6=F7=CC=E2: RE: [PATCH V3 1/2] MdePkg/BaseLib: Update TdVmcall to alway= s > output the value in R11 >=20 > Hi, Liming & Miachel > Can you help to review this patch (because it is changed in MdePkg)? >=20 > Thanks! > Min >=20 > > -----Original Message----- > > From: Sun, CepingX > > Sent: Wednesday, November 8, 2023 4:32 PM > > To: devel@edk2.groups.io > > Cc: Sun, CepingX ; Gao, Liming > > ; Kinney, Michael D > > ; Aktas, Erdem ; > > James Bottomley ; Xu, Min M > ; > > Tom Lendacky ; Michael Roth > > ; Gerd Hoffmann ; Yao, > > Jiewen > > Subject: [PATCH V3 1/2] MdePkg/BaseLib: Update TdVmcall to always > output > > the value in R11 > > > > From: Ceping Sun > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4572 > > > > According to section 3.2 of the [GHCI] spec, if the return status of MapGPA is > > "TDG.VP.VMCALL_RETRY", TD must retry this operation for the pages in th= e > > region starting at the GPA specified in R11. > > > > Currently, TDVF has not handled the retry results and always clears the R11 > > on unsuccessful return status. For this, the TdVmcall needs to output the > > value of R11 on unsuccessful return status to handle the retry results of > > MapGPA. > > > > Reference: > > [GHCI]: TDX Guest-Host-Communication Interface v1.0 > > https://cdrdv2.intel.com/v1/dl/getContent/726790 > > > > Cc: Liming Gao > > Cc: Michael D Kinney > > Cc: Erdem Aktas > > Cc: James Bottomley > > Cc: Min Xu > > Cc: Tom Lendacky > > Cc: Michael Roth > > Acked-by: Gerd Hoffmann > > Reviewed-by: Jiewen Yao > > Signed-off-by: Ceping Sun > > --- > > MdePkg/Library/BaseLib/X64/TdVmcall.nasm | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/MdePkg/Library/BaseLib/X64/TdVmcall.nasm > > b/MdePkg/Library/BaseLib/X64/TdVmcall.nasm > > index 5ecc10b17193..8dd9bfcbfa14 100644 > > --- a/MdePkg/Library/BaseLib/X64/TdVmcall.nasm > > +++ b/MdePkg/Library/BaseLib/X64/TdVmcall.nasm > > @@ -133,9 +133,7 @@ ASM_PFX(TdVmCall): > > test r9, r9 > > jz .no_return_data > > > > - ; On success, propagate TDVMCALL output value to output param > > - test rax, rax > > - jnz .no_return_data > > + ; Propagate TDVMCALL output value to output param > > mov [r9], r11 > > .no_return_data: > > tdcall_regs_postamble > > -- > > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110980): https://edk2.groups.io/g/devel/message/110980 Mute This Topic: https://groups.io/mt/102485604/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-