From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web09.840.1657158710347742561 for ; Wed, 06 Jul 2022 18:51:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=rKEVYyRf; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id A0F5ACD1F674 for ; Thu, 7 Jul 2022 09:51:47 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1657158707; bh=3WgThBWjRfG2uHgKBf3MsCj8EZNe3D06MSw0a5K57V8=; h=From:To:References:In-Reply-To:Subject:Date; b=rKEVYyRf6Fyc8YZnUXkHAPynyxQsb0Hh8iLu+MXwd4gQ/UvDzg1gSy8E08X4JCCdp vXxpzgXe/4Mf2cJpo8h/r78QuwrHhRb0Eh9SqNvB2iMR5xyGy0hEGNRLsZ84+fOtYO X7JTrb1xbdPNZv9ihrrFn7pgWSUvpDIFiiuCSlwQ= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 9CFE7CD1F668 for ; Thu, 7 Jul 2022 09:51:47 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 5A499CD1F660 for ; Thu, 7 Jul 2022 09:51:47 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 16952CD1F76B for ; Thu, 7 Jul 2022 09:51:40 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 07 Jul 2022 09:51:33 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , References: <20220706095631.27196-2-sami.mujawar@arm.com> <26686.1657122254781859400@groups.io> In-Reply-To: <26686.1657122254781859400@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY0IDEvOF0gTWRlUGtnOiBJT1JUIGhlYWRlciB1cGRhdGUgZm9yIElPUlQgUmV2IEUuZCBzcGVj?= Date: Thu, 7 Jul 2022 09:51:36 +0800 Message-ID: <012701d891a4$18140960$483c1c20$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH8/6wEfArmRW/IJCimwMqJUZUB0wIVicjtrRia0SA= Sender: "gaoliming" Content-Type: multipart/alternative; boundary="----=_NextPart_000_0128_01D891E7.2637E5A0" Content-Language: zh-cn ------=_NextPart_000_0128_01D891E7.2637E5A0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sami: I suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can be E= FI_ACPI_IO_REMAPPING_TABLE_REV5, because the structure has been updated, su= ch as EFI_ACPI_6_0_IO_REMAPPING_RC_NODE.=20 =20 Compared to the previous version, EFI_ACPI_6_0_IO_REMAPPING_RC_NODE struct= is larger. Does this change bring any impact? =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Sami Mujawar =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=886=E6=97=A5 23:= 44 =E6=94=B6=E4=BB=B6=E4=BA=BA: Sami Mujawar ; devel@edk= 2.groups.io =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header upd= ate for IORT Rev E.d spec =20 On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote: -#define EFI_ACPI_IO_REMAPPING_TABLE_REVISION 0x0 +#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0 +#define EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5 Based on discussion at https://edk2.groups.io/g/devel/topic/patch_edk2_plat= forms_v2/92203690?p=3D,,,20,0,0,0::recentpostdate/sticky,,,20,2,0,92203690,= previd%3D1657121904386162709,nextid%3D1657101454237486469 &previd=3D1657121904386162709&nextid=3D1657101454237486469, the suggest= ion is to rename these macros to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 an= d EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05 respectively. I will wait for any other feedback on this series, before I send out the up= dated series reflecting the macro renaming. Regards, Sami Mujawar=20 ------=_NextPart_000_0128_01D891E7.2637E5A0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Sami:

=C2=A0I= suggest to keep EFI_ACPI_IO_REMAPPING_TABLE_REVISION. Its value can be EFI= _ACPI_IO_REMAPPING_TABLE_REV5, because the structure has been updated, such= as EFI_ACPI_6_0_IO_REMAPPING_RC_NODE.

 

=C2=A0Compar= ed to the previous version, EFI_ACPI_6_0_IO_REMAPPING_RC_NODE struct is lar= ger. Does this change bring any impact?

 

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> = =E4=BB= =A3=E8=A1=A8 Sami Mujawar
=E5=8F=91=E9=80=81=E6=97=B6=E9=97= =B4: 2022=E5=B9=B47=E6=9C=886=E6=97=A5 23:44=
=E6=94=B6=E4=BB=B6=E4=BA=BA: Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.grou= ps.io
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v4 1/8] MdePkg: IORT header update for= IORT Rev E.d spec

 

On Wed, Jul 6, 2022 at 02:57 AM, Sami Mujawar wrote:<= /o:p>

=

-#define EFI_ACPI_IO_REMAPPING_TABL= E_REVISION 0x0
+#define EFI_ACPI_IO_REMAPPING_TABLE_REV0 0x0
+#define= EFI_ACPI_IO_REMAPPING_TABLE_REV5 0x5

Based on discussion at https://edk2.groups.io/g/devel/t= opic/patch_edk2_platforms_v2/92203690?p=3D,,,20,0,0,0::recentpostdate/stick= y,,,20,2,0,92203690,previd%3D1657121904386162709,nextid%3D16571014542374864= 69&previd=3D1657121904386162709&nextid=3D1657101454237486469, t= he suggestion is to rename these macros to EFI_ACPI_IO_REMAPPING_TABLE_REVI= SION_00 and EFI_ACPI_IO_REMAPPING_TABLE_REVISION_05 respectively.
I will= wait for any other feedback on this series, before I send out the updated = series reflecting the macro renaming.

Regards,

Sami Mujawar <= o:p>

------=_NextPart_000_0128_01D891E7.2637E5A0--