public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Yunhua Feng'" <fengyunhua@byosoft.com.cn>, <devel@edk2.groups.io>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD
Date: Mon, 21 Dec 2020 09:37:14 +0800	[thread overview]
Message-ID: <012e01d6d739$cf7976c0$6e6c6440$@byosoft.com.cn> (raw)
In-Reply-To: <20201217010951.2098-1-fengyunhua@byosoft.com.cn>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Yunhua Feng <fengyunhua@byosoft.com.cn>
> 发送时间: 2020年12月17日 9:10
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 主题: [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero
> for static PCD
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3120
> FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN.
> Their PCD TOKEN value can always be zero.
> AutoGen.h will not be changed when static PCD is added or removed.
> Dynamic PCD add or remove will still cause dynamic PCD token value be
> changed.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Yunhua Feng <fengyunhua@byosoft.com.cn>
> ---
>  BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> index c001828937..7d8e7b3c7c 100644
> --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py
> @@ -1037,8 +1037,7 @@ class PlatformAutoGen(AutoGen):
>                  TokenNumber += 1
> 
>          for Pcd in self.NonDynamicPcdList:
> -            RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =
> TokenNumber
> -            TokenNumber += 1
> +            RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] = 0
>          return RetVal
> 
>      @cached_property
> --
> 2.27.0.windows.1




  parent reply	other threads:[~2020-12-21  1:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  1:09 [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD fengyunhua
2020-12-18  0:56 ` 回复: [edk2-devel] " gaoliming
2020-12-21  1:37 ` gaoliming [this message]
2020-12-21  1:48 ` Bob Feng
     [not found] ` <16529824D9BE42B5.13568@groups.io>
2020-12-23  2:07   ` [edk2-devel] " Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='012e01d6d739$cf7976c0$6e6c6440$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox