回复: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD

["gaoliming" <gaoliming@byosoft.com.cn>]

Daniel:
  We should try to keep single patch in one package. For this patch set, patch 3 depends on patch 2, every patch doesn't break the platform. So, I agree to keep them as the separate one. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Daniel
> Schaefer
> 发送时间: 2021年9月29日 7:11
> 收件人: Abner Chang <abner.chang@hpe.com>; devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>;
> Sami Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Sunil V L <sunilvl@ventanamicro.com>
> 主题: Re: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD
> 
> I think it would make sense to combine this patch with
> 3/9 ArmPkg: Use PcdPciIoTranslation PCD from MdePkg
> 
> It's pointless by itself.
> 
> On 9/28/21 16:31, Abner Chang wrote:
> > This PCD is moved from ArmPkg that is used to set the base address
> > of PCI MMIO window that provides I/O access. We relocate this PCD
> > because this PCD is common to ARM and RSIC-V arch.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > ---
> >  MdePkg/MdePkg.dec | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> > index a28a2daaff..08d259764a 100644
> > --- a/MdePkg/MdePkg.dec
> > +++ b/MdePkg/MdePkg.dec
> > @@ -2302,6 +2302,10 @@
> >    # @Prompt PCI Express Base Address.
> >
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000|UINT64
> |0x0000000a
> >
> > +  ## This value is used to set the base address of PCI MMIO window that
> provides I/O access.
> > +  # @Prompt PCI I/O Memory Map Window Base Address.
> > +
> gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x00000040
> > +
> >    ## This value is used to set the size of PCI express hierarchy. The
> default is 256 MB.
> >    # @Prompt PCI Express Base Size.
> >
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x10000000|UINT64|0x
> 0000000f
> >
> 
> 
> 
>