From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.3054.1632877829670846884 for ; Tue, 28 Sep 2021 18:10:35 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 29 Sep 2021 09:10:15 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Abner Chang'" Cc: "'Michael D Kinney'" , "'Zhiguang Liu'" , "'Ard Biesheuvel'" , "'Leif Lindholm'" , "'Sami Mujawar'" , "'Gerd Hoffmann'" , "'Sunil V L'" References: <20210928083107.7418-1-abner.chang@hpe.com> <20210928083107.7418-3-abner.chang@hpe.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYyIDIvOV0gTWRlUGtnOiBBZGQgUGNkUGNpSW9UcmFuc2xhdGlvbiBQQ0Q=?= Date: Wed, 29 Sep 2021 09:10:15 +0800 Message-ID: <013001d7b4ce$c35d1900$4a174b00$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHhj5a6n0zTGjPeRFpaUzM0aDy1yQIX1LovAZrNQ8qriOTq8A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Daniel: We should try to keep single patch in one package. For this patch set, pa= tch 3 depends on patch 2, every patch doesn't break the platform. So, I agr= ee to keep them as the separate one.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Daniel > Schaefer > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B49=E6=9C=8829=E6=97=A5 = 7:11 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Abner Chang ; devel@edk= 2.groups.io > =E6=8A=84=E9=80=81: Michael D Kinney ; Liming= Gao > ; Zhiguang Liu ; Ard > Biesheuvel ; Leif Lindholm = ; > Sami Mujawar ; Gerd Hoffmann > ; Sunil V L > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH V2 2/9] MdePkg: Add PcdPciIoT= ranslation PCD >=20 > I think it would make sense to combine this patch with > 3/9 ArmPkg: Use PcdPciIoTranslation PCD from MdePkg >=20 > It's pointless by itself. >=20 > On 9/28/21 16:31, Abner Chang wrote: > > This PCD is moved from ArmPkg that is used to set the base address > > of PCI MMIO window that provides I/O access. We relocate this PCD > > because this PCD is common to ARM and RSIC-V arch. > > > > Signed-off-by: Abner Chang > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Sami Mujawar > > Cc: Gerd Hoffmann > > Cc: Daniel Schaefer > > Cc: Sunil V L > > --- > > MdePkg/MdePkg.dec | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > > index a28a2daaff..08d259764a 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -2302,6 +2302,10 @@ > > # @Prompt PCI Express Base Address. > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000|UINT64 > |0x0000000a > > > > + ## This value is used to set the base address of PCI MMIO window tha= t > provides I/O access. > > + # @Prompt PCI I/O Memory Map Window Base Address. > > + > gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x0|UINT64|0x00000040 > > + > > ## This value is used to set the size of PCI express hierarchy. The > default is 256 MB. > > # @Prompt PCI Express Base Size. > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0x10000000|UINT64|0x > 0000000f > > >=20 >=20 >=20 >=20