From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.6441.1627036140009083761 for ; Fri, 23 Jul 2021 03:29:01 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 23 Jul 2021 18:28:54 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Cheng-Chieh Huang'" Cc: , "'Kinney, Michael D'" References: <20210721132328.1415485-1-chengchieh@google.com> <20210721132328.1415485-6-chengchieh@google.com> <000301d77e98$e1c0d9c0$a5428d40$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDUvNl0gVWVmaVBheWxvYWRQa2c6IEFkZCBESVNBQkxFX01NWF9TU0UgdG8gYXZvaWQgZ2VuZXJhdGluZyBmbG9hdGluZyBwb2ludHMgb3BlcmF0aW9u?= Date: Fri, 23 Jul 2021 18:28:57 +0800 Message-ID: <013201d77fad$8b3d7750$a1b865f0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI+d2iBu/gDct1ldzWMcca8HhaDTgFuoWO6Ad4b3ZcBaYRmPwGNgJjWAsDbw1+qOkbrYA== Content-Type: multipart/alternative; boundary="----=_NextPart_000_0133_01D77FF0.99623DF0" Content-Language: zh-cn ------=_NextPart_000_0133_01D77FF0.99623DF0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable How do you add this support in tools_def? Can you give the proposal for it? =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Cheng-Chieh Huang =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=8822=E6=97=A5 1= 0:35 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming =E6=8A=84=E9=80=81: devel@edk2.groups.io; Kinney, Michael D =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DI= SABLE_MMX_SSE to avoid generating floating points operation =20 I mean, I will submit a patch to support DISABLE_GCC_MMX_SSE in tools_def.= What do you think? =20 -- Cheng-Chieh =20 On Thu, Jul 22, 2021 at 9:28 AM gaoliming > wrote: Tools_def.txt doesn=E2=80=99t support build flag DISABLE_GCC_MMX_SSE. If t= his flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse= option will be the default GCC options. That means all platforms will appl= y them.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8= =A1=A8 Cheng-Chieh Huang via groups.io =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=8822=E6=97=A5 1= :43 =E6=94=B6=E4=BB=B6=E4=BA=BA: Kinney, Michael D > =E6=8A=84=E9=80=81: devel@edk2.groups.io =20 =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DI= SABLE_MMX_SSE to avoid generating floating points operation =20 Yes, we can. I will drop this patch for this uefipayload batch and send a= nother one for support DISABLE_GCC_MMX_SSE in tools_de.txt. =20 -- Cheng-Chieh=20 On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D > wrote: Are those flags needed for all packages that build with GCC? Should this be moved into tools_def.txt? Mike > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Cheng-Chieh Huang via = groups.io =20 > Sent: Wednesday, July 21, 2021 6:23 AM > To: devel@edk2.groups.io =20 > Cc: Cheng-Chieh Huang > > Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE= to avoid generating floating points operation >=20 > This will allow we compile payload using gcc8 >=20 > Signed-off-by: Cheng-Chieh Huang > > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayl= oadPkg.dsc > index 8aa5f18cd35c..fa41c5a24af5 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -30,6 +30,8 @@ [Defines] > DEFINE PS2_KEYBOARD_ENABLE =3D FALSE > DEFINE UNIVERSAL_PAYLOAD =3D FALSE >=20 > + DEFINE DISABLE_MMX_SSE =3D FALSE > + > # > # SBL: UEFI payload for Slim Bootloader > # COREBOOT: UEFI payload for coreboot > @@ -96,6 +98,9 @@ [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFAC= ES > !if $(BOOTLOADER) =3D=3D "LINUXBOOT" > *_*_*_CC_FLAGS =3D -D LINUXBOOT_PAYLOAD > +!endif > +!if $(DISABLE_MMX_SSE) > + *_*_*_CC_FLAGS =3D -mno-mmx -mno-sse > !endif > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > -- > 2.32.0.402.g57bb445576-goog >=20 >=20 >=20 >=20 >=20 ------=_NextPart_000_0133_01D77FF0.99623DF0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

How do you add this support in tools_def? Can you give= the proposal for it?

&n= bsp;

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA:<= span lang=3DEN-US style=3D'font-size:11.0pt;font-family:=E7=AD=89=E7=BA=BF'= > Cheng-Chieh Huang <chengchieh@google.com>
=E5=8F=91=E9=80=81=E6= = =97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=8822=E6=97=A5 10:35
=E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming <gaoliming@byosoft.com.cn>=
=E6=8A=84=E9=80=81: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@int= el.com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISAB= LE_MMX_SSE to avoid generating floating points operation<= /span>

 

I mean, I will = submit a patch to support DISABLE_GCC_MMX_SSE in tools_def. What do you thi= nk?

=  

-= -

C= heng-Chieh

 

On Thu, Jul 22, 2021 at 9:28 AM gaoliming <gaoliming@byosoft.com.cn> wrote:

Tools_def.txt doesn=E2=80=99t support buil= d flag DISABLE_GCC_MMX_SSE. If this flag i= s moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse option wi= ll be the default GCC options. That means all platforms will apply them.

 

<= p class=3DMsoNormal style=3D'mso-margin-top-alt:auto;mso-margin-bottom-alt:= auto'>Thanks

Liming

=E5=8F=91=E4=BB=B6=E4= = =BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4= =BB=A3=E8=A1=A8 Cheng-Chieh Huang via groups.io
=E5=8F=91=E9=80=81=E6=97=B6=E9=97= =B4: 2021=E5=B9=B47<= /span>=E6=9C=8822=E6=97=A5 1:4= 3
=E6=94=B6=E4=BB=B6=E4=BA=BA: Kinney, Michael D <michael.d.kinney@intel.com>
<= b>=E6=8A=84=E9=80=81: devel@edk2.groups.io<= /a>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_= SSE to avoid generating floating points operation

 = ;

=

 

--

Cheng-Chieh 

Are = those flags needed for all packages that build with GCC?

Should this= be moved into tools_def.txt?

Mike

> -----Original Message= -----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Cheng-Chieh Huang = via groups.io
> Se= nt: Wednesday, July 21, 2021 6:23 AM
> To: devel@edk2.groups.io
> Cc: Cheng-= Chieh Huang <= chengchieh@google.com>
> Subject: [edk2-devel] [PATCH v1 5/6] = UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points ope= ration
>
> This will allow we compile payload using gcc8
&g= t;
> Signed-off-by: Cheng-Chieh Huang <chengchieh@google.com>
> ---<= br>>  UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++
>  1 f= ile changed, 5 insertions(+)
>
> diff --git a/UefiPayloadPkg/U= efiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 8aa5f18= cd35c..fa41c5a24af5 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc<= br>> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -30,6 +30,8 @@ [= Defines]
>    DEFINE PS2_KEYBOARD_ENABLE     = ;     =3D FALSE
>    DEFINE UNIVERSAL_PAYLOAD&nbs= p;           =3D FALSE
>
> +  DE= FINE DISABLE_MMX_SSE              =3D FA= LSE
> +
>    #
>    # SBL:  &nbs= p;   UEFI payload for Slim Bootloader
>    # COREBOOT:= UEFI payload for coreboot
> @@ -96,6 +98,9 @@ [BuildOptions]
>=     *_*_*_CC_FLAGS             = ;    =3D -D DISABLE_NEW_DEPRECATED_INTERFACES
>  !if $= (BOOTLOADER) =3D=3D "LINUXBOOT"
>    *_*_*_CC_FLA= GS                 =3D -D LINU= XBOOT_PAYLOAD
> +!endif
> +!if $(DISABLE_MMX_SSE)
> +&nbs= p; *_*_*_CC_FLAGS                &n= bsp;=3D -mno-mmx -mno-sse
>  !endif
>    GCC:*_U= NIXGCC_*_CC_FLAGS       =3D -DMDEPKG_NDEBUG
>&nbs= p;   GCC:RELEASE_*_*_CC_FLAGS       =3D -DMDEPKG_N= DEBUG
> --
> 2.32.0.402.g57bb445576-goog
>
>
&= gt;
>
>

=

------=_NextPart_000_0133_01D77FF0.99623DF0--