From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 691B3740039 for ; Mon, 15 Apr 2024 06:35:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ALFZIXXn5bWUKD5i+eJv1ATXO2uKSlB719SXSTMnHUM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1713162933; v=1; b=tEa6Du1QvGC/2m68oScpyLDD83/voCjjB73dj6eqeVMh+OySJrsNu3gK7UH4yydY1+DUzNbi 3weiY+Mr7fi2eE5nNZey4s1O4MqqyzuwUxCamcVVh4KOSJ/rIuwjHUDA42kTRvJFddhAuYnKpLU EdHWtTtZ4fJpF7EDbeTIkFTXN+V9W49lsWZVFixSjFiGvyUnjN2W6zkLWT3IlugHYxWenTalecI p7twzGpRav/tkzZmwK1ow4z6hPpBebXMBtm1gs8yZpOPE29ix2vykk8VVDyPv3ihIBRmXa9377p pNyhwZrUUTcd5Mj2EmOoW0ODXTEAkCzXlF9jTwmMfCTcw== X-Received: by 127.0.0.2 with SMTP id bhwKYY7687511xClsE13mMF6; Sun, 14 Apr 2024 23:35:33 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.15002.1713162932102341113 for ; Sun, 14 Apr 2024 23:35:32 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id C91FEA32E0BF for ; Mon, 15 Apr 2024 14:35:29 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id B5D16A32E12A for ; Mon, 15 Apr 2024 14:35:29 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 96FA5A32E0D0 for ; Mon, 15 Apr 2024 14:35:26 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 15 Apr 2024 14:35:25 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Cai, Xianglei'" , "'Ni, Ray'" Cc: "'Huang, Jenny'" , "'Shih, More'" , , "'Lewandowski, Krzysztof'" , "'Lewandowski, Krzysztof'" References: <2ef49d5cd3593dc573f3fac9db533b4a93ef04b5.1710220024.git.xianglei.cai@intel.com> <00fc01da8ef4$ff8b61e0$fea225a0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?W2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIIDEvMV0gTWRlTW9kdWxlUGtnL1hoY2lEeGU6IFJlc2V0IGVuZHBvaW50IHdoaWxlIFVTQiBUcmFuc2FjdGlvbiBlcnJvcg==?= Date: Mon, 15 Apr 2024 14:35:26 +0800 Message-ID: <013701da8eff$1a495870$4edc0950$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQI9SsNl3R3G6bbr8WVwYBBSIeW2HAEwbmQQAdj88CgCxca0AgIMzVvVAZ03VXoBRdRBnrBNb71w Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 14 Apr 2024 23:35:32 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5npmMkKp9eGDC3NVKF2bGiXFx7686176AA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0138_01DA8F42.286EE260" Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=tEa6Du1Q; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io ------=_NextPart_000_0138_01DA8F42.286EE260 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Xianglei: I understand this issue now. I suggest to add the internal definition in = XhciDxe module for transaction error type, such as EDKII_USB_ERR_TRANSACTIO= N. It can avoid the change in UEFI UsbIo protocol. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Cai, Xianglei =20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8815=E6=97=A5 13= :27 =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; Ni, Ray = =E6=8A=84=E9=80=81: Huang, Jenny ; Shih, More ; devel@edk2.groups.io; Lewandowski, Krzysztof ; Lewandowski, Krzysztof =E4=B8=BB=E9=A2=98: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint wh= ile USB Transaction error =20 Hi Liming, =20 But we met some issues that system will stuck for 5-7 minutes because of US= B transaction error with some USB device. And check the XHCI spec, it shows need reset endpoint when USB transaction. =20 Thanks, Xianglei =20 From: gaoliming = >=20 Sent: Monday, April 15, 2024 1:23 PM To: Ni, Ray > Cc: Huang, Jenny >; S= hih, More >; devel@edk2.g= roups.io ; Lewandowski, Krzysztof >; Cai, Xian= glei >; Lewandowski= , Krzysztof > Subject: =E5=9B=9E=E5=A4=8D: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoi= nt while USB Transaction error =20 Xianglei: Now, UEFI spec doesn=E2=80=99t define EFI_USB_ERR_TRANSACTION. So, we can= =E2=80=99t update UsbIo.h now.=20 =20 EFI_USB_ERR_TRANSACTION is only used in XhciDxe for error condition check= . I suggest to add comments for current code, don=E2=80=99t need code updat= e.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: Ni, Ray >=20 =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8815=E6=97=A5 10= :17 =E6=94=B6=E4=BB=B6=E4=BA=BA: Liming Gao > =E6=8A=84=E9=80=81: Huang, Jenny >; Shih, More = >; devel@edk2.groups.io ; Lewandowski, Krzys= ztof >; Cai, Xianglei >; Lewandowski, Krzysztof > =E4=B8=BB=E9=A2=98: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint wh= ile USB Transaction error =20 Liming, Can you give a R-B? =20 Thanks, Ray _____ =20 From: Cai, Xianglei = > Sent: Friday, April 12, 2024 9:53 To: Lewandowski, Krzysztof >; devel@edk2.groups.io >; Ni, Ray >; Liming Gao > Cc: Huang, Jenny >; S= hih, More > Subject: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Tra= nsaction error=20 =20 @Ni, Ray @Lim= ing GaoWould you like to merge the patch to upstream? =20 Thanks, Xianglei =20 From: Lewandowski, Krzysztof >=20 Sent: Thursday, April 11, 2024 9:45 PM To: devel@edk2.groups.io =20 Cc: Ni, Ray >; Liming Gao >; Huang, Jenny >; Shih, More >; Cai, Xianglei > Subject: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Tra= nsaction error =20 Looks good to me. Reviewed-by: Krzysztof Lewandowski > _____ =20 From: Cai, Xianglei = > Sent: Wednesday, April 10, 2024 09:02 To: devel@edk2.groups.io > Cc: Cai, Xianglei >= ; Ni, Ray >; Liming Gao >; Lewandowski, Krzysz= tof >; Huang, Jenny >;= Shih, More > Subject: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transac= tion error=20 =20 https://bugzilla.tianocore.org/show_bug.cgi?id=3D4556 Based on XHCI spec 4.8.3, software should do the reset endpoint while USB Transaction occur. Also add the error code for USB Transaction error since UEFI spec don't have the related definition. Cc: Ray Ni > Cc: Liming Gao > Cc: Krzysztof Lewandowski > Cc: Jenny Huang > Cc: More Shih > Signed-off-by: Xianglei Cai > --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 2 +- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 2 +- MdePkg/Include/Protocol/UsbIo.h | 21 +++++++++++---------- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c b/MdeModulePkg/Bus/Pci/Xhc= iDxe/Xhci.c index f4e61d223c1b..63cc29b26536 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c @@ -825,7 +825,7 @@ XhcTransfer ( *TransferResult =3D Urb->Result; *DataLength =3D Urb->Completed; =20 - if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D= =3D EFI_USB_ERR_BABBLE)) { + if ((*TransferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D= =3D EFI_USB_ERR_BABBLE) || (*TransferResult =3D=3D EFI_USB_ERR_TRANSACTION)= ) { ASSERT (Status =3D=3D EFI_DEVICE_ERROR); RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, Urb); if (EFI_ERROR (RecoveryStatus)) { diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c index 05528a478baf..e77852f62f10 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c @@ -1193,7 +1193,7 @@ XhcCheckUrbResult ( goto EXIT; =20 case TRB_COMPLETION_USB_TRANSACTION_ERROR: - CheckedUrb->Result |=3D EFI_USB_ERR_TIMEOUT; + CheckedUrb->Result |=3D EFI_USB_ERR_TRANSACTION; CheckedUrb->Finished =3D TRUE; DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: TRANSACTION_ERROR! Comple= tecode =3D %x\n", EvtTrb->Completecode)); goto EXIT; diff --git a/MdePkg/Include/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbI= o.h index a780b4e07b44..211ef0c94156 100644 --- a/MdePkg/Include/Protocol/UsbIo.h +++ b/MdePkg/Include/Protocol/UsbIo.h @@ -50,16 +50,17 @@ typedef enum { // // USB Transfer Results // -#define EFI_USB_NOERROR 0x00 -#define EFI_USB_ERR_NOTEXECUTE 0x01 -#define EFI_USB_ERR_STALL 0x02 -#define EFI_USB_ERR_BUFFER 0x04 -#define EFI_USB_ERR_BABBLE 0x08 -#define EFI_USB_ERR_NAK 0x10 -#define EFI_USB_ERR_CRC 0x20 -#define EFI_USB_ERR_TIMEOUT 0x40 -#define EFI_USB_ERR_BITSTUFF 0x80 -#define EFI_USB_ERR_SYSTEM 0x100 +#define EFI_USB_NOERROR 0x00 +#define EFI_USB_ERR_NOTEXECUTE 0x01 +#define EFI_USB_ERR_STALL 0x02 +#define EFI_USB_ERR_BUFFER 0x04 +#define EFI_USB_ERR_BABBLE 0x08 +#define EFI_USB_ERR_NAK 0x10 +#define EFI_USB_ERR_CRC 0x20 +#define EFI_USB_ERR_TIMEOUT 0x40 +#define EFI_USB_ERR_BITSTUFF 0x80 +#define EFI_USB_ERR_SYSTEM 0x100 +#define EFI_USB_ERR_TRANSACTION 0x200 =20 /** Async USB transfer callback routine. --=20 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117759): https://edk2.groups.io/g/devel/message/117759 Mute This Topic: https://groups.io/mt/105531088/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- ------=_NextPart_000_0138_01DA8F42.286EE260 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Xianglei:

=C2=A0 I understand this issue now. I sugge= st to add the internal definition in XhciDxe module for transaction error t= ype, such as EDKII_USB_ERR_TRANSACTION. It can avoid the change in UEFI Usb= Io protocol.

<= o:p> 

Thanks

Liming=

=E5=8F=91=E4=BB=B6=E4=BA=BA: Cai, Xianglei <xianglei.cai@intel.com>
<= span style=3D'font-family:=E7=AD=89=E7=BA=BF'>=E5=8F=91=E9=80=81=E6=97=B6= =E9=97=B4: 2024=E5=B9=B44=E6=9C=8815=E6=97=A5 13:27
=E6=94=B6=E4= =BB=B6=E4=BA=BA: gaoliming= <gaoliming@byosoft.com.cn>; Ni, Ray <ray.ni@intel.com>
=E6=8A=84=E9=80=81: = Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.= com>; devel@edk2.groups.io; Lewandowski, Krzysztof <krzysztof.lewando= wski@intel.com>; Lewandowski, Krzysztof <krzysztof.lewandowski@intel.= com>
=E4=B8=BB=E9=A2=98: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while U= SB Transaction error

 

= Hi Liming,

 

But we met some issues that system will stuck for 5-7 minutes beca= use of USB transaction error with some USB device.

And check the XHCI spec, it shows need= reset endpoint when USB transaction.

 

Thanks,

Xianglei

 

From: gaoliming <gaoliming@byosoft.com.cn>
<= b>Sent: Monday, April 15, 2024 1:23 PM
To: Ni, Ray <ray.ni@intel.com>
Cc: Huang,= Jenny <jenny.huang@intel.com>; Shih, More <more.shih@int= el.com>; devel@edk2.groups.i= o; Lewandowski, Krzysztof <krzysztof.lewandowski@intel.com>; Cai, Xianglei <xianglei.cai@intel.com>; Lewando= wski, Krzysztof <krzy= sztof.lewandowski@intel.com>
Subject: =E5=9B=9E=E5=A4=8D: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Transacti= on error

 

Xianglei:

  N= ow, UEFI spec doesn=E2=80=99t define EFI_USB_ERR_TRANSACTI= ON. So, we can=E2=80=99t update UsbIo.h now.

&= nbsp;

<= span lang=3DEN-US style=3D'font-size:10.5pt;font-family:=E7=AD=89=E7=BA=BF'= >  EFI_USB_ERR_TRANSACTION is only used in XhciDxe for error condition= check. I suggest to add comments for current code, don=E2=80=99t need code update.

 

Thanks<= /span>

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA= : Ni, Ray <ray.ni@intel.com&= gt;
=E5=8F=91= =E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6= =9C=8815=E6=97=A5 10:17
=E6=94=B6=E4=BB=B6=E4=BA=BA: Liming Gao <gaolim= ing@byosoft.com.cn>
=E6=8A=84=E9=80=81: Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>; devel@edk2.groups.io; Lewandowski, Krzysztof <<= a href=3D"mailto:krzysztof.lewandowski@intel.com">krzysztof.lewandowski@int= el.com>; Cai, Xianglei <xianglei.cai@intel.com>; Lewandowski, Krzysztof <krzysztof.lewandowski@intel.com>=
=E4=B8=BB=E9=A2=98: Re: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while USB Tr= ansaction error

 

=

Liming,<= /p>

Can you give a R-B?

 

Thanks,

Ray

From: Cai, Xiang= lei <xianglei.cai@intel.com>
Sent: Friday, April 12, 2024 9:53
To: Lewandowski= , Krzysztof <krzyszto= f.lewandowski@intel.com>; de= vel@edk2.groups.io <devel@ed= k2.groups.io>; Ni, Ray <ray.n= i@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
Cc: Huang, Jenny <jenny.huang@intel.com>; Shih, Mor= e <more.shih@intel.com>Subject: RE: [PATCH 1/1] MdeModulePkg/XhciDxe: Reset endpoint while= USB Transaction error

 

=

@Ni, Ray= @Liming GaoWould you like to merge the patch to upstream= ?

 =

Thanks,

Xianglei

 

From: Lewandowski, Krzysztof <krzysztof.lewandowski@intel.com>
Sent= : Thursday, April 11, 2024 9:45 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; H= uang, Jenny <jenny.huang@intel.= com>; Shih, More <more.shi= h@intel.com>; Cai, Xianglei <xianglei.cai@intel.com>
Subject: Re: [PATCH 1/1] Mde= ModulePkg/XhciDxe: Reset endpoint while USB Transaction error

 

Looks good to me.

Reviewed-b= y: Krzysztof Lewandowski <krzysztof.lewandowski@intel.com>=

=

From: Cai, Xianglei <= xianglei.cai@intel.com>
Sent: Wednesday, April 10, 2024 09= :02
To: devel@edk2.groups= .io <devel@edk2.groups.io>
Cc: Cai, Xianglei <xianglei.cai@intel.com>; Ni, Ray <ray.ni@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Lewandowski, Krzyszto= f <krzysztof.lewandow= ski@intel.com>; Huang, Jenny <jenny.huang@intel.com>; Shih, More <more.shih@intel.com>
Subject: [PATCH 1/1] = MdeModulePkg/XhciDxe: Reset endpoint while USB Transaction error

 

https://bugzilla.tianocore.o= rg/show_bug.cgi?id=3D4556

Based on XHCI spec 4.8.3, software sho= uld do the
reset endpoint while USB Transaction occur.
Also add the e= rror code for USB Transaction error
since UEFI spec don't have the relat= ed definition.

Cc: Ray Ni       &= nbsp;           &nbs= p;            <ray.ni@intel.com>
Cc: Liming Ga= o            &n= bsp;            = ;   <gaoliming@byo= soft.com.cn>
Cc: Krzysztof Lewandowski    <krzysztof.lewandowski@intel.= com>
Cc: Jenny Huang       &nb= sp;            =        <jenny.huang@intel.com>
Cc: More Shih   &nbs= p;            &= nbsp;            <= ;more.shih@intel.com>

= Signed-off-by: Xianglei Cai <x= ianglei.cai@intel.com>
---
 MdeModulePkg/Bus/Pci/XhciDxe/= Xhci.c      |  2 +-
 MdeModulePkg/Bus= /Pci/XhciDxe/XhciSched.c |  2 +-
 MdePkg/Include/Protocol/UsbI= o.h          | 21 +++++++++++-= ---------
 3 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c b/MdeModulePkg/Bus/Pci/X= hciDxe/Xhci.c
index f4e61d223c1b..63cc29b26536 100644
--- a/MdeModule= Pkg/Bus/Pci/XhciDxe/Xhci.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c
= @@ -825,7 +825,7 @@ XhcTransfer (
   *TransferResult =3D Urb-&= gt;Result;
   *DataLength     =3D Urb->= Completed;
 
-  if ((*TransferResult =3D=3D EFI_USB_ERR_STA= LL) || (*TransferResult =3D=3D EFI_USB_ERR_BABBLE)) {
+  if ((*Tran= sferResult =3D=3D EFI_USB_ERR_STALL) || (*TransferResult =3D=3D EFI_USB_ERR= _BABBLE) || (*TransferResult =3D=3D EFI_USB_ERR_TRANSACTION)) {
 &n= bsp;   ASSERT (Status =3D=3D EFI_DEVICE_ERROR);
  &n= bsp;  RecoveryStatus =3D XhcRecoverHaltedEndpoint (Xhc, Urb);
 = ;    if (EFI_ERROR (RecoveryStatus)) {
diff --git a/MdeMo= dulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSche= d.c
index 05528a478baf..e77852f62f10 100644
--- a/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
= @@ -1193,7 +1193,7 @@ XhcCheckUrbResult (
     =     goto EXIT;
 
     &n= bsp; case TRB_COMPLETION_USB_TRANSACTION_ERROR:
-    = ;    CheckedUrb->Result  |=3D EFI_USB_ERR_TIMEOUT;+        CheckedUrb->Result  |= =3D EFI_USB_ERR_TRANSACTION;
       &= nbsp; CheckedUrb->Finished =3D TRUE;
     &n= bsp;   DEBUG ((DEBUG_ERROR, "XhcCheckUrbResult: TRANSACTION_= ERROR! Completecode =3D %x\n", EvtTrb->Completecode));
 &nb= sp;       goto EXIT;
diff --git a/MdePkg/I= nclude/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbIo.h
index a780b4e0= 7b44..211ef0c94156 100644
--- a/MdePkg/Include/Protocol/UsbIo.h
+++ b= /MdePkg/Include/Protocol/UsbIo.h
@@ -50,16 +50,17 @@ typedef enum {
&= nbsp;//
 // USB Transfer Results
 //
-#define EFI_USB_NO= ERROR         0x00
-#define EFI_= USB_ERR_NOTEXECUTE  0x01
-#define EFI_USB_ERR_STALL  &nbs= p;    0x02
-#define EFI_USB_ERR_BUFFER   &= nbsp;  0x04
-#define EFI_USB_ERR_BABBLE    &nbs= p; 0x08
-#define EFI_USB_ERR_NAK      &nbs= p;  0x10
-#define EFI_USB_ERR_CRC     &nbs= p;   0x20
-#define EFI_USB_ERR_TIMEOUT    = 0x40
-#define EFI_USB_ERR_BITSTUFF    0x80
-#define E= FI_USB_ERR_SYSTEM      0x100
+#define EFI_USB_N= OERROR          0x00
+#defi= ne EFI_USB_ERR_NOTEXECUTE   0x01
+#define EFI_USB_ERR_STALL&nb= sp;       0x02
+#define EFI_USB_ERR_BUFFER=        0x04
+#define EFI_USB_ERR_BABBLE&nb= sp;      0x08
+#define EFI_USB_ERR_NAK &nb= sp;        0x10
+#define EFI_USB_ERR_= CRC          0x20
+#define = EFI_USB_ERR_TIMEOUT      0x40
+#define EFI_USB_= ERR_BITSTUFF     0x80
+#define EFI_USB_ERR_SYSTEM&nb= sp;      0x100
+#define EFI_USB_ERR_TRANSACTION=   0x200
 
 /**
   Async USB transfer call= back routine.
--
2.42.0.windows.2

<= /div>
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117759) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
------=_NextPart_000_0138_01DA8F42.286EE260--