From: "Chao Li" <lichao@loongson.cn>
To: devel@edk2.groups.io, andrei.warkentin@intel.com
Cc: "Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Sami Mujawar <sami.mujawar@arm.com>,
Sunil V L <sunilvl@ventanamicro.com>,
Tuan Phan <tphan@ventanamicro.com>
Subject: Re: [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg
Date: Mon, 20 Nov 2023 11:26:21 +0800 [thread overview]
Message-ID: <01436801-9a8d-46ec-9c0f-e85051340fc5@loongson.cn> (raw)
In-Reply-To: <PH8PR11MB68562D9A4167451E24EB3FD183B7A@PH8PR11MB6856.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 8944 bytes --]
Hi Anderi,
There are indeed typos and I will fix them in V4. Thank you!
Thanks,
Chao
On 2023/11/18 04:18, Andrei Warkentin wrote:
> +Tuan as a heads-up.
>
> This seems reasonable to me. What does the "Uint" mean in ConfigureMemoryManagementUint?
>
> Did you intend to say "Unit"?
>
> Reviewed-by: Andrei Warkentin<andrei.warkentin@intel.com>
>
>> -----Original Message-----
>> From: Chao Li<lichao@loongson.cn>
>> Sent: Friday, November 17, 2023 4:00 AM
>> To:devel@edk2.groups.io
>> Cc: Dong, Eric<eric.dong@intel.com>; Ni, Ray<ray.ni@intel.com>; Kumar,
>> Rahul R<rahul.r.kumar@intel.com>; Gerd Hoffmann<kraxel@redhat.com>;
>> Leif Lindholm<quic_llindhol@quicinc.com>; Ard Biesheuvel
>> <ardb+tianocore@kernel.org>; Sami Mujawar<sami.mujawar@arm.com>;
>> Sunil V L<sunilvl@ventanamicro.com>; Warkentin, Andrei
>> <andrei.warkentin@intel.com>
>> Subject: [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg
>>
>> Add a new header file CpuMmuLib.h, whitch is referenced from
>> ArmPkg/Include/Library/ArmMmuLib.h. Currently, only support for
>> LoongArch64 is added, and more architectures can be accommodated in the
>> future.
>>
>> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4584
>>
>> Cc: Eric Dong<eric.dong@intel.com>
>> Cc: Ray Ni<ray.ni@intel.com>
>> Cc: Rahul Kumar<rahul1.kumar@intel.com>
>> Cc: Gerd Hoffmann<kraxel@redhat.com>
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar<sami.mujawar@arm.com>
>> Cc: Sunil V L<sunilvl@ventanamicro.com>
>> Cc: Andrei Warkentin<andrei.warkentin@intel.com>
>> Signed-off-by: Chao Li<lichao@loongson.cn>
>> ---
>> UefiCpuPkg/Include/Library/CpuMmuLib.h | 155
>> +++++++++++++++++++++++++
>> UefiCpuPkg/UefiCpuPkg.dec | 4 +
>> 2 files changed, 159 insertions(+)
>> create mode 100644 UefiCpuPkg/Include/Library/CpuMmuLib.h
>>
>> diff --git a/UefiCpuPkg/Include/Library/CpuMmuLib.h
>> b/UefiCpuPkg/Include/Library/CpuMmuLib.h
>> new file mode 100644
>> index 0000000000..23b2fe34ac
>> --- /dev/null
>> +++ b/UefiCpuPkg/Include/Library/CpuMmuLib.h
>> @@ -0,0 +1,155 @@
>> +/** @file
>> +
>> + Copyright (c) 2023 Loongson Technology Corporation Limited. All
>> + rights reserved.<BR>
>> +
>> + SPDX-License-Identifier: BSD-2-Clause-Patent
>> +
>> +**/
>> +
>> +#ifndef CPU_MMU_LIB_H_
>> +#define CPU_MMU_LIB_H_
>> +
>> +#include <Uefi/UefiBaseType.h>
>> +
>> +#define EFI_MEMORY_CACHETYPE_MASK (EFI_MEMORY_UC | \
>> + EFI_MEMORY_WC | \
>> + EFI_MEMORY_WT | \
>> + EFI_MEMORY_WB | \
>> + EFI_MEMORY_UCE \
>> + )
>> +
>> +typedef struct {
>> + EFI_PHYSICAL_ADDRESS PhysicalBase;
>> + EFI_VIRTUAL_ADDRESS VirtualBase;
>> + UINTN Length;
>> + UINTN Attributes;
>> +} MEMORY_REGION_DESCRIPTOR;
>> +
>> +/**
>> + Converts EFI Attributes to corresponding architecture Attributes.
>> +
>> + @param[in] EfiAttributes Efi Attributes.
>> +
>> + @retval Corresponding architecture attributes.
>> +**/
>> +UINTN
>> +EfiAttributeConverse (
>> + IN UINTN EfiAttributes
>> + );
>> +
>> +/**
>> + Finds the length and memory properties of the memory region
>> corresponding to the specified base address.
>> +
>> + @param[in] BaseAddress To find the base address of the memory
>> region.
>> + @param[in] EndAddress To find the end address of the memory region.
>> + @param[out] RegionLength The length of the memory region found.
>> + @param[out] RegionAttributes Properties of the memory region found.
>> +
>> + @retval EFI_SUCCESS The corresponding memory area was successfully
>> found
>> + EFI_NOT_FOUND No memory area found
>> +**/
>> +EFI_STATUS
>> +GetMemoryRegionAttribute (
>> + IN UINTN BaseAddress,
>> + IN UINTN EndAddress,
>> + OUT UINTN *RegionLength,
>> + OUT UINTN *RegionAttributes
>> + );
>> +
>> +/**
>> + Sets the Attributes of the specified memory region
>> +
>> + @param[in] BaseAddress The base address of the memory region to set
>> the Attributes.
>> + @param[in] Length The length of the memory region to set the
>> Attributes.
>> + @param[in] Attributes The Attributes to be set.
>> + @param[in] AttributeMask Mask of memory attributes to take into
>> account.
>> +
>> + @retval EFI_SUCCESS The Attributes was set successfully
>> +**/
>> +EFI_STATUS
>> +SetMemoryRegionAttributes (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINTN Length,
>> + IN UINTN Attributes,
>> + IN UINT64 AttributeMask
>> + );
>> +
>> +/**
>> + Sets the non-executable Attributes for the specified memory region
>> +
>> + @param[in] BaseAddress The base address of the memory region to set
>> the Attributes.
>> + @param[in] Length The length of the memory region to set the
>> Attributes.
>> +
>> + @retval EFI_SUCCESS The Attributes was set successfully
>> +**/
>> +EFI_STATUS
>> +SetMemoryRegionNoExec (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINTN Length
>> + );
>> +
>> +/**
>> + Clears the non-executable Attributes for the specified memory region
>> +
>> + @param[in] BaseAddress The base address of the memory region to clear
>> the Attributes.
>> + @param[in] Length The length of the memory region to clear the
>> Attributes.
>> +
>> + @retval EFI_SUCCESS The Attributes was clear successfully
>> +**/
>> +EFI_STATUS
>> +EFIAPI
>> +ClearMemoryRegionNoExec (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINT64 Length
>> + );
>> +
>> +/**
>> + Sets the read-only Attributes for the specified memory region
>> +
>> + @param[in] BaseAddress The base address of the memory region to set
>> the Attributes.
>> + @param[in] Length The length of the memory region to set the
>> Attributes.
>> +
>> + @retval EFI_SUCCESS The Attributes was set successfully
>> +**/
>> +EFI_STATUS
>> +EFIAPI
>> +SetMemoryRegionReadOnly (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINT64 Length
>> + );
>> +
>> +/**
>> + Clears the read-only Attributes for the specified memory region
>> +
>> + @param[in] BaseAddress The base address of the memory region to clear
>> the Attributes.
>> + @param[in] Length The length of the memory region to clear the
>> Attributes.
>> +
>> + @retval EFI_SUCCESS The Attributes was clear successfully
>> +**/
>> +EFI_STATUS
>> +EFIAPI
>> +ClearMemoryRegionReadOnly (
>> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
>> + IN UINT64 Length
>> + );
>> +
>> +/**
>> + Create a page table and initialize the memory management unit(MMU).
>> +
>> + @param[in] MemoryTable A pointer to a memory ragion table.
>> + @param[out] TranslationTableBase A pointer to a translation table base
>> address.
>> + @param[out] TranslationTableSize A pointer to a translation table base
>> size.
>> +
>> + @retval EFI_SUCCESS Configure MMU successfully.
>> + EFI_INVALID_PARAMETER MemoryTable is NULL.
>> + EFI_UNSUPPORTED Out of memory space or size not aligned.
>> +**/
>> +EFI_STATUS
>> +EFIAPI
>> +ConfigureMemoryManagementUint (
>> + IN MEMORY_REGION_DESCRIPTOR *MemoryTable,
>> + OUT VOID **TranslationTableBase OPTIONAL,
>> + OUT UINTN *TranslationTableSize OPTIONAL
>> + );
>> +
>> +#endif // CPU_MMU_LIB_H_
>> diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index
>> 154b1d06fe..150beae981 100644
>> --- a/UefiCpuPkg/UefiCpuPkg.dec
>> +++ b/UefiCpuPkg/UefiCpuPkg.dec
>> @@ -62,6 +62,10 @@
>> ## @libraryclass Provides function for manipulating x86 paging structures.
>> CpuPageTableLib|Include/Library/CpuPageTableLib.h
>>
>> +[LibraryClasses.LoongArch64]
>> + ## @libraryclass Provides macros and functions for the memory
>> management unit.
>> + CpuMmuLib|Include/Library/CpuMmuLib.h
>> +
>> ## @libraryclass Provides functions for manipulating smram savestate
>> registers.
>> MmSaveStateLib|Include/Library/MmSaveStateLib.h
>>
>> --
>> 2.27.0
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111442): https://edk2.groups.io/g/devel/message/111442
Mute This Topic: https://groups.io/mt/102644768/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 11409 bytes --]
next prev parent reply other threads:[~2023-11-20 3:26 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231117095742.3605778-1-lichao@loongs>
2023-11-17 9:58 ` [edk2-devel] [PATCH v3 01/39] MdePkg: Add the header file named Csr.h for LoongArch64 Chao Li
2023-11-17 9:58 ` [edk2-devel] [PATCH v3 02/39] MdePkg: Add LoongArch64 FPU function set into BaseCpuLib Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 03/39] MdePkg: Add LoongArch64 exception function set into BaseLib Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 04/39] MdePkg: Add LoongArch64 local interrupt " Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 05/39] MdePkg: Add LoongArch Cpucfg function Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 06/39] MdePkg: Add read stable counter operation for LoongArch Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 07/39] MdePkg: Add CSR " Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 08/39] MdePkg: Add IOCSR " Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 09/39] MdePkg: Add a new library named PeiServicesTablePointerLibReg Chao Li
2023-11-17 11:35 ` Leif Lindholm
2023-11-20 3:07 ` Chao Li
2023-11-21 14:37 ` Laszlo Ersek
2023-11-22 1:47 ` Chao Li
2023-11-24 11:35 ` Laszlo Ersek
2023-11-27 3:27 ` Chao Li
2023-12-01 0:32 ` 回复: " gaoliming via groups.io
2023-12-01 8:20 ` Chao Li
[not found] ` <179B5D231F190982.32091@groups.io>
2023-11-29 1:35 ` Chao Li
2023-11-17 9:59 ` [edk2-devel] [PATCH v3 10/39] MdePkg: Add method of LoongArch64 to PeiServicesTablePointerLibReg Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 11/39] UefiCpuPkg: Add LoongArch64 CPU Timer library Chao Li
2023-11-22 16:12 ` Laszlo Ersek
2023-11-22 16:13 ` Laszlo Ersek
2023-11-23 11:43 ` Chao Li
2023-12-11 17:16 ` Laszlo Ersek
2023-12-12 3:45 ` Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 12/39] UefiCpuPkg: Add CPU exception library for LoongArch Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 13/39] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg Chao Li
2023-11-17 20:18 ` Andrei Warkentin
2023-11-20 3:26 ` Chao Li [this message]
2023-11-30 0:59 ` Ni, Ray
2023-11-30 2:25 ` Chao Li
[not found] ` <179C457B5B852375.31732@groups.io>
2023-12-04 7:31 ` Chao Li
2023-12-05 8:27 ` Ni, Ray
2023-12-05 12:27 ` Chao Li
[not found] ` <179DEF40376B662A.18076@groups.io>
2023-12-08 2:10 ` Chao Li
2023-12-11 8:13 ` Ni, Ray
2023-12-11 8:19 ` Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 14/39] UefiCpuPkg: Add LoongArch64CpuMmuLib " Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 15/39] UefiCpuPkg: Add multiprocessor library for LoongArch64 Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 16/39] UefiCpuPkg: Add CpuDxe driver " Chao Li
2023-11-17 10:00 ` [edk2-devel] [PATCH v3 17/39] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64 Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 18/39] ArmVirtPkg: Move PCD of FDT base address and FDT padding to OvmfPkg Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 19/39] MdePkg: Add a PCD feature flag named PcdPciIoTranslationIsEnabled Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 20/39] UefiCpuPkg: Add MMIO method in CpuIo2Dxe Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 21/39] ArmVirtPkg: Enable UefiCpuPkg version CpuIo2Dxe Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 22/39] ArmPkg: Remove ArmPciCpuIo2Dxe from ArmPkg Chao Li
2023-11-17 13:13 ` Leif Lindholm
2023-11-20 3:24 ` Chao Li
2023-11-20 18:47 ` Leif Lindholm
2023-11-21 1:10 ` Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 23/39] OvmfPkg/RiscVVirt: Enable UefiCpuPkg version CpuIo2Dxe Chao Li
2023-11-17 20:15 ` Andrei Warkentin
2023-11-20 3:04 ` Chao Li
2023-11-17 10:01 ` [edk2-devel] [PATCH v3 24/39] OvmfPkg/RiscVVirt: Remove PciCpuIo2Dxe from RiscVVirt Chao Li
2023-11-17 10:02 ` [edk2-devel] [PATCH v3 25/39] ArmVirtPkg: Move the FdtSerialPortAddressLib to OvmfPkg Chao Li
2023-11-17 10:02 ` [edk2-devel] [PATCH v3 26/39] ArmVirtPkg: Move the PcdTerminalTypeGuidBuffer into OvmfPkg Chao Li
2023-11-17 10:02 ` [edk2-devel] [PATCH v3 27/39] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg Chao Li
2023-11-17 10:02 ` [edk2-devel] [PATCH v3 28/39] OvmfPkg/LoongArchVirt: Add stable timer driver Chao Li
2023-11-17 10:02 ` [edk2-devel] [PATCH v3 29/39] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull Chao Li
2023-11-17 10:02 ` [edk2-devel] [PATCH v3 30/39] OvmfPkg/LoongArchVirt: Add serial port hook library Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 31/39] OvmfPkg/LoongArchVirt: Add the early serial port output library Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 32/39] OvmfPkg/LoongArchVirt: Add real time clock library Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 33/39] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 34/39] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 35/39] OvmfPkg/LoongArchVirt: Add reset system library Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 36/39] OvmfPkg/LoongArchVirt: Support SEC phase Chao Li
2023-11-17 10:03 ` [edk2-devel] [PATCH v3 37/39] OvmfPkg/LoongArchVirt: Support PEI phase Chao Li
2023-11-17 10:04 ` [edk2-devel] [PATCH v3 38/39] OvmfPkg/LoongArchVirt: Add build file Chao Li
2023-11-17 10:04 ` [edk2-devel] [PATCH v3 39/39] OvmfPkg/LoongArchVirt: Add self introduction file Chao Li
[not found] ` <179860C0A131BC70.3002@groups.io>
2023-11-20 9:55 ` [edk2-devel] [PATCH v3 14/39] UefiCpuPkg: Add LoongArch64CpuMmuLib to UefiCpuPkg Chao Li
[not found] ` <179860DB0A3E8D83.6542@groups.io>
2023-11-21 6:39 ` [edk2-devel] [PATCH v3 27/39] ArmVirtPkg: Move PlatformBootManagerLib to OvmfPkg Chao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01436801-9a8d-46ec-9c0f-e85051340fc5@loongson.cn \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox