From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"sean.brogan@microsoft.com" <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Gao, Liming" <liming.gao@intel.com>
Cc: "Leif Lindholm (Nuvia address)" <leif@nuviainc.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
Date: Mon, 9 Mar 2020 20:29:30 +0100 [thread overview]
Message-ID: <01473986-a0f7-6143-6f81-63611f1f6b00@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9EC85C4@ORSMSX113.amr.corp.intel.com>
Hi Mike,
On 03/08/20 20:53, Kinney, Michael D wrote:
> I added the @Mergifyio refresh to these PRs.
>
> This one was merged:
> https://github.com/tianocore/edk2/pull/427
>
> This one is failing PatchCheck with a missing Signed-off-by
> https://github.com/tianocore/edk2/pull/430
>
> This one needs to be rebased and resubmitted
> https://github.com/tianocore/edk2/pull/428
Thanks for kicking mergify.
I think maintainers should have permission to kick mergify (if they
don't have that permission already). Otherwise, the automated
merge-on-CI-pass is not actually automated, and we create a bottleneck
in an otherwise distributed / asynchronous workflow. If only you can
kick mergify, then any *valid* (CI-clean) pull request will potentially
have to wait on you.
Mergify kicking rights do not allow maintainers to bypass CI checks, if
I understand correctly. (Unlike direct merge / repository write access.)
BTW I didn't even know about this mergify "command". Is there a guide
somewhere?
I honestly feel this should have been handled / introduced more
transparently. I rarely feel as powerless as with PR#428. CI passed, the
PR was stuck, github didn't respond to my ticket, mergify.io didn't
respond to my ticket, and the PR was actually urgent (fixing a build
breakage). I was sitting there uncomfortably as one of the stewards,
unable to fix the situation. Earlier all this would take was a git-push
command.
Thanks
Laszlo
next prev parent reply other threads:[~2020-03-09 19:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 19:21 [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master Sean
2020-03-08 19:53 ` Michael D Kinney
2020-03-09 19:29 ` Laszlo Ersek [this message]
2020-03-09 19:32 ` Laszlo Ersek
2020-03-09 22:00 ` Michael D Kinney
2020-03-09 19:37 ` Laszlo Ersek
2020-03-09 20:06 ` Laszlo Ersek
2020-03-09 21:44 ` Michael D Kinney
2020-03-10 7:53 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2019-11-12 2:55 Michael D Kinney
2019-11-12 8:56 ` [edk2-devel] " Laszlo Ersek
2019-11-12 19:50 ` Michael D Kinney
2019-11-12 19:52 ` Michael D Kinney
2019-11-13 7:56 ` Laszlo Ersek
2019-11-13 8:57 ` Laszlo Ersek
2019-11-13 16:23 ` Michael D Kinney
2019-11-13 17:03 ` Laszlo Ersek
2019-11-26 8:23 ` Laszlo Ersek
2019-11-27 19:03 ` Michael D Kinney
2019-11-28 12:00 ` Laszlo Ersek
2019-12-02 19:55 ` Michael D Kinney
2019-12-03 8:56 ` Laszlo Ersek
2019-12-03 17:07 ` Michael D Kinney
2019-12-03 20:39 ` Laszlo Ersek
2019-12-06 11:02 ` Laszlo Ersek
2019-12-06 11:07 ` Laszlo Ersek
2020-01-02 14:42 ` Philippe Mathieu-Daudé
2020-01-02 18:36 ` Michael D Kinney
2020-01-06 14:58 ` Philippe Mathieu-Daudé
2020-01-03 13:29 ` Laszlo Ersek
2020-01-06 17:29 ` Laszlo Ersek
2020-01-06 18:17 ` Michael D Kinney
2020-01-07 9:00 ` Laszlo Ersek
2020-01-09 21:30 ` Laszlo Ersek
2020-01-09 21:37 ` Michael D Kinney
2020-01-10 10:51 ` Laszlo Ersek
2020-03-08 11:12 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01473986-a0f7-6143-6f81-63611f1f6b00@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox